Skip to content

Commit 26791bc

Browse files
committed
Gardening: Migrate test suite to GH issues: validation-test/Sema (1/2)
1 parent b2f386d commit 26791bc

26 files changed

+44
-18
lines changed

validation-test/Sema/OverridesAndOverloads.swift

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ Overrides.test("covariant argument override, optional derived class to non-optio
7676
}
7777

7878
Overrides.test("covariant argument override, protocol to protocol") {
79-
// FIXME: https://bugs.swift.org/browse/SR-731
79+
// FIXME: https://github.com/apple/swift/issues/43346
8080
// Covariant overrides don't work with protocols
8181
class Base {
8282
func foo(_: P1x) { which = "Base.foo(P1x)" }
@@ -93,7 +93,7 @@ Overrides.test("covariant argument override, protocol to protocol") {
9393
}
9494

9595
Overrides.test("covariant argument override, struct to protocol") {
96-
// FIXME: https://bugs.swift.org/browse/SR-731
96+
// FIXME: https://github.com/apple/swift/issues/43346
9797
// Covariant overrides don't work with protocols
9898
class Base {
9999
func foo(_: P1ImplS1) { which = "Base.foo(P1ImplS1)" }
@@ -102,7 +102,7 @@ Overrides.test("covariant argument override, struct to protocol") {
102102
/*FIXME: override */ func foo(_: P1) { which = "Derived.foo(P1)" }
103103
}
104104

105-
// FIXME: https://bugs.swift.org/browse/SR-731
105+
// FIXME: https://github.com/apple/swift/issues/43346
106106
Derived().foo(P1ImplS1())
107107
expectEqual("Base.foo(P1ImplS1)", which)
108108

@@ -162,7 +162,7 @@ Overrides.test("contravariant return type override, optional base class to non-o
162162
}
163163

164164
Overrides.test("contravariant return type override, protocol to protocol") {
165-
// FIXME: https://bugs.swift.org/browse/SR-733
165+
// FIXME: https://github.com/apple/swift/issues/43348
166166
// Contravariant overrides on return type don't work with protocols
167167
class Base {
168168
func foo() -> P1 { which = "Base.foo() -> P1"; return P1ImplS1() }
@@ -173,7 +173,7 @@ Overrides.test("contravariant return type override, protocol to protocol") {
173173
}
174174
}
175175

176-
// https://bugs.swift.org/browse/SR-733
176+
// https://github.com/apple/swift/issues/43348
177177
// FIXME: uncomment when the bug is fixed.
178178
// Derived().foo() as P1 // error: ambiguous use of 'foo()'
179179
// expectEqual("Derived.foo() -> P1x", which)
@@ -183,7 +183,7 @@ Overrides.test("contravariant return type override, protocol to protocol") {
183183
}
184184

185185
Overrides.test("contravariant return type override, protocol to struct") {
186-
// FIXME: https://bugs.swift.org/browse/SR-733
186+
// FIXME: https://github.com/apple/swift/issues/43348
187187
// Contravariant overrides on return type don't work with protocols
188188
class Base {
189189
func foo() -> P1 { which = "Base.foo() -> P1"; return P1ImplS1() }
@@ -194,7 +194,7 @@ Overrides.test("contravariant return type override, protocol to struct") {
194194
}
195195
}
196196

197-
// https://bugs.swift.org/browse/SR-733
197+
// https://github.com/apple/swift/issues/43348
198198
// FIXME: uncomment when the bug is fixed.
199199
// Derived().foo() as P1 // error: ambiguous use of 'foo()'
200200
// expectEqual("Derived.foo() -> P1ImplS1", which)

validation-test/Sema/SwiftUI/sr14093.swift renamed to validation-test/Sema/SwiftUI/issue-56479.swift

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
// REQUIRES: objc_interop
44
// REQUIRES: OS=macosx
55

6+
// https://github.com/apple/swift/issues/56479
7+
68
import SwiftUI
79
import Foundation
810

validation-test/Sema/SwiftUI/sr14213.swift renamed to validation-test/Sema/SwiftUI/issue-56591.swift

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
// REQUIRES: objc_interop
44
// REQUIRES: OS=macosx
55

6+
// https://github.com/apple/swift/issues/56591
7+
68
import SwiftUI
79

810
struct Experiment: View {

validation-test/Sema/sr9644.swift renamed to validation-test/Sema/issue-52088.swift

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
1-
// RUN: %target-swift-frontend -typecheck -primary-file %s %S/Inputs/sr9644-helper.swift -import-objc-header %S/Inputs/sr9644.h -verify
1+
// RUN: %target-swift-frontend -typecheck -primary-file %s %S/Inputs/issue-52088-helper.swift -import-objc-header %S/Inputs/issue-52088.h -verify
22

33
// REQUIRES: objc_interop
44
// expected-no-warning
55

6+
// https://github.com/apple/swift/issues/52088
7+
68
protocol HasAssoc {
79
associatedtype Assoc: TestProto
810
}

validation-test/Sema/sr14692.swift renamed to validation-test/Sema/issue-57042.swift

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
// RUN: %target-typecheck-verify-swift
22

3+
// https://github.com/apple/swift/issues/57042
4+
35
enum Foo { case foo }
46
enum Bar { case bar }
57

validation-test/Sema/sr8209.swift

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,15 @@
1-
// RUN: %target-swift-frontend -module-name SR8209 -primary-file %s %S/Inputs/sr8209-helper.swift -emit-ir | %FileCheck %s
2-
// RUN: %target-swift-frontend -module-name SR8209 -primary-file %s %S/Inputs/sr8209-helper.swift -DREVERSE -emit-ir | %FileCheck %s
3-
// RUN: %target-swift-frontend -module-name SR8209 %S/Inputs/sr8209-helper.swift -primary-file %s -emit-ir | %FileCheck %s
4-
// RUN: %target-swift-frontend -module-name SR8209 %S/Inputs/sr8209-helper.swift -primary-file %s -DREVERSE -emit-ir | %FileCheck %s
1+
// RUN: %target-swift-frontend -module-name M -primary-file %s %S/Inputs/issue-50741-helper.swift -emit-ir | %FileCheck %s
2+
// RUN: %target-swift-frontend -module-name M -primary-file %s %S/Inputs/issue-50741-helper.swift -DREVERSE -emit-ir | %FileCheck %s
3+
// RUN: %target-swift-frontend -module-name M %S/Inputs/issue-50741-helper.swift -primary-file %s -emit-ir | %FileCheck %s
4+
// RUN: %target-swift-frontend -module-name M %S/Inputs/issue-50741-helper.swift -primary-file %s -DREVERSE -emit-ir | %FileCheck %s
55

66
// REQUIRES: objc_interop
77

8+
// https://github.com/apple/swift/issues/50741
9+
810
import Foundation
911

10-
// CHECK-LABEL: define {{.+}} @"$s6SR82094test10ObjectiveC8SelectorVyF"() {{#[0-9]+}}
12+
// CHECK-LABEL: define {{.+}} @"$s1M4test10ObjectiveC8SelectorVyF"() {{#[0-9]+}}
1113
func test() -> Selector {
1214
// CHECK: = load {{.+}} @"\01L_selector(isAsynchronous)"
1315
return #selector(getter: AsyncValueBlockOperation.isAsynchronous)

0 commit comments

Comments
 (0)