[Sema] simplify IsNoncopyableRequest::evaluate

Author: kavon

include/swift/AST/TypeCheckRequests.h

@@ -428,8 +428,8 @@ class HasNoncopyableAnnotationRequest
   void cacheResult(bool value) const;
 };
 
-/// Determine whether the given type is noncopyable. Assumes type parameters
-/// have become archetypes.
+/// Determine whether the given type is noncopyable.
+/// Assumes a generic signature has been built.
 class IsNoncopyableRequest
     : public SimpleRequest<IsNoncopyableRequest, bool(CanType),
                            RequestFlags::Cached> {

lib/Sema/TypeCheckInvertible.cpp

@@ -131,19 +131,17 @@ static void tryEmitContainmentFixits(NominalTypeDecl *enclosingNom,
 
 bool IsNoncopyableRequest::evaluate(Evaluator &evaluator,
                                     CanType type) const {
-  assert(!type->hasTypeParameter() // && !type->hasUnboundGenericType()
-             && "forgot to mapTypeIntoContext first");
+  assert(!type->hasTypeParameter() && "forgot to mapTypeIntoContext first");
   auto &ctx = type->getASTContext();
 
-  auto *protocol =
-      TypeChecker::getProtocol(ctx, SourceLoc(), KnownProtocolKind::Copyable);
-  if (!protocol)
+  auto *copyable = ctx.getProtocol(KnownProtocolKind::Copyable);
+  if (!copyable)
     llvm_unreachable("missing Copyable protocol!");
 
   const bool conforms =
       (bool)TypeChecker::conformsToProtocol(type,
-                                            protocol,
-                                            protocol->getParentModule(),
+                                            copyable,
+                                            copyable->getParentModule(),
                                             /*allowMissing=*/false);
 
   return !conforms;