Skip to content

Commit 2931c21

Browse files
committed
[docs] Fix libicu paths for Android
https://bugs.swift.org/browse/SR-1264 identified a problem in the documentation: the `--android-icu-uc` and `--android-icu-i18n` are documented in `utils/build-script` as taking the path to *the directory that contains* the `libcicuuc.so` and `libicui18n.so` libraries, not the paths to the libraries themselves. Passing the path to the libraries themselves causes a build error. Fix the path to prevent people from encountering an error when copying the build script invocation in the docs.
1 parent 5ac651d commit 2931c21

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

docs/Android.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -70,17 +70,18 @@ Alternatively, you may choose to build libiconv and libicu for Android yourself:
7070
### 2. Building the Swift stdlib for Android
7171

7272
Enter your Swift directory, then run the build script, passing paths to the
73-
Android NDK and libicu/libiconv directories:
73+
Android NDK, as well as the directories that contain the `libicuuc.so` and
74+
`libicui18n.so` you downloaded or built in step one:
7475

7576
```
7677
$ utils/build-script \
7778
-R \ # Build in ReleaseAssert mode.
7879
--android \ # Build for Android.
7980
--android-ndk ~/android-ndk-r11c \ # Path to an Android NDK.
8081
--android-api-level 21 \ # The Android API level to target. Swift only supports 21 or greater.
81-
--android-icu-uc ~/libicu-android/armeabi-v7a/libicuuc.so \
82+
--android-icu-uc ~/libicu-android/armeabi-v7a \
8283
--android-icu-uc-include ~/libicu-android/armeabi-v7a/icu/source/common \
83-
--android-icu-i18n ~/libicu-android/armeabi-v7a/libicui18n.so \
84+
--android-icu-i18n ~/libicu-android/armeabi-v7a \
8485
--android-icu-i18n-include ~/libicu-android/armeabi-v7a/icu/source/i18n/
8586
```
8687

0 commit comments

Comments
 (0)