Skip to content

Commit 2c700be

Browse files
committed
Add a TODO in PrunedLivenessBoundary::visitInsertionPoints
1 parent d977dd1 commit 2c700be

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

lib/SIL/Utils/PrunedLiveness.cpp

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -227,6 +227,14 @@ void PrunedLivenessBoundary::dump() const {
227227
print(llvm::dbgs());
228228
}
229229

230+
// TODO: with guaranteed phis, it will be possible to hit this assert:
231+
// assert(succ->getSinglePredecessorBlock() == predBB);
232+
//
233+
// Once it's possible to test dead guaranteed phis, replace the assert with a
234+
// set to avoid multiple insertions at a merge point:
235+
// // Control flow merge blocks used as insertion points.
236+
// BasicBlockSet mergeBlocks;
237+
//
230238
void PrunedLivenessBoundary::visitInsertionPoints(
231239
llvm::function_ref<void(SILBasicBlock::iterator insertPt)> visitor,
232240
DeadEndBlocks *deBlocks) {

0 commit comments

Comments
 (0)