[SILGen] Added TODO.

nate-chandler · nate-chandler · commit 31b2d8166eac · 2022-08-21T21:44:31.000-07:00
diff --git a/lib/SILGen/Scope.cpp b/lib/SILGen/Scope.cpp
@@ -57,6 +57,8 @@ static void lifetimeExtendAddressOnlyRValueSubValues(
            "addresses must be address only.");
     auto boxTy = SILBoxType::get(v->getType().getASTType());
     SILValue box = SGF.B.createAllocBox(loc, boxTy);
+    // TODO: Should these boxes that extend lifetimes for rvalue subobjects ever
+    //       be lexical?
     if (SGF.getASTContext().SILOpts.supportsLexicalLifetimes(SGF.getModule())) {
       box = SGF.B.createBeginBorrow(loc, box, /*isLexical=*/true);
     }

Original file line number	Diff line number	Diff line change
`@@ -57,6 +57,8 @@ static void lifetimeExtendAddressOnlyRValueSubValues(`
`57`	`57`	`"addresses must be address only.");`
`58`	`58`	`auto boxTy = SILBoxType::get(v->getType().getASTType());`
`59`	`59`	`SILValue box = SGF.B.createAllocBox(loc, boxTy);`
	`60`	`+ // TODO: Should these boxes that extend lifetimes for rvalue subobjects ever`
	`61`	`+ // be lexical?`
`60`	`62`	`if (SGF.getASTContext().SILOpts.supportsLexicalLifetimes(SGF.getModule())) {`
`61`	`63`	`box = SGF.B.createBeginBorrow(loc, box, /isLexical=/true);`
`62`	`64`	`}`