[FixCode] Avoid removing @ib* attributes

If there are type-checking issues, these interact poorly with the
migrator and may remove @ib* attributes unnecessarily.

rdar://problem/26886636

Author: benlangmuir

lib/FrontendTool/FrontendTool.cpp

@@ -569,6 +569,17 @@ class JSONFixitWriter : public DiagnosticConsumer {
     if (Info.ID == diag::objc_witness_selector_mismatch.ID ||
         Info.ID == diag::witness_non_objc.ID)
       return false;
+    // The following interact badly with the swift migrator by removing @IB*
+    // attributes when there is some unrelated type issue.
+    if (Info.ID == diag::invalid_iboutlet.ID ||
+        Info.ID == diag::iboutlet_nonobjc_class.ID ||
+        Info.ID == diag::iboutlet_nonobjc_protocol.ID ||
+        Info.ID == diag::iboutlet_nonobject_type.ID ||
+        Info.ID == diag::iboutlet_only_mutable.ID ||
+        Info.ID == diag::invalid_ibdesignable_extension.ID ||
+        Info.ID == diag::invalid_ibinspectable.ID ||
+        Info.ID == diag::invalid_ibaction_decl.ID)
+      return false;
 
     if (Kind == DiagnosticKind::Error)
       return true;

test/FixCode/fixits-apply.swift

@@ -180,3 +180,18 @@ func evilCommas(s: String) {
 
 import Empty
 func testGenericSig(x: Empty<Int>) -> Empty<String> {}
+
+class NonObjC {}
+protocol NonObjCProtocol {}
+@objc class IBIssues {
+  @IBOutlet static private var ibout1: IBIssues!
+  @IBOutlet private var ibout2: NonObjC!
+  @IBOutlet private var ibout3: NonObjCProtocol!
+  @IBOutlet private let ibout4: IBIssues!
+  @IBOutlet private var ibout5: [[IBIssues]]!
+  @IBOutlet private var ibout6: [String:String]!
+  @IBInspectable static private var ibinspect1: IBIssues!
+  @IBAction static func ibact() {}
+}
+
+@IBDesignable extension SomeProt {}

test/FixCode/fixits-apply.swift.result

@@ -183,3 +183,18 @@ func evilCommas(s: String) {
 
 import Empty
 func testGenericSig(x: Empty<Int>) -> Empty<String> {}
+
+class NonObjC {}
+protocol NonObjCProtocol {}
+@objc class IBIssues {
+  @IBOutlet static private var ibout1: IBIssues!
+  @IBOutlet private var ibout2: NonObjC!
+  @IBOutlet private var ibout3: NonObjCProtocol!
+  @IBOutlet private let ibout4: IBIssues!
+  @IBOutlet private var ibout5: [[IBIssues]]!
+  @IBOutlet private var ibout6: [String:String]!
+  @IBInspectable static private var ibinspect1: IBIssues!
+  @IBAction static func ibact() {}
+}
+
+@IBDesignable extension SomeProt {}