Merge pull request #62076 from slavapestov/no-assert-test-hang-fix

Disable 0022-rdar21625478.swift entirely on noassert builds

Author: slavapestov

lib/SILGen/SILGenPoly.cpp

@@ -4483,6 +4483,8 @@ void SILGenFunction::emitProtocolWitness(
                                           ->getCanonicalType());
   }
 
+  assert(!witnessSubstTy->hasError());
+
   if (auto genericFnType = dyn_cast<GenericFunctionType>(reqtSubstTy)) {
     auto forwardingSubs = F.getForwardingSubstitutionMap();
     reqtSubstTy = cast<FunctionType>(genericFnType
@@ -4493,6 +4495,8 @@ void SILGenFunction::emitProtocolWitness(
                                           ->getCanonicalType());
   }
 
+  assert(!reqtSubstTy->hasError());
+
   // Get the lowered type of the witness.
   auto origWitnessFTy = getWitnessFunctionType(getTypeExpansionContext(), SGM,
                                                witness, witnessKind);

validation-test/compiler_crashers_2_fixed/0022-rdar21625478.swift

@@ -3,6 +3,9 @@
 // rdar://80395274 tracks getting this to pass with the requirement machine.
 // XFAIL: *
 
+// The test hangs in a noassert build:
+// REQUIRES: asserts
+
 import StdlibUnittest
 
 public struct MyRange<Bound : ForwardIndex> {