[embedded] Also cover DestroyArray builtin in embedded Swift mode

Author: kubamracek

SwiftCompilerSources/Sources/Optimizer/InstructionSimplification/SimplifyBuiltin.swift

@@ -32,7 +32,8 @@ extension BuiltinInst : OnoneSimplifyable {
            .Strideof,
            .Alignof:
         optimizeTargetTypeConst(context)
-      case .CopyArray,
+      case .DestroyArray,
+           .CopyArray,
            .TakeArrayNoAlias,
            .TakeArrayFrontToBack,
            .TakeArrayBackToFront,

lib/IRGen/GenBuiltin.cpp

@@ -1105,7 +1105,42 @@ void irgen::emitBuiltinCall(IRGenFunction &IGF, const BuiltinInfo &Builtin,
 
     auto valueTy = getLoweredTypeAndTypeInfo(IGF.IGM,
                                              substitutions.getReplacementTypes()[0]);
-    
+
+    if (IGF.IGM.Context.LangOpts.hasFeature(Feature::Embedded)) {
+      SILType elemTy = valueTy.first;
+      const TypeInfo &elemTI = valueTy.second;
+
+      llvm::Value *firstElem = IGF.Builder.CreateBitCast(
+          ptr, elemTI.getStorageType()->getPointerTo());
+
+      auto *origBB = IGF.Builder.GetInsertBlock();
+      auto *headerBB = IGF.createBasicBlock("loop_header");
+      auto *loopBB = IGF.createBasicBlock("loop_body");
+      auto *exitBB = IGF.createBasicBlock("loop_exit");
+      IGF.Builder.CreateBr(headerBB);
+      IGF.Builder.emitBlock(headerBB);
+      auto *phi = IGF.Builder.CreatePHI(count->getType(), 2);
+      phi->addIncoming(llvm::ConstantInt::get(count->getType(), 0), origBB);
+      llvm::Value *cmp = IGF.Builder.CreateICmpSLT(phi, count);
+      IGF.Builder.CreateCondBr(cmp, loopBB, exitBB);
+
+      IGF.Builder.emitBlock(loopBB);
+      auto *addr = IGF.Builder.CreateInBoundsGEP(elemTI.getStorageType(),
+                                                 firstElem, phi);
+
+      bool isOutlined = false;
+      elemTI.destroy(IGF, elemTI.getAddressForPointer(addr), elemTy,
+                     isOutlined);
+
+      auto *one = llvm::ConstantInt::get(count->getType(), 1);
+      auto *add = IGF.Builder.CreateAdd(phi, one);
+      phi->addIncoming(add, loopBB);
+      IGF.Builder.CreateBr(headerBB);
+
+      IGF.Builder.emitBlock(exitBB);
+      return;
+    }
+
     ptr = IGF.Builder.CreateBitCast(ptr,
                               valueTy.second.getStorageType()->getPointerTo());
     Address array = valueTy.second.getAddressForPointer(ptr);

test/embedded/array-builtins-no-stdlib.swift

@@ -16,11 +16,16 @@ public func foo(x: Builtin.RawPointer, y: Builtin.RawPointer, count: Builtin.Wor
   Builtin.assignCopyArrayFrontToBack(MyStruct.self, x, y, count)
   Builtin.assignCopyArrayBackToFront(MyStruct.self, x, y, count)
   Builtin.assignTakeArray(MyStruct.self, x, y, count)
+  Builtin.destroyArray(MyStruct.self, x, count)
 }
 
 // No runtime calls should be present.
 // CHECK-NOT: @swift_arrayInitWithCopy
+// CHECK-NOT: @swift_arrayInitWithTakeNoAlias
+// CHECK-NOT: @swift_arrayInitWithTakeFrontToBack
+// CHECK-NOT: @swift_arrayInitWithTakeBackToFront
 // CHECK-NOT: @swift_arrayAssignWithCopyNoAlias
 // CHECK-NOT: @swift_arrayAssignWithCopyFrontToBack
 // CHECK-NOT: @swift_arrayAssignWithCopyBackToFront
 // CHECK-NOT: @swift_arrayAssignWithTake
+// CHECK-NOT: @swift_arrayDestroy

test/embedded/array-builtins2-no-stdlib.swift

@@ -24,12 +24,17 @@ public struct MyGenericStruct<T> {
     Builtin.assignCopyArrayFrontToBack(T.self, x, y, count)
     Builtin.assignCopyArrayBackToFront(T.self, x, y, count)
     Builtin.assignTakeArray(T.self, x, y, count)
+    Builtin.destroyArray(T.self, x, count)
   }
 }
 
 // No runtime calls should be present.
 // CHECK-NOT: @swift_arrayInitWithCopy
+// CHECK-NOT: @swift_arrayInitWithTakeNoAlias
+// CHECK-NOT: @swift_arrayInitWithTakeFrontToBack
+// CHECK-NOT: @swift_arrayInitWithTakeBackToFront
 // CHECK-NOT: @swift_arrayAssignWithCopyNoAlias
 // CHECK-NOT: @swift_arrayAssignWithCopyFrontToBack
 // CHECK-NOT: @swift_arrayAssignWithCopyBackToFront
 // CHECK-NOT: @swift_arrayAssignWithTake
+// CHECK-NOT: @swift_arrayDestroy