Merge pull request #84543 from nate-chandler/rdar161371112

[OwnershipDiagnosticLowering] Visit autorelease_value insts.

Author: nate-chandler

lib/SILOptimizer/Mandatory/MoveOnlyWrappedTypeEliminator.cpp

@@ -205,43 +205,44 @@ struct SILMoveOnlyWrappedTypeEliminatorVisitor
 
 #define NO_UPDATE_NEEDED(CLS)                                                  \
   bool visit##CLS##Inst(CLS##Inst *inst) { return false; }
-  NO_UPDATE_NEEDED(AllocStack)
+  NO_UPDATE_NEEDED(AddressToPointer)
   NO_UPDATE_NEEDED(AllocBox)
-  NO_UPDATE_NEEDED(ProjectBox)
-  NO_UPDATE_NEEDED(DebugValue)
-  NO_UPDATE_NEEDED(StructElementAddr)
-  NO_UPDATE_NEEDED(TupleElementAddr)
-  NO_UPDATE_NEEDED(UncheckedTakeEnumDataAddr)
-  NO_UPDATE_NEEDED(DestructureTuple)
-  NO_UPDATE_NEEDED(DestructureStruct)
-  NO_UPDATE_NEEDED(SelectEnum)
-  NO_UPDATE_NEEDED(MarkDependence)
-  NO_UPDATE_NEEDED(MarkDependenceAddr)
-  NO_UPDATE_NEEDED(DestroyAddr)
-  NO_UPDATE_NEEDED(DeallocStack)
-  NO_UPDATE_NEEDED(DeallocBox)
+  NO_UPDATE_NEEDED(AllocStack)
+  NO_UPDATE_NEEDED(AutoreleaseValue)
+  NO_UPDATE_NEEDED(BeginAccess)
   NO_UPDATE_NEEDED(Branch)
-  NO_UPDATE_NEEDED(ExplicitCopyAddr)
-  NO_UPDATE_NEEDED(CopyAddr)
-  NO_UPDATE_NEEDED(RefElementAddr)
+  NO_UPDATE_NEEDED(BridgeObjectToRef)
+  NO_UPDATE_NEEDED(Builtin)
   NO_UPDATE_NEEDED(CheckedCastBranch)
-  NO_UPDATE_NEEDED(Object)
-  NO_UPDATE_NEEDED(OpenExistentialRef)
-  NO_UPDATE_NEEDED(OpenExistentialAddr)
-  NO_UPDATE_NEEDED(OpenExistentialBox)
+  NO_UPDATE_NEEDED(ClassMethod)
   NO_UPDATE_NEEDED(ConvertFunction)
-  NO_UPDATE_NEEDED(RefToBridgeObject)
-  NO_UPDATE_NEEDED(BridgeObjectToRef)
-  NO_UPDATE_NEEDED(BeginAccess)
+  NO_UPDATE_NEEDED(CopyAddr)
+  NO_UPDATE_NEEDED(DeallocBox)
+  NO_UPDATE_NEEDED(DeallocStack)
+  NO_UPDATE_NEEDED(DebugValue)
+  NO_UPDATE_NEEDED(DestroyAddr)
+  NO_UPDATE_NEEDED(DestructureStruct)
+  NO_UPDATE_NEEDED(DestructureTuple)
   NO_UPDATE_NEEDED(EndAccess)
   NO_UPDATE_NEEDED(EndCOWMutationAddr)
-  NO_UPDATE_NEEDED(ClassMethod)
-  NO_UPDATE_NEEDED(FixLifetime)
-  NO_UPDATE_NEEDED(AddressToPointer)
   NO_UPDATE_NEEDED(ExistentialMetatype)
-  NO_UPDATE_NEEDED(Builtin)
+  NO_UPDATE_NEEDED(ExplicitCopyAddr)
+  NO_UPDATE_NEEDED(FixLifetime)
   NO_UPDATE_NEEDED(IgnoredUse)
+  NO_UPDATE_NEEDED(MarkDependence)
+  NO_UPDATE_NEEDED(MarkDependenceAddr)
   NO_UPDATE_NEEDED(ObjCMethod)
+  NO_UPDATE_NEEDED(Object)
+  NO_UPDATE_NEEDED(OpenExistentialAddr)
+  NO_UPDATE_NEEDED(OpenExistentialBox)
+  NO_UPDATE_NEEDED(OpenExistentialRef)
+  NO_UPDATE_NEEDED(ProjectBox)
+  NO_UPDATE_NEEDED(RefElementAddr)
+  NO_UPDATE_NEEDED(RefToBridgeObject)
+  NO_UPDATE_NEEDED(SelectEnum)
+  NO_UPDATE_NEEDED(StructElementAddr)
+  NO_UPDATE_NEEDED(TupleElementAddr)
+  NO_UPDATE_NEEDED(UncheckedTakeEnumDataAddr)
 #undef NO_UPDATE_NEEDED
 
   bool eliminateIdentityCast(SingleValueInstruction *svi) {
@@ -258,6 +259,7 @@ struct SILMoveOnlyWrappedTypeEliminatorVisitor
   }
   ELIMINATE_POTENTIAL_IDENTITY_CAST(Upcast)
   ELIMINATE_POTENTIAL_IDENTITY_CAST(UncheckedAddrCast)
+  ELIMINATE_POTENTIAL_IDENTITY_CAST(UncheckedRefCast)
   ELIMINATE_POTENTIAL_IDENTITY_CAST(UnconditionalCheckedCast)
 #undef ELIMINATE_POTENTIAL_IDENTITY_CAST
   // We handle apply sites by just inserting a convert_function that converts

validation-test/SILOptimizer/rdar161371112.swift

@@ -0,0 +1,56 @@
+// RUN: %empty-directory(%t)
+// RUN: split-file %s %t
+// RUN: %target-swift-frontend \
+// RUN:     %t/Library.swift \
+// RUN:     -enable-experimental-feature Lifetimes \
+// RUN:     -sil-verify-all \
+// RUN:     -verify \
+// RUN:     -emit-sil \
+// RUN:     -import-objc-header %t/Header.h \
+// RUN: > /dev/null
+
+// REQUIRES: objc_interop
+
+// REQUIRES: swift_feature_Lifetimes
+
+//--- Header.h
+
+@import Foundation;
+
+@interface Foo : NSObject
+@property (nonatomic, readwrite) NSInteger length;
+- (const unichar *)_fastCharacterContents NS_RETURNS_INNER_POINTER;
+@end
+
+//--- Library.swift
+
+extension Foo {
+    var utf16Span: Span<UInt16>? {
+        @_lifetime(borrow self)
+        borrowing get {
+            // FIXME: This error shouldn't be here.
+            guard let ptr = self._fastCharacterContents() else { // expected-error{{copy of noncopyable typed value}}
+                return nil
+            }
+            let length = self.length
+            let buffer = UnsafeBufferPointer(start: ptr, count: length)
+            let span = unsafe Span<UInt16>(_unsafeElements: buffer)
+            return _overrideLifetime(span, borrowing: self)
+        }
+    }
+}
+
+extension NSString {
+    var utf16Span: Span<UInt16>? {
+        @_lifetime(borrow self)
+        borrowing get { // expected-error{{'self' is borrowed and cannot be consumed}}
+            guard let ptr = CFStringGetCharactersPtr(self) else { // expected-note{{consumed here}}
+                return nil
+            }
+            let length = self.length
+            let buffer = UnsafeBufferPointer(start: ptr, count: length)
+            let span = unsafe Span<UInt16>(_unsafeElements: buffer)
+            return _overrideLifetime(span, borrowing: self)
+        }
+    }
+}