[Build] Properly respect the darwin-crash-reporter-client setting.

al45tair · al45tair · commit 373b9e14de70 · 2022-03-25T23:34:20.000Z
This was being turned on even when set to zero, because of the logic
in `build-script-impl`.

rdar://90839754
diff --git a/utils/build-script-impl b/utils/build-script-impl
@@ -1670,7 +1670,7 @@ for host in "${ALL_HOSTS[@]}"; do
     if [[ "${DARWIN_CRASH_REPORTER_CLIENT}" ]] ; then
         swift_cmake_options=(
             "${swift_cmake_options[@]}"
-            -DSWIFT_RUNTIME_CRASH_REPORTER_CLIENT:BOOL=TRUE
+            -DSWIFT_RUNTIME_CRASH_REPORTER_CLIENT:BOOL=$(true_false "${DARWIN_CRASH_REPORTER_CLIENT}")
         )
     fi
 

Original file line number	Diff line number	Diff line change
`@@ -1670,7 +1670,7 @@ for host in "${ALL_HOSTS[@]}"; do`
`1670`	`1670`	`if [[ "${DARWIN_CRASH_REPORTER_CLIENT}" ]] ; then`
`1671`	`1671`	`swift_cmake_options=(`
`1672`	`1672`	`"${swift_cmake_options[@]}"`
`1673`		`- -DSWIFT_RUNTIME_CRASH_REPORTER_CLIENT:BOOL=TRUE`
	`1673`	`+ -DSWIFT_RUNTIME_CRASH_REPORTER_CLIENT:BOOL=$(true_false "${DARWIN_CRASH_REPORTER_CLIENT}")`
`1674`	`1674`	`)`
`1675`	`1675`	`fi`
`1676`	`1676`