Skip to content

Commit 392e02d

Browse files
committed
Rather than turning off sil-verify-all on all stdlib builds... Re-enable it only on the macOS x86_64 platform.
Most of the stdlibs at the SIL level are the same so by not verifying them all, we aren't losing that much coverage. This gives us back some of the coverage we lost when we disabled -sil-verify-all everywhere without causing us to have the huge slow down when building multiple stdlibs.
1 parent 825fa53 commit 392e02d

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

stdlib/cmake/modules/SwiftSource.cmake

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -459,8 +459,8 @@ function(_compile_swift_files
459459

460460
if(SWIFT_SIL_VERIFY_ALL_MACOS_ONLY)
461461
# Only add if we have a macOS build triple
462-
if (STREQUAL "${SWIFTFILE_SDK}" "OSX" AND
463-
STREQUAL "${SWIFTFILE_ARCHITECTURE}" "x86_64")
462+
if ("${SWIFTFILE_SDK}" STREQUAL "OSX" AND
463+
"${SWIFTFILE_ARCHITECTURE}" STREQUAL "x86_64")
464464
list(APPEND swift_flags "-Xfrontend" "-sil-verify-all")
465465
endif()
466466
endif()

utils/build-presets.ini

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1602,6 +1602,9 @@ skip-build-tvos
16021602
skip-test-tvos
16031603
skip-test-tvos-host
16041604

1605+
# Run the SIL verifier after each transform when building swift files
1606+
sil-verify-all-macos-only
1607+
16051608
# Don't run host tests for iOS, tvOS and watchOS platforms to make the build
16061609
# faster.
16071610
skip-test-ios-host

0 commit comments

Comments
 (0)