Merge pull request #83900 from eeckstein/fix-sil-printer

SIL: fix printing of dependent existential archetypes

Author: eeckstein

lib/AST/ASTPrinter.cpp

@@ -7221,6 +7221,9 @@ class TypePrinter : public TypeVisitor<TypePrinter, void, NonRecursivePrintOptio
     if (Options.PrintForSIL) {
       auto *env = T->getGenericEnvironment();
 
+      if (!T->isRoot())
+        Printer << '(';
+
       Printer << "@opened(\"" << env->getOpenedExistentialUUID() << "\", ";
       auto existentialTy = env->maybeApplyOuterContextSubstitutions(
           env->getOpenedExistentialType());
@@ -7232,7 +7235,8 @@ class TypePrinter : public TypeVisitor<TypePrinter, void, NonRecursivePrintOptio
       auto interfaceTy = T->getInterfaceType();
       auto selfTy = interfaceTy->getRootGenericParam();
       auto &ctx = selfTy->getASTContext();
-      newAlternativeTypeNames[selfTy->getCanonicalType()] = ctx.Id_Self;
+      Identifier selfId = (T->isRoot() ? ctx.Id_Self : ctx.getIdentifier("Self)"));
+      newAlternativeTypeNames[selfTy->getCanonicalType()] = selfId;
 
       PrintOptions::OverrideScope scope(Options);
       OVERRIDE_PRINT_OPTION(scope, AlternativeTypeNames, &newAlternativeTypeNames);

test/SIL/Parser/basic.sil

@@ -1744,6 +1744,22 @@ bb0:
   return %1 : $()
 }
 
+protocol P2 {
+  associatedtype A
+}
+
+// CHECK-LABEL: sil [ossa] @test_dependent_existential_archetype :
+// CHECK:         %2 = alloc_stack $(@opened("0B7C132E-8010-11F0-8526-0EA13E3AABB4", any P2) Self).A
+// CHECK-LABEL: } // end sil function 'test_dependent_existential_archetype'
+sil [ossa] @test_dependent_existential_archetype : $@convention(thin) (@thick any P2.Type) -> () {
+bb0(%0 : $@thick any P2.Type):
+  %1 = open_existential_metatype %0 to $@thick (@opened("0B7C132E-8010-11F0-8526-0EA13E3AABB4", any P2) Self).Type
+  %2 = alloc_stack $(@opened("0B7C132E-8010-11F0-8526-0EA13E3AABB4", any P2) Self).A
+  dealloc_stack %2
+  %r = tuple ()
+  return %r
+}
+
 class Foo2: Foo {}
 
 // CHECK-LABEL: sil_vtable Foo {