Merge pull request #60920 from AnthonyLatsis/migrate-test-suite-to-gh-issues-17

Gardening: Migrate test suite to GH issues p. 17

Author: AnthonyLatsis

test/NameLookup/InheritedConformance.swift

@@ -2,7 +2,9 @@
 // RUN: cp %s %t/main.swift
 // RUN: %target-swift-frontend -typecheck -primary-file %t/main.swift -emit-reference-dependencies-path - > %t.swiftdeps
 
-// SR-1267, SR-1270
+// https://github.com/apple/swift/issues/43875
+// https://github.com/apple/swift/issues/43878
+
 protocol Protocol {}
 class ConformingClass: Protocol {}
 class BaseClass<T: Protocol> {}

test/NameLookup/custom_attrs_ambiguous.swift

@@ -5,7 +5,7 @@
 import custom_attrs_A
 import custom_attrs_B
 
-// SR-13470
+// https://github.com/apple/swift/issues/55912
 
 struct Test {
   @Wrapper var x: Int = 17

test/NameLookup/name_lookup.swift

@@ -288,7 +288,8 @@ class ThisDerived1 : ThisBase1 {
     self.Type // expected-error {{type 'ThisDerived1' has no member 'Type'}}
   }
 
-  // FIXME(SR-15250): Partial application diagnostic is applied incorrectly for some test cases.
+  // FIXME: Partial application diagnostic is applied incorrectly for some
+  // test cases (https://github.com/apple/swift/issues/57572).
   class func staticTestSuper1() {
     super.baseInstanceVar = 42 // expected-error {{member 'baseInstanceVar' cannot be used on type 'ThisBase1'}}
     super.baseProp = 42 // expected-error {{member 'baseProp' cannot be used on type 'ThisBase1'}}
@@ -585,8 +586,8 @@ func foo1() {
   _ = MyGenericEnum<Int>.OneTwo // expected-error {{enum type 'MyGenericEnum<Int>' has no case 'OneTwo'; did you mean 'oneTwo'?}}{{26-32=oneTwo}}
 }
 
-// SR-4082
-func foo2() {
+// https://github.com/apple/swift/issues/46665
+do {
   let x = 5
   if x < 0, let x = Optional(1) { } // expected-warning {{immutable value 'x' was never used; consider replacing with '_' or removing it}}
 }
@@ -649,8 +650,8 @@ struct PatternBindingWithTwoVars3 { var x = y, y = x }
 // expected-note@-11 {{through reference here}}
 // expected-note@-12 {{through reference here}}
 
-// https://bugs.swift.org/browse/SR-9015
-func sr9015() {
+// https://github.com/apple/swift/issues/51518
+do {
   let closure1 = { closure2() } // expected-error {{circular reference}} expected-note {{through reference here}} expected-note {{through reference here}}
   let closure2 = { closure1() } // expected-note {{through reference here}} expected-note {{through reference here}} expected-note {{through reference here}}
 }

test/Parse/ConditionalCompilation/decl_in_true_inactive.swift

@@ -1,7 +1,10 @@
 // RUN: %target-typecheck-verify-swift -D FOO -D BAR
 
-// SR-3996 Incorrect type checking when using defines
+// https://github.com/apple/swift/issues/46581
+// Incorrect type checking when using defines
+//
 // Decls in true-but-inactive blocks used to be leaked.
+
 func f1() -> Int {
 #if FOO
   let val = 1

test/Parse/ConditionalCompilation/pound-if-top-level-4.swift

@@ -1,7 +1,8 @@
 // RUN: %target-typecheck-verify-swift
 
-// https://bugs.swift.org/browse/SR-4426
-// '#if' in top-level code that contains only decls should not disturb forward reference.
+// https://github.com/apple/swift/issues/47003
+// '#if' in top-level code that contains only declarations should not disturb
+// forward reference.
 
 typealias A = B
 

test/Parse/diagnose_availability.swift

@@ -1,6 +1,7 @@
 // RUN: %target-typecheck-verify-swift 
 
-// SR-4231: Misleading/wrong error message for malformed @available
+// https://github.com/apple/swift/issues/46814
+// Misleading/wrong error message for malformed '@available'
 
 @available(OSX 10.6, *) // no error
 func availableSince10_6() {}
@@ -28,7 +29,8 @@ func availableOnMultiplePlatforms() {}
 func twoShorthandsFollowedByDeprecated() {}
 
 
-// SR-8598: Missing/wrong warning message for '*' or 'swift' platform.
+// https://github.com/apple/swift/issues/51114
+// Missing/wrong warning message for '*' or 'swift' platform.
 
 @available(*, deprecated: 4.2)
 // expected-warning@-1 {{unexpected version number in 'available' attribute for non-specific platform '*'}} {{25-30=}}

test/Parse/diagnose_initializer_as_typed_pattern.swift

@@ -1,6 +1,6 @@
 // RUN: %target-typecheck-verify-swift
 
-// https://bugs.swift.org/browse/SR-1461
+// https://github.com/apple/swift/issues/44070
 
 class X {}
 func foo() {}

test/Parse/diagnostic_missing_func_keyword.swift

@@ -1,6 +1,6 @@
 // RUN: %target-typecheck-verify-swift
 
-// https://bugs.swift.org/browse/SR-10477
+// https://github.com/apple/swift/issues/52877
 
 protocol Brew { // expected-note {{in declaration of 'Brew'}}
   tripel() -> Int // expected-error {{expected 'func' keyword in instance method declaration}} {{3-3=func }}

test/Parse/dollar_identifier.swift

@@ -1,6 +1,7 @@
 // RUN: %target-typecheck-verify-swift -swift-version 4
 
-// SR-1661: Dollar was accidentally allowed as an identifier in Swift 3.
+// https://github.com/apple/swift/issues/44270
+// Dollar was accidentally allowed as an identifier in Swift 3.
 // SE-0144: Reject this behavior in the future.
 
 func dollarVar() {
@@ -105,7 +106,8 @@ infix operator **: $Precedence
 #$UnknownDirective() // expected-error {{use of unknown directive '#$UnknownDirective'}}
 
 
-// SR-13232
+// https://github.com/apple/swift/issues/55672
+
 @propertyWrapper
 struct Wrapper {
   var wrappedValue: Int
@@ -118,5 +120,6 @@ struct S {
 
 let _ = S().$café // Okay
 
-infix operator $ // expected-error{{'$' is considered an identifier and must not appear within an operator name}} // SR-13092
-infix operator `$` // expected-error{{'$' is considered an identifier and must not appear within an operator name}} // SR-13092
+// https://github.com/apple/swift/issues/55538
+infix operator $ // expected-error{{'$' is considered an identifier and must not appear within an operator name}}
+infix operator `$` // expected-error{{'$' is considered an identifier and must not appear within an operator name}}

test/Parse/enum.swift

@@ -553,42 +553,43 @@ enum SE0155 {
   // expected-note@-2 {{did you mean to explicitly add a 'Void' associated value?}} {{18-18=Void}}
 }
 
-// SR-11261
-enum SR11261 {
+// https://github.com/apple/swift/issues/53662
+
+enum E_53662 {
   case identifier
   case operator // expected-error {{keyword 'operator' cannot be used as an identifier here}} expected-note {{if this name is unavoidable, use backticks to escape it}} {{8-16=`operator`}}
   case identifier2
 }
 
-enum SR11261_var {
+enum E_53662_var {
   case identifier
   case var // expected-error {{keyword 'var' cannot be used as an identifier here}} expected-note {{if this name is unavoidable, use backticks to escape it}} {{8-11=`var`}}
   case identifier2
 }
 
-enum SR11261_underscore {
+enum E_53662_underscore {
   case identifier
   case _ // expected-error {{keyword '_' cannot be used as an identifier here}} expected-note {{if this name is unavoidable, use backticks to escape it}} {{8-9=`_`}}
   case identifier2
 }
 
-enum SR11261_Comma {
+enum E_53662_Comma {
   case a, b, c, func, d // expected-error {{keyword 'func' cannot be used as an identifier here}} expected-note {{if this name is unavoidable, use backticks to escape it}} {{17-21=`func`}}
 }
 
-enum SR11261_Newline {
+enum E_53662_Newline {
   case identifier1
   case identifier2
   case 
   case identifier // expected-error {{keyword 'case' cannot be used as an identifier here}} expected-note {{if this name is unavoidable, use backticks to escape it}} {{3-7=`case`}}
 }
 
-enum SR11261_Newline2 {
+enum E_53662_Newline2 {
   case 
   func foo() {} // expected-error {{keyword 'func' cannot be used as an identifier here}} expected-note {{if this name is unavoidable, use backticks to escape it}} {{3-7=`func`}}
 }
 
-enum SR11261_PatternMatching {
+enum E_53662_PatternMatching {
   case let .foo(x, y): // expected-error {{'case' label can only appear inside a 'switch' statement}}
 }