[CanonicalizeOSSALifetime] Renamed member.

The member just clears the values.  After it adopted BitfieldRef, the
call to invalidate on the liveness instance was already superfluous.

Author: nate-chandler

include/swift/SILOptimizer/Utils/CanonicalizeOSSALifetime.h

@@ -325,10 +325,9 @@ class CanonicalizeOSSALifetime final {
     liveness->initializeDef(getCurrentDef());
   }
 
-  void invalidateLiveness() {
+  void clear() {
     consumingBlocks.clear();
     debugValues.clear();
-    liveness->invalidate();
     discoveredBlocks.clear();
   }
 

lib/SILOptimizer/Utils/CanonicalizeOSSALifetime.cpp

@@ -1108,7 +1108,7 @@ bool CanonicalizeOSSALifetime::computeLiveness() {
   // Step 1: compute liveness
   if (!computeCanonicalLiveness()) {
     LLVM_DEBUG(llvm::errs() << "Failed to compute canonical liveness?!\n");
-    invalidateLiveness();
+    clear();
     return false;
   }
   if (currentDef->isLexical()) {
@@ -1145,7 +1145,7 @@ void CanonicalizeOSSALifetime::rewriteLifetimes() {
   // Step 6: rewrite copies and delete extra destroys
   rewriteCopies();
 
-  invalidateLiveness();
+  clear();
   consumes.clear();
 }