[DebugInfo] Properly nest types declared in extensions in the debug info

rdar://161923580

Author: adrian-prantl

lib/IRGen/IRGenDebugInfo.cpp

@@ -729,6 +729,16 @@ class IRGenDebugInfoImpl : public IRGenDebugInfo {
     if (!DC)
       return TheCU;
 
+    auto createContext = [&](NominalTypeDecl &NTD) {
+      GenericContextScope scope(
+          IGM, NTD.getGenericSignature().getCanonicalSignature());
+
+      auto Ty = NTD.getDeclaredInterfaceType();
+      // Create a Forward-declared type.
+      auto DbgTy = DebugTypeInfo::getForwardDecl(Ty);
+      return getOrCreateType(DbgTy);
+    };
+
     if (isa<FuncDecl>(DC))
       if (auto *Decl = IGM.getSILModule().lookUpFunction(SILDeclRef(
               cast<AbstractFunctionDecl>(DC), SILDeclRef::Kind::Func)))
@@ -742,7 +752,6 @@ class IRGenDebugInfoImpl : public IRGenDebugInfo {
 
     // We don't model these in DWARF.
     case DeclContextKind::Initializer:
-    case DeclContextKind::ExtensionDecl:
     case DeclContextKind::SubscriptDecl:
     case DeclContextKind::EnumElementDecl:
     case DeclContextKind::TopLevelCodeDecl:
@@ -761,16 +770,17 @@ class IRGenDebugInfoImpl : public IRGenDebugInfo {
       return getOrCreateContext(DC->getParent());
     case DeclContextKind::MacroDecl:
       return getOrCreateContext(DC->getParent());
+    case DeclContextKind::ExtensionDecl: {
+      auto *ED = cast<ExtensionDecl>(DC);
+      if (auto *NTD = ED->getExtendedNominal())
+        return createContext(*NTD);
+      return getOrCreateContext(DC->getParent());
+    }
     case DeclContextKind::GenericTypeDecl: {
-      // The generic signature of this nominal type has no relation to the current
-      // function's generic signature.
+      // The generic signature of this nominal type has no relation to the
+      // current function's generic signature.
       auto *NTD = cast<NominalTypeDecl>(DC);
-      GenericContextScope scope(IGM, NTD->getGenericSignature().getCanonicalSignature());
-
-      auto Ty = NTD->getDeclaredInterfaceType();
-      // Create a Forward-declared type.
-      auto DbgTy = DebugTypeInfo::getForwardDecl(Ty);
-      return getOrCreateType(DbgTy);
+      return createContext(*NTD);
     }
     }
     return TheCU;
@@ -2618,6 +2628,8 @@ class IRGenDebugInfoImpl : public IRGenDebugInfo {
     llvm::MDString *UID = nullptr;
     if (canMangle(DbgTy.getType())) {
       Mangled = getMangledName(DbgTy);
+      if (Mangled.Canonical=="$s11NestedTypes1DV1VVyx_GD")
+        llvm::errs();
       if (!Mangled.Sugared.empty()) {
         UID = llvm::MDString::get(IGM.getLLVMContext(), Mangled.Sugared);
         if (llvm::Metadata *CachedTy = DIRefMap.lookup(UID))

test/DebugInfo/NestedTypes.swift

@@ -16,3 +16,19 @@ public let e : Enum = .WithClass(C())
 // CHECK: !DIDerivedType(tag: DW_TAG_member, name: "WithStruct",
 // CHECK-SAME:           size: 128)
 
+public struct D<U> {
+  var v : V
+  let u: U
+}
+
+extension D {
+  struct V {
+    internal var obj: Int
+  }
+}
+
+public let d = D<Int>(v: D.V(obj: 1), u: 2)
+
+// CHECK: ![[D:.*]] = !DICompositeType(tag: DW_TAG_structure_type, name: "D"
+// CHECK: !DICompositeType(tag: DW_TAG_structure_type, name: "V", scope: ![[D]],
+