Inline check for existential type and use isa

aviralg · aviralg · commit 3d919e162340 · 2025-10-07T11:12:17.000-07:00
diff --git a/lib/Sema/PerformanceHints.cpp b/lib/Sema/PerformanceHints.cpp
@@ -67,12 +67,9 @@ void checkImplicitCopyReturnType(const ClosureExpr *Closure,
   }
 }
 
-bool isExistentialType(Type T) {
-  return dyn_cast<ExistentialType>(T) != nullptr;
-}
-
-bool hasExistentialAnyInType(Type type) {
-  return type->getCanonicalType().findIf(isExistentialType);
+bool hasExistentialAnyInType(Type T) {
+  return T->getCanonicalType().findIf(
+      [](CanType CT) { return isa<ExistentialType>(CT); });
 }
 
 void checkExistentialInFunctionReturnType(const FuncDecl *FD,

Original file line number	Diff line number	Diff line change
`@@ -67,12 +67,9 @@ void checkImplicitCopyReturnType(const ClosureExpr *Closure,`
`67`	`67`	`}`
`68`	`68`	`}`
`69`	`69`
`70`		`-bool isExistentialType(Type T) {`
`71`		`- return dyn_cast<ExistentialType>(T) != nullptr;`
`72`		`-}`
`73`		`-`
`74`		`-bool hasExistentialAnyInType(Type type) {`
`75`		`- return type->getCanonicalType().findIf(isExistentialType);`
	`70`	`+bool hasExistentialAnyInType(Type T) {`
	`71`	`+ return T->getCanonicalType().findIf(`
	`72`	`+ [](CanType CT) { return isa<ExistentialType>(CT); });`
`76`	`73`	`}`
`77`	`74`
`78`	`75`	`void checkExistentialInFunctionReturnType(const FuncDecl *FD,`