Skip to content

Commit 4093b7b

Browse files
committed
AST: Don't print cached request values when dumping dependencies
This becomes tricky with the new per-request cache representation. We can add it back later if we need it, but I feel like this code path isn't particularly useful right now anyway.
1 parent a370676 commit 4093b7b

File tree

2 files changed

+4
-16
lines changed

2 files changed

+4
-16
lines changed

lib/AST/Evaluator.cpp

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -148,13 +148,6 @@ void Evaluator::printDependencies(
148148
out.resetColor();
149149
}
150150

151-
// Print the cached value, if known.
152-
auto cachedValue = cache.find(request);
153-
if (cachedValue != cache.end()) {
154-
out << " -> ";
155-
printEscapedString(cachedValue->second.getAsString(), out);
156-
}
157-
158151
if (!visitedAnywhere.insert(request).second) {
159152
// We've already seed this node. Check whether it's part of a cycle.
160153
if (std::find(visitedAlongPath.begin(), visitedAlongPath.end(), request)
@@ -313,11 +306,6 @@ void Evaluator::printDependenciesGraphviz(llvm::raw_ostream &out) const {
313306
out << " [label=\"";
314307
printEscapedString(request.getAsString(), out);
315308

316-
auto cachedValue = cache.find(request);
317-
if (cachedValue != cache.end()) {
318-
out << " -> ";
319-
printEscapedString(cachedValue->second.getAsString(), out);
320-
}
321309
out << "\"";
322310

323311
if (auto color = getColor(request)) {

unittests/AST/ArithmeticEvaluator.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -265,8 +265,8 @@ TEST(ArithmeticEvaluator, Simple) {
265265
}
266266

267267
EXPECT_EQ(productDependencies,
268-
" `--InternallyCachedEvaluationRule(Binary: product) -> 2.461145e+02\n"
269-
" `--InternallyCachedEvaluationRule(Binary: sum) -> 5.859870e+00\n"
268+
" `--InternallyCachedEvaluationRule(Binary: product)\n"
269+
" `--InternallyCachedEvaluationRule(Binary: sum)\n"
270270
" | `--InternallyCachedEvaluationRule(Literal: 3.141590e+00)\n"
271271
" | `--InternallyCachedEvaluationRule(Literal: 2.718280e+00)\n"
272272
" `--InternallyCachedEvaluationRule(Literal: 4.200000e+01)\n");
@@ -311,8 +311,8 @@ TEST(ArithmeticEvaluator, Simple) {
311311
" request_2 [label=\"ExternallyCachedEvaluationRule(Literal: 2.718280e+00)\"];\n"
312312
" request_3 [label=\"ExternallyCachedEvaluationRule(Literal: 3.141590e+00)\"];\n"
313313
" request_4 [label=\"ExternallyCachedEvaluationRule(Literal: 4.200000e+01)\"];\n"
314-
" request_5 [label=\"InternallyCachedEvaluationRule(Binary: product) -> 2.461145e+02\"];\n"
315-
" request_6 [label=\"InternallyCachedEvaluationRule(Binary: sum) -> 5.859870e+00\"];\n"
314+
" request_5 [label=\"InternallyCachedEvaluationRule(Binary: product)\"];\n"
315+
" request_6 [label=\"InternallyCachedEvaluationRule(Binary: sum)\"];\n"
316316
" request_7 [label=\"InternallyCachedEvaluationRule(Literal: 2.718280e+00)\"];\n"
317317
" request_8 [label=\"InternallyCachedEvaluationRule(Literal: 3.141590e+00)\"];\n"
318318
" request_9 [label=\"InternallyCachedEvaluationRule(Literal: 4.200000e+01)\"];\n"

0 commit comments

Comments
 (0)