Merge pull request #37552 from etcwilde/ewilde/nfc-clean-uncovered-async-insertions

[NFC] Cleanup uncovered async diagnostic inserts

Author: etcwilde

lib/Sema/TypeCheckEffects.cpp

@@ -2651,15 +2651,10 @@ class CheckEffectsCoverage : public EffectsHandlingWalker<CheckEffectsCoverage>
         Expr *expr = E.dyn_cast<Expr*>();
         Expr *anchor = walkToAnchor(expr, parentMap,
                                     CurContext.isWithinInterpolatedString());
-
-        auto key = uncoveredAsync.find(anchor);
-        if (key == uncoveredAsync.end()) {
-          uncoveredAsync.insert({anchor, {}});
+        if (uncoveredAsync.find(anchor) == uncoveredAsync.end())
           errorOrder.push_back(anchor);
-        }
-        uncoveredAsync[anchor].emplace_back(
-            *expr,
-            classification.getAsyncReason());
+        uncoveredAsync[anchor].emplace_back(*expr,
+                                            classification.getAsyncReason());
       }
     }