AST: Resolve types when computing inherited conformances for classes.

Previously, conformances inherited through a base class could be missed in lazy
typechecking mode if types in the inheritance clause were not already resolved.

Author: tshortli

lib/AST/ConformanceLookupTable.cpp

@@ -226,16 +226,18 @@ void ConformanceLookupTable::inheritConformances(ClassDecl *classDecl,
     if (superclassLoc.isValid())
       return superclassLoc;
 
-    for (const auto &inherited : classDecl->getInherited().getEntries()) {
-      if (auto inheritedType = inherited.getType()) {
+    auto inheritedTypes = classDecl->getInherited();
+    for (unsigned i : inheritedTypes.getIndices()) {
+      if (auto inheritedType = inheritedTypes.getResolvedType(i)) {
+
         if (inheritedType->getClassOrBoundGenericClass()) {
-          superclassLoc = inherited.getSourceRange().Start;
+          superclassLoc = inheritedTypes.getEntry(i).getSourceRange().Start;
           return superclassLoc;
         }
         if (inheritedType->isExistentialType()) {
           auto layout = inheritedType->getExistentialLayout();
           if (layout.explicitSuperclass) {
-            superclassLoc = inherited.getSourceRange().Start;
+            superclassLoc = inheritedTypes.getEntry(i).getSourceRange().Start;
             return superclassLoc;
           }
         }

test/Inputs/lazy_typecheck.swift

@@ -115,6 +115,8 @@ public class PublicClass {
 //  class func internalClassMethod() -> DoesNotExist {}
 }
 
+public class PublicDerivedClass: PublicClass {}
+
 class InternalClass: DoesNotExist { // expected-error {{cannot find type 'DoesNotExist' in scope}}
   init(x: DoesNotExist) {} // expected-error {{cannot find type 'DoesNotExist' in scope}}
 }
@@ -135,6 +137,8 @@ public class PublicClassConformingToPublicProto: PublicProto {
   }
 }
 
+public class PublicClassInheritingConformanceToPublicProto: PublicClassConformingToPublicProto {}
+
 extension String: PublicProto {
   public func req() -> Int {
     return true // expected-error {{cannot convert return expression of type 'Bool' to return type 'Int'}}

test/Inputs/lazy_typecheck_client.swift

@@ -30,12 +30,21 @@ func testPublicClass() {
   let c = PublicClass(x: 2)
   _ = c.publicMethod()
   PublicClass.publicClassMethod()
+
+  let d = PublicDerivedClass(x: 3)
+  _ = d.publicMethod()
+  PublicDerivedClass.publicClassMethod()
 }
 
 func testConformances() {
-  let _: [any PublicProto] = [
+  let array: [any PublicProto] = [
     PublicStructConformingToPublicProto(),
     PublicClassConformingToPublicProto(),
     "string",
+    PublicClassInheritingConformanceToPublicProto(),
   ]
+
+  for x in array {
+    _ = x.req()
+  }
 }

test/ModuleInterface/lazy-typecheck.swift

@@ -45,6 +45,10 @@
 // CHECK:         public class func publicClassMethod()
 // CHECK:         deinit
 // CHECK:       }
+// CHECK:       @_inheritsConvenienceInitializers public class PublicDerivedClass : lazy_typecheck.PublicClass {
+// CHECK:         override public init(x: Swift.Int)
+// CHECK:         deinit
+// CHECK:       }
 // CHECK:       public struct PublicStructConformingToPublicProto : lazy_typecheck.PublicProto {
 // CHECK:         public init()
 // CHECK:         public func req() -> Swift.Int
@@ -54,6 +58,10 @@
 // CHECK:         public func req() -> Swift.Int
 // CHECK:         deinit
 // CHECK:       }
+// CHECK:       @_inheritsConvenienceInitializers public class PublicClassInheritingConformanceToPublicProto : lazy_typecheck.PublicClassConformingToPublicProto {
+// CHECK:         override public init()
+// CHECK:         deinit
+// CHECK:       }
 // CHECK:       extension Swift.String : lazy_typecheck.PublicProto {
 // CHECK:         public func req() -> Swift.Int
 // CHECK:       }

test/TBD/lazy-typecheck.swift

@@ -40,6 +40,15 @@ exports:
                        '_$s14lazy_typecheck024PublicStructConformingToC5ProtoVMa',
                        '_$s14lazy_typecheck024PublicStructConformingToC5ProtoVMn',
                        '_$s14lazy_typecheck024PublicStructConformingToC5ProtoVN',
+                       '_$s14lazy_typecheck034PublicClassInheritingConformanceToC5ProtoCACycfC',
+                       '_$s14lazy_typecheck034PublicClassInheritingConformanceToC5ProtoCACycfc',
+                       '_$s14lazy_typecheck034PublicClassInheritingConformanceToC5ProtoCMa',
+                       '_$s14lazy_typecheck034PublicClassInheritingConformanceToC5ProtoCMm',
+                       '_$s14lazy_typecheck034PublicClassInheritingConformanceToC5ProtoCMn',
+                       '_$s14lazy_typecheck034PublicClassInheritingConformanceToC5ProtoCMo',
+                       '_$s14lazy_typecheck034PublicClassInheritingConformanceToC5ProtoCN',
+                       '_$s14lazy_typecheck034PublicClassInheritingConformanceToC5ProtoCfD',
+                       '_$s14lazy_typecheck034PublicClassInheritingConformanceToC5ProtoCfd',
                        '_$s14lazy_typecheck10publicFuncSiyF', '_$s14lazy_typecheck11PublicClassC06publicD6MethodyyFZTj',
                        '_$s14lazy_typecheck11PublicClassC06publicD6MethodyyFZTq',
                        '_$s14lazy_typecheck11PublicClassC12publicMethodSiyFTj', '_$s14lazy_typecheck11PublicClassC12publicMethodSiyFTq',
@@ -55,10 +64,14 @@ exports:
                        '_$s14lazy_typecheck12PublicStructV18publicStaticMethodyyFZ',
                        '_$s14lazy_typecheck12PublicStructV1xACSi_tcfC', '_$s14lazy_typecheck12PublicStructVMa',
                        '_$s14lazy_typecheck12PublicStructVMn', '_$s14lazy_typecheck12PublicStructVN',
-                       '_$s14lazy_typecheck13inlinableFuncSiyF', '_$s14lazy_typecheck19PublicRethrowsProtoMp',
-                       '_$s14lazy_typecheck19PublicRethrowsProtoP3reqSiyKFTj', '_$s14lazy_typecheck19PublicRethrowsProtoP3reqSiyKFTq',
-                       '_$s14lazy_typecheck19PublicRethrowsProtoTL', '_$s14lazy_typecheck24publicFuncWithDefaultArgyS2iF',
-                       '_$s14lazy_typecheck30publicFuncWithOpaqueReturnTypeQryF',
+                       '_$s14lazy_typecheck13inlinableFuncSiyF', '_$s14lazy_typecheck18PublicDerivedClassC1xACSi_tcfC',
+                       '_$s14lazy_typecheck18PublicDerivedClassC1xACSi_tcfc', '_$s14lazy_typecheck18PublicDerivedClassCMa',
+                       '_$s14lazy_typecheck18PublicDerivedClassCMm', '_$s14lazy_typecheck18PublicDerivedClassCMn',
+                       '_$s14lazy_typecheck18PublicDerivedClassCMo', '_$s14lazy_typecheck18PublicDerivedClassCN',
+                       '_$s14lazy_typecheck18PublicDerivedClassCfD', '_$s14lazy_typecheck18PublicDerivedClassCfd',
+                       '_$s14lazy_typecheck19PublicRethrowsProtoMp', '_$s14lazy_typecheck19PublicRethrowsProtoP3reqSiyKFTj',
+                       '_$s14lazy_typecheck19PublicRethrowsProtoP3reqSiyKFTq', '_$s14lazy_typecheck19PublicRethrowsProtoTL',
+                       '_$s14lazy_typecheck24publicFuncWithDefaultArgyS2iF', '_$s14lazy_typecheck30publicFuncWithOpaqueReturnTypeQryF',
                        '_$s14lazy_typecheck30publicFuncWithOpaqueReturnTypeQryFQOMQ',
                        '_$s14lazy_typecheck32constrainedGenericPublicFunctionyyxAA0E5ProtoRzlF',
                        '_$sSS14lazy_typecheck11PublicProtoAAMc', '_$sSS14lazy_typecheck11PublicProtoAAWP',