Skip to content

Commit 43970ac

Browse files
committed
[android] Fix an install path and the displayed NDK in the build log (#82620)
I just noticed the install issue when cross-compiling Testing with a freshly-built compiler, which I'd never done before. Also, fix the NDK path shown in the CMake output.
1 parent 21d90c5 commit 43970ac

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

cmake/modules/SwiftConfigureSDK.cmake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ function(_report_sdk prefix)
5353
endforeach()
5454
elseif("${prefix}" STREQUAL "ANDROID")
5555
if(NOT "${SWIFT_ANDROID_NDK_PATH}" STREQUAL "")
56-
message(STATUS " NDK: $ENV{SWIFT_ANDROID_NDK_PATH}")
56+
message(STATUS " NDK: ${SWIFT_ANDROID_NDK_PATH}")
5757
endif()
5858
if(NOT "${SWIFT_ANDROID_NATIVE_SYSROOT}" STREQUAL "")
5959
message(STATUS " Sysroot: ${SWIFT_ANDROID_NATIVE_SYSROOT}")

utils/swift_build_support/swift_build_support/products/product.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,7 @@ def install_toolchain_path(self, host_target):
212212
if self.args.cross_compile_hosts:
213213
if self.is_darwin_host(host_target):
214214
install_destdir = self.host_install_destdir(host_target)
215-
else:
215+
elif self.args.cross_compile_append_host_target_to_destdir:
216216
install_destdir = os.path.join(install_destdir, self.args.host_target)
217217
return targets.toolchain_path(install_destdir,
218218
self.args.install_prefix)

0 commit comments

Comments
 (0)