Merge pull request #61289 from AnthonyLatsis/migrate-stdlib-to-gh-issues

Gardening: Migrate stdlib sources to GH issues

Author: AnthonyLatsis

stdlib/cmake/modules/AddSwiftStdlib.cmake

@@ -1916,10 +1916,11 @@ function(add_swift_target_library name)
       list(APPEND swiftlib_swift_compile_flags_all
            ${SWIFTLIB_SWIFT_COMPILE_FLAGS_LINUX})
     elseif(${sdk} STREQUAL WINDOWS)
-      # FIXME(SR2005) static and shared are not mutually exclusive; however
-      # since we do a single build of the sources, this doesn't work for
-      # building both simultaneously.  Effectively, only shared builds are
-      # supported on windows currently.
+      # FIXME: https://github.com/apple/swift/issues/44614
+      # static and shared are not mutually exclusive; however since we do a
+      # single build of the sources, this doesn't work for building both
+      # simultaneously.  Effectively, only shared builds are supported on
+      # windows currently.
       if(SWIFTLIB_SHARED)
         list(APPEND swiftlib_swift_compile_flags_all -D_WINDLL)
         if(SWIFTLIB_IS_STDLIB_CORE)

stdlib/public/SwiftShims/swift/shims/RefCount.h

@@ -1326,7 +1326,7 @@ class HeapObjectSideTableEntry {
   public:
   HeapObjectSideTableEntry(HeapObject *newObject)
     : object(newObject), 
-#if __arm__ || __powerpc__ // https://bugs.swift.org/browse/SR-5846
+#if __arm__ || __powerpc__ // https://github.com/apple/swift/issues/48416
    refCounts(SideTableRefCounts::Initialized)
 #else
    refCounts()

stdlib/public/core/ArrayShared.swift

@@ -127,7 +127,7 @@ extension Collection {
 }
 
 extension _ArrayBufferProtocol {
-  @inlinable // FIXME @useableFromInline https://bugs.swift.org/browse/SR-7588
+  @inlinable // FIXME: @useableFromInline (https://github.com/apple/swift/issues/50130).
   @inline(never)
   internal mutating func _arrayOutOfPlaceReplace<C: Collection>(
     _ bounds: Range<Int>,

stdlib/public/core/CTypes.swift

@@ -95,7 +95,7 @@ public typealias CLongDouble = Double
 #endif
 #elseif os(Android)
 // On Android, long double is Float128 for AAPCS64, which we don't have yet in
-// Swift (SR-9072); and Double for ARMv7.
+// Swift (https://github.com/apple/swift/issues/51573); and Double for ARMv7.
 #if arch(arm)
 public typealias CLongDouble = Double
 #endif

stdlib/public/core/CompilerProtocols.swift

@@ -210,7 +210,7 @@ extension RawRepresentable where RawValue: Hashable, Self: Hashable {
     // so code that used to work in 5.0 remains working whether or not the
     // original definition was inlined.
     //
-    // See https://bugs.swift.org/browse/SR-10734
+    // See https://github.com/apple/swift/issues/53126.
     var hasher = Hasher(_seed: seed)
     self.hash(into: &hasher)
     return hasher._finalize()

stdlib/public/core/Filter.swift

@@ -117,10 +117,11 @@ public typealias LazyFilterCollection<T: Collection> = LazyFilterSequence<T>
 extension LazyFilterCollection: Collection {
   public typealias SubSequence = LazyFilterCollection<Base.SubSequence>
 
+  // https://github.com/apple/swift/issues/46747
   // Any estimate of the number of elements that pass `_predicate` requires
   // iterating the collection and evaluating each element, which can be costly,
   // is unexpected, and usually doesn't pay for itself in saving time through
-  // preventing intermediate reallocations. (SR-4164)
+  // preventing intermediate reallocations.
   @inlinable // lazy-performance
   public var underestimatedCount: Int { return 0 }
 

stdlib/public/core/FloatingPointTypes.swift.gyb

@@ -952,7 +952,7 @@ extension ${Self}: _ExpressibleByBuiltinFloatLiteral {
 %   if bits == builtinFloatLiteralBits:
     self = ${Self}(value)
 %   elif bits < builtinFloatLiteralBits:
-    // FIXME: This can result in double rounding errors (SR-7124).
+    // FIXME: This can result in double rounding errors (https://github.com/apple/swift/issues/49672).
     self = ${Self}(Builtin.fptrunc_FPIEEE${builtinFloatLiteralBits}_FPIEEE${bits}(value))
 %   else:
     // FIXME: This is actually losing precision <rdar://problem/14073102>.

stdlib/public/core/HashTable.swift

@@ -107,8 +107,8 @@ extension _HashTable {
   ) -> Int {
     // We generate a new hash seed whenever a new hash table is allocated and
     // whenever an existing table is resized, so that we avoid certain copy
-    // operations becoming quadratic.  (For background details, see
-    // https://bugs.swift.org/browse/SR-3268)
+    // operations becoming quadratic. For background details, see
+    // https://github.com/apple/swift/issues/45856.
     //
     // Note that we do reuse the existing seed when making copy-on-write copies
     // so that we avoid breaking value semantics.

stdlib/public/core/Mirror.swift

@@ -482,8 +482,7 @@ public struct Mirror {
     displayStyle: DisplayStyle? = nil,
     ancestorRepresentation: AncestorRepresentation = .generated
   ) where C.Element == Child {
-    // Can't use Builtin.unreachable() due to
-    // https://bugs.swift.org/browse/SR-15300
+    // FIXME: Can't use Builtin.unreachable() due to https://github.com/apple/swift/issues/57622.
     self.init(reflecting: subject)
   }
   public init<Subject, C: Collection>(
@@ -492,8 +491,7 @@ public struct Mirror {
     displayStyle: DisplayStyle? = nil,
     ancestorRepresentation: AncestorRepresentation = .generated
   ) {
-    // Can't use Builtin.unreachable() due to
-    // https://bugs.swift.org/browse/SR-15300
+    // FIXME: Can't use Builtin.unreachable() due to https://github.com/apple/swift/issues/57622.
     self.init(reflecting: subject)
   }
   public init<Subject>(
@@ -502,8 +500,7 @@ public struct Mirror {
     displayStyle: DisplayStyle? = nil,
     ancestorRepresentation: AncestorRepresentation = .generated
   ) {
-    // Can't use Builtin.unreachable() due to
-    // https://bugs.swift.org/browse/SR-15300
+    // FIXME: Can't use Builtin.unreachable() due to https://github.com/apple/swift/issues/57622.
     self.init(reflecting: subject)
   }
   public let subjectType: Any.Type

stdlib/public/core/SliceBuffer.swift

@@ -211,7 +211,7 @@ internal struct _SliceBuffer<Element>
     //
     //   return _hasNativeBuffer && isUniquelyReferenced()
     //
-    // SR-6437
+    // https://github.com/apple/swift/issues/48987
     if !_hasNativeBuffer {
       return false
     }