[CodeCompletion] Don’t crash if constructors in member lookup have an error type

Author: ahoppen

lib/Sema/CSSimplify.cpp

@@ -9171,12 +9171,17 @@ performMemberLookup(ConstraintKind constraintKind, DeclNameRef memberName,
 
       // Only try and favor monomorphic unary initializers.
       if (!ctor->isGenericContext()) {
-        auto args = ctor->getMethodInterfaceType()
-                        ->castTo<FunctionType>()->getParams();
-        if (args.size() == 1 && !args[0].hasLabel() &&
-            args[0].getPlainType()->isEqual(favoredType)) {
-          if (!isDeclUnavailable(decl, memberLocator))
-            result.FavoredChoice = result.ViableCandidates.size();
+        if (!ctor->getMethodInterfaceType()->hasError()) {
+          // The constructor might have an error type because we don't skip
+          // invalid decls for code completion
+          auto args = ctor->getMethodInterfaceType()
+                          ->castTo<FunctionType>()
+                          ->getParams();
+          if (args.size() == 1 && !args[0].hasLabel() &&
+              args[0].getPlainType()->isEqual(favoredType)) {
+            if (!isDeclUnavailable(decl, memberLocator))
+              result.FavoredChoice = result.ViableCandidates.size();
+          }
         }
       }
     }

validation-test/IDE/crashers_2_fixed/0037-constructor-with-error-type.swift

@@ -0,0 +1,12 @@
+// Make sure we don't crash
+// RUN: %target-swift-ide-test -code-completion -source-filename %s -code-completion-token COMPLETE
+
+public struct AnyError {
+
+  public init(_ error: Swift.
+
+extension AnyError {
+  public static func error(from error: Error) -> AnyError {
+    return AnyError(error)#^COMPLETE^#
+  }
+}