Merge pull request #17008 from davidungar/rdar-40712614-removing-batch-mode-remark

[Batch mode] [rdar://40712614 ] Remove “using batch mode” remark.

Author: David Ungar

include/swift/AST/DiagnosticsDriver.def

@@ -159,8 +159,6 @@ WARNING(warn_emit_public_type_metadata_accessors_deprecated, none,
         "the option '-emit-public-type-metadata-accessors' is no longer "
         "needed and is deprecated; consider removing it", ())
 
-REMARK(remark_using_batch_mode,none, "using batch mode", ())
-
 ERROR(cannot_find_migration_script, none,
       "missing migration script from path '%0'", (StringRef))
 

lib/Driver/Driver.cpp

@@ -720,11 +720,6 @@ Driver::buildCompilation(const ToolChain &TC,
   const bool ContinueBuildingAfterErrors =
       BatchMode || ArgList->hasArg(options::OPT_continue_building_after_errors);
 
-  // Issue a remark to facilitate recognizing the use of batch mode in the build
-  // log.
-  if (BatchMode)
-    Diags.diagnose(SourceLoc(), diag::remark_using_batch_mode);
-
   if (Diags.hadAnyError())
     return nullptr;
 

test/Driver/batch_mode_print_jobs.swift

@@ -12,8 +12,8 @@
 //
 // RUN: %swiftc_driver -enable-batch-mode -c -emit-module -module-name main -j 2 %t/file-01.swift %t/file-02.swift %t/file-03.swift %t/main.swift  -driver-print-jobs 2>%t/stderr1 | %FileCheck %s -check-prefix=CHECK-COMBINED
 // RUN: %swiftc_driver -enable-batch-mode -c -emit-module -module-name main -j 2 %t/file-01.swift %t/file-02.swift %t/file-03.swift %t/main.swift  -###  2>%t/stderr2 | %FileCheck %s  -check-prefix=CHECK-COMBINED
-// RUN: %FileCheck %s -check-prefix=NEGATIVE-CHECK-COMBINED <%t/stderr1
-// RUN: %FileCheck %s -check-prefix=NEGATIVE-CHECK-COMBINED <%t/stderr2
+// RUN: %FileCheck %s -allow-empty -check-prefix=NEGATIVE-CHECK-COMBINED <%t/stderr1
+// RUN: %FileCheck %s -allow-empty -check-prefix=NEGATIVE-CHECK-COMBINED <%t/stderr2
 //
 // CHECK-COMBINED: -primary-file {{.*}}/file-01.swift -primary-file {{.*}}/file-02.swift {{.*}}/file-03.swift {{.*}}/main.swift
 // NEGATIVE-CHECK-COMBINED-NOT: -primary-file {{.*}}/file-01.swift -primary-file {{.*}}/file-02.swift {{.*}}/file-03.swift {{.*}}/main.swift

test/Driver/batch_mode_remark.swift

@@ -1,12 +1,8 @@
-// Ensure that driver issues a remark iff in batch mode.
+// Ensure that driver does not issue a remark iff in batch mode. (The remark has been removed.)
 //
 // RUN: %swiftc_driver -whole-module-optimization -enable-batch-mode   %S/../Inputs/empty.swift -### 2>&1 >/dev/null | %FileCheck %s
 // RUN: %swiftc_driver                                                 %S/../Inputs/empty.swift -### 2>&1 >/dev/null | %FileCheck -allow-empty %s
+// RUN: %swiftc_driver -enable-batch-mode                              %S/../Inputs/empty.swift -### 2>&1 >/dev/null | %FileCheck -allow-empty %s
 // RUN: %swiftc_driver -enable-batch-mode        -disable-batch-mode   %S/../Inputs/empty.swift -### 2>&1 >/dev/null | %FileCheck -allow-empty %s
 //
 // CHECK-NOT: remark: using batch mode
-//
-//
-// RUN: %swiftc_driver -enable-batch-mode  %S/../Inputs/empty.swift -### 2>&1 | %FileCheck %s -check-prefix USING-BATCH-MODE
-//
-// USING-BATCH-MODE: remark: using batch mode