[stdlib] Delete transparent ~= overload; mark the regular one always-inlined instead

The new overload messes up diagnostics too much.

Author: lorentey

stdlib/public/core/Range.swift

@@ -94,39 +94,12 @@ extension RangeExpression {
   ///   - pattern: A range.
   ///   - bound: A value to match against `pattern`.
   @inlinable
+  @inline(__always)
   public static func ~= (pattern: Self, value: Bound) -> Bool {
     return pattern.contains(value)
   }
 }
 
-extension Range {
-  /// Returns a Boolean value indicating whether a value is included in a
-  /// range.
-  ///
-  /// You can use the pattern-matching operator (`~=`) to test whether a value
-  /// is included in a range. The pattern-matching operator is used
-  /// internally in `case` statements for pattern matching. The following
-  /// example uses the `~=` operator to test whether an integer is included in
-  /// a range of single-digit numbers:
-  ///
-  ///     let chosenNumber = 3
-  ///     if 0..<10 ~= chosenNumber {
-  ///         print("\(chosenNumber) is a single digit.")
-  ///     }
-  ///     // Prints "3 is a single digit."
-  ///
-  /// - Parameters:
-  ///   - pattern: A range.
-  ///   - bound: A value to match against `pattern`.
-  @_transparent
-  public static func ~= (pattern: Self, value: Bound) -> Bool {
-    // Note: `Range.~=` is used particularly frequently to implement bounds
-    // checks. This more specific variant of the generic `=~` is intended to
-    // help improve unoptimized performance of these cases.
-    pattern.contains(value)
-  }
-}
-
 /// A half-open interval from a lower bound up to, but not including, an upper
 /// bound.
 ///

test/stdlib/RangeContainsInlining.swift

@@ -1,16 +1,16 @@
 // RUN: %target-swift-emit-ir -primary-file %s 2>&1 | %FileCheck %s
-// RUN: %target-swift-emit-ir -primary-file %s -O 2>&1 | %FileCheck %s
-// RUN: %target-swift-emit-ir -primary-file %s -Osize 2>&1 | %FileCheck %s
+// RUN: %target-swift-emit-ir -primary-file %s -O 2>&1 | %FileCheck --check-prefixes CHECK,CHECK-OPTIMIZED %s
+// RUN: %target-swift-emit-ir -primary-file %s -Osize 2>&1 | %FileCheck --check-prefixes CHECK,CHECK-OPTIMIZED %s
 
-// We expect calls to `Range.contains`, `ClosedRange.contains` and `~=` over a
+// We expect calls to `Range.contains`, `ClosedRange.contains` over a
 // `Range` instance to result in direct bound comparisons in all compilation
 // modes, including unoptimized builds. (These are often used to implement
 // bounds checking.)
 //
 // The sample functions below use bounds of different integer types to avoid
 // them tail-calling each other.
 
-// CHECK-LABEL: define swiftcc i1 @"$s21RangeContainsInlining08halfOpenB0ySbSnys4Int8VG_ADtF"
+// CHECK-LABEL: define {{.*}} i1 @"$s21RangeContainsInlining08halfOpenB0ySbSnys4Int8VG_ADtF"
 // CHECK-NOT: call swiftcc
 // CHECK: icmp
 // CHECK-NOT: call swiftcc
@@ -19,7 +19,7 @@ public func halfOpenContains(_ r: Range<Int8>, _ i: Int8) -> Bool {
   r.contains(i)
 }
 
-// CHECK-LABEL: define swiftcc i1 @"$s21RangeContainsInlining06closedB0ySbSNys5Int16VG_ADtF"
+// CHECK-LABEL: define  {{.*}} i1 @"$s21RangeContainsInlining06closedB0ySbSNys5Int16VG_ADtF"
 // CHECK-NOT: call swiftcc
 // CHECK: icmp
 // CHECK-NOT: call swiftcc
@@ -28,11 +28,14 @@ public func closedContains(_ r: ClosedRange<Int16>, _ i: Int16) -> Bool {
   r.contains(i)
 }
 
-// CHECK-LABEL: define swiftcc i1 @"$s21RangeContainsInlining20halfOpenPatternMatchySbSnys5Int32VG_ADtF"
-// CHECK-NOT: call swiftcc
-// CHECK: icmp
-// CHECK-NOT: call swiftcc
-// CHECK-LABEL: {{^}}}
+// `Range.~=` is only marked `@inline(__always)`; unfortunately it doesn't get
+// inlined in deug builds.
+
+// CHECK-OPTIMIZED-LABEL: define {{.*}} i1 @"$s21RangeContainsInlining20halfOpenPatternMatchySbSnys5Int32VG_ADtF"
+// CHECK-OPTIMIZED-NOT: call swiftcc
+// CHECK-OPTIMIZED: icmp
+// CHECK-OPTIMIZED-NOT: call swiftcc
+// CHECK-OPTIMIZED-LABEL: {{^}}}
 public func halfOpenPatternMatch(_ r: Range<Int32>, _ i: Int32) -> Bool {
   r ~= i
 }