Merge pull request #73695 from hborla/opaque-type-conformance-availability

[Availability] Diagnose unavailable conformances in `UnderlyingToOpaqueExpr`.

Author: hborla

lib/Sema/TypeCheckAvailability.cpp

@@ -2910,7 +2910,7 @@ bool swift::diagnoseExplicitUnavailability(SourceLoc loc,
   diags.diagnose(loc, diag::conformance_availability_unavailable,
                  type, proto,
                  platform.empty(), platform, EncodedMessage.Message)
-      .limitBehavior(behavior)
+      .limitBehaviorUntilSwiftVersion(behavior, 6)
       .warnUntilSwiftVersionIf(warnIfConformanceUnavailablePreSwift6, 6);
 
   switch (attr->getVersionAvailability(ctx)) {
@@ -3468,6 +3468,11 @@ class ExprAvailabilityWalker : public ASTWalker {
       }
     }
 
+    if (auto UTO = dyn_cast<UnderlyingToOpaqueExpr>(E)) {
+      diagnoseSubstitutionMapAvailability(
+          UTO->getLoc(), UTO->substitutions, Where);
+    }
+
     if (auto ME = dyn_cast<MacroExpansionExpr>(E)) {
       diagnoseDeclRefAvailability(
           ME->getMacroRef(), ME->getMacroNameLoc().getSourceRange());

test/Concurrency/sendable_checking.swift

@@ -427,3 +427,15 @@ extension ImplicitSendableViaMain {
 struct TestImplicitSendable: Sendable {
   var x: ImplicitSendableViaMain
 }
+
+struct UnavailableSendable {}
+
+@available(*, unavailable)
+extension UnavailableSendable: Sendable {}
+// expected-note@-1 {{conformance of 'UnavailableSendable' to 'Sendable' has been explicitly marked unavailable here}}
+
+@available(SwiftStdlib 5.1, *)
+func checkOpaqueType() -> some Sendable {
+  UnavailableSendable()
+  // expected-warning@-1 {{conformance of 'UnavailableSendable' to 'Sendable' is unavailable; this is an error in the Swift 6 language mode}}
+}

test/Concurrency/sendable_checking_swift6.swift

@@ -0,0 +1,16 @@
+// RUN: %target-swift-frontend -emit-sil -swift-version 6 %s -o /dev/null -verify
+
+// REQUIRES: concurrency
+
+
+struct UnavailableSendable {}
+
+@available(*, unavailable)
+extension UnavailableSendable: Sendable {}
+// expected-note@-1 {{conformance of 'UnavailableSendable' to 'Sendable' has been explicitly marked unavailable here}}
+
+@available(SwiftStdlib 5.1, *)
+func checkOpaqueType() -> some Sendable {
+  UnavailableSendable()
+  // expected-error@-1 {{conformance of 'UnavailableSendable' to 'Sendable' is unavailable}}
+}

test/Sema/availability.swift

@@ -169,3 +169,14 @@ struct DeferBody {
   }
 }
 
+struct NotP {}
+
+protocol P {}
+
+@available(*, unavailable)
+extension NotP: P {} // expected-note {{conformance of 'NotP' to 'P' has been explicitly marked unavailable here}}
+
+@available(SwiftStdlib 5.1, *)
+func requireP() -> some P {
+  NotP() // expected-error {{conformance of 'NotP' to 'P' is unavailable}}
+}