Merge pull request #74446 from hborla/dont-enable-full-typed-throws

hborla · web-flow · commit 4a98a5356433 · 2024-06-15T09:43:03.000-07:00
[Features] `FullTypedThrows` should only be enable-able in asserts builds.
diff --git a/include/swift/Basic/Features.def b/include/swift/Basic/Features.def
@@ -227,7 +227,7 @@ EXPERIMENTAL_FEATURE(FlowSensitiveConcurrencyCaptures, false)
 EXPERIMENTAL_FEATURE(CodeItemMacros, false)
 EXPERIMENTAL_FEATURE(PreambleMacros, false)
 EXPERIMENTAL_FEATURE(TupleConformances, false)
-EXPERIMENTAL_FEATURE(FullTypedThrows, true)
+EXPERIMENTAL_FEATURE(FullTypedThrows, false)
 
 // Whether to enable @_used and @_section attributes
 EXPERIMENTAL_FEATURE(SymbolLinkageMarkers, true)
diff --git a/test/SILGen/typed_throws_generic.swift b/test/SILGen/typed_throws_generic.swift
@@ -1,5 +1,7 @@
 // RUN: %target-swift-emit-silgen %s -enable-experimental-feature FullTypedThrows | %FileCheck %s
 
+// REQUIRES: asserts
+
 public func genericThrow<E>(e: E) throws(E) {
   throw e
 }
diff --git a/test/stmt/typed_throws.swift b/test/stmt/typed_throws.swift
@@ -1,5 +1,7 @@
 // RUN: %target-typecheck-verify-swift -enable-experimental-feature FullTypedThrows
 
+// REQUIRES: asserts
+
 enum MyError: Error {
 case failed
 case epicFailed

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,7 @@`
`1`	`1`	`// RUN: %target-swift-emit-silgen %s -enable-experimental-feature FullTypedThrows \| %FileCheck %s`
`2`	`2`
	`3`	`+// REQUIRES: asserts`
	`4`	`+`
`3`	`5`	`public func genericThrow<E>(e: E) throws(E) {`
`4`	`6`	`throw e`
`5`	`7`	`}`