Merge pull request #3262 from rjmccall/fix-recordImportDecls-signature-resolution

Check for lazy signature resolution failure when deciding overloadabi…

Author: rjmccall

lib/AST/ModuleNameLookup.cpp

@@ -108,10 +108,13 @@ static ResolutionKind recordImportDecls(LazyResolver *typeResolver,
     std::copy_if(newDecls.begin(), newDecls.end(), std::back_inserter(results),
                  [&](ValueDecl *result) -> bool {
       if (!result->hasType()) {
-        if (typeResolver)
+        if (typeResolver) {
           typeResolver->resolveDeclSignature(result);
-        else
+          if (result->isInvalid())
+            return true;
+        } else {
           return true;
+        }
       }
       return isValidOverload(overloads, result);
     });

validation-test/compiler_crashers/28295-swift-namelookup-lookupvisibledeclsinmodule.swift renamed to validation-test/compiler_crashers_fixed/28295-swift-namelookup-lookupvisibledeclsinmodule.swift

@@ -5,6 +5,6 @@
 // See http://swift.org/LICENSE.txt for license information
 // See http://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
 
-// RUN: not --crash %target-swift-frontend %s -parse
+// RUN: not %target-swift-frontend %s -parse
 // REQUIRES: asserts
 struct a{var f={H:{}}}init