Merge pull request #80367 from xedin/rdar-137825558

[ConstraintSystem] Use `findSelectedOverloadFor` in `isArgumentGeneri…

Author: xedin

lib/Sema/ConstraintSystem.cpp

@@ -4984,14 +4984,12 @@ bool ConstraintSystem::isArgumentGenericFunction(Type argType, Expr *argExpr) {
 
   // Have we bound an overload for the argument already?
   if (argExpr) {
-    auto locator = getConstraintLocator(argExpr);
-    auto knownOverloadBinding = ResolvedOverloads.find(locator);
-    if (knownOverloadBinding != ResolvedOverloads.end()) {
+    if (auto selectedOverload = findSelectedOverloadFor(argExpr)) {
       // If the overload choice is a generic function, then we have a generic
       // function reference.
-      auto choice = knownOverloadBinding->second;
-      if (auto func = dyn_cast_or_null<AbstractFunctionDecl>(
-              choice.choice.getDeclOrNull())) {
+      auto choice = selectedOverload->choice;
+      if (auto func =
+              dyn_cast_or_null<AbstractFunctionDecl>(choice.getDeclOrNull())) {
         if (func->isGeneric())
           return true;
       }

validation-test/Sema/type_checker_crashers_fixed/rdar137825558.swift

@@ -0,0 +1,25 @@
+// RUN: %target-typecheck-verify-swift -swift-version 6
+
+// rdar://137825558 - crash due to attempted existential opening
+
+protocol FS {
+  func exists(_ str: String) -> Bool
+}
+
+class Obj {
+  var property: String = ""
+}
+
+func checkFunctionCall<T, Arg0>(
+  _ lhs: T, calling functionCall: (T, Arg0) throws -> Bool, _ argument0: Arg0
+) {
+}
+
+func checkFunctionCall<T, Arg0, R>(
+  _ lhs: T, calling functionCall: (T, Arg0) throws -> R?, _ argument0: Arg0
+) {
+}
+
+func test(fs: any FS, obj: Obj!) {
+  checkFunctionCall(fs, calling: { $0.exists($1) }, obj.property)
+}