Merge pull request #69125 from AnthonyLatsis/not-my-first-pull-request

[docs] FirstPullRequest: Update and improve sections on tidying up & code review

Author: AnthonyLatsis

docs/HowToGuides/FirstPullRequest.md

@@ -98,16 +98,26 @@ make changes, run tests and debug issues.
 
 ## Submitting a pull request
 
-### Tidying up
-
 Alright! You've implemented a change and would like to submit it.
-Double-check that you've tidied your Git history, such as squashing
-work-in-progress commits, and that your commit messages provide context.
-For example, if a commit fixes a bug, then include a "Fixes SR-NNNNN" with the
-bug number in the commit message.
 
-Next, [format your changes](/docs/HowToGuides/FAQ.md#how-do-i-format-my-changes)
-using `clang-format`.
+### Tidying up
+
+> **Note**  
+> If you intend to create a [draft pull request][draft-pr], you can tidy up
+> later *before* marking it as ready for review.
+
+1. [Tidy up your commit history](FAQ.md#how-do-i-clean-up-my-git-history):
+   * Squash work-in-progress commits.
+   * Break up your changes into as many self-sufficient, meaningful commits as
+     you can, rather than cramming everything into a single commit.
+     For example, a patch that renames a function (1) and modifies an algorithm
+     (2) can be split into two commits.
+     A self-sufficient commit must compile, pass all tests, and contain
+     any associated test changes.
+     This practice is key to efficient and rigorous code review processes,
+     as well as a neat, transparent, and actionable commit history.
+   * [Top off your commit messages](https://swift.org/contributing/#commit-messages).
+1. Tidy up and [format your code changes](FAQ.md#how-do-i-format-my-changes).
 
 ### Pushing and creating a pull request
 
@@ -120,21 +130,29 @@ show a helpful "Compare & Pull Request" button.
 
 ![Compare & Pull Request button in GitHub UI](/docs/GitHubCreatePRScreenshot.png)
 
+[draft-pr]: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/about-pull-requests#draft-pull-requests
 [create a pull request]: https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request#creating-the-pull-request
 
 ## Asking for code review
 
-If you had an active discussion with someone on how to implement your change,
-you can `@` mention them in the PR description and ask for code review.
-If you directly implemented the change without any guidance from anyone else,
-`@` mention someone from GitHub's suggested reviewers. If GitHub doesn't
-make any suggestions, ask the [Code Owner](https://github.com/apple/swift/blob/main/CODE_OWNERS.TXT) based on the
-component for your change. Please ask someone though! We don't want you to get
-stuck because you were not sure who to ask for code review.
-
-At the beginning, contributors are not able to run the continuous integration
-(CI) bot, which builds the project and runs tests. Please ask your code
-reviewer(s) to invoke the bot for you.
+Collaborators and code owners are automatically requested for review per the
+[CODEOWNERS](/.github/CODEOWNERS) file. If no one is automatically requested for
+review, @mention and ask a suggested person under **Reviewers** to review your
+changes. If no reviewer suggestions are shown either, please
+[message][contributor-experience] the Contributor Experience Workgroup on the
+Swift forums to sort out review requests for you.
+
+You are welcome to invite other people for review as well — say, someone you
+had an active discussion with on how to implement your change.
+Anyone with a GitHub account can review or comment on changes proposed to
+this repository!
+
+Contributors without
+[write access](https://swift.org/contributing/#commit-access) are not able to
+run the continuous integration (CI) bot, which builds the project and runs
+tests. Please ask a code reviewer with write access to invoke the bot for you.
+
+[contributor-experience]: https://forums.swift.org/g/contributor-experience-workgroup
 
 ## Responding to code review comments