Merge pull request #83986 from slavapestov/fix-rdar158774099

AST: Remove old hack that appears to be obsolete and revert a revert of another fix

Author: slavapestov

lib/AST/SubstitutionMap.cpp

@@ -283,20 +283,6 @@ SubstitutionMap::lookupConformance(CanType type, ProtocolDecl *proto) const {
 
   // For each remaining step, project an associated conformance.
   while (iter != path.end()) {
-    // FIXME: Remove this hack. It is unsound, because we may not have diagnosed
-    // anything but still end up with an ErrorType in the AST.
-    if (conformance.isConcrete()) {
-      auto concrete = conformance.getConcrete();
-      if (auto normal = dyn_cast<NormalProtocolConformance>(concrete->getRootConformance())) {
-        if (!normal->hasComputedAssociatedConformances()) {
-          if (proto->getASTContext().evaluator.hasActiveRequest(
-                ResolveTypeWitnessesRequest{normal})) {
-            return ProtocolConformanceRef::forInvalid();
-          }
-        }
-      }
-    }
-
     const auto step = *iter++;
     conformance = conformance.getAssociatedConformance(step.first, step.second);
   }

lib/AST/TypeSubstitution.cpp

@@ -358,7 +358,7 @@ class TypeSubstituter : public TypeTransform<TypeSubstituter> {
   std::optional<Type> transformLocalArchetypeType(LocalArchetypeType *local,
                                                   TypePosition pos);
 
-  // SubstitutionMap transformSubstitutionMap(SubstitutionMap subs);
+  SubstitutionMap transformSubstitutionMap(SubstitutionMap subs);
 
   CanType transformSILField(CanType fieldTy, TypePosition pos);
 };
@@ -474,13 +474,10 @@ Type TypeSubstituter::transformDependentMemberType(DependentMemberType *dependen
   return result;
 }
 
-// FIXME: This exposes a scalability issue; see test/SILGen/opaque_result_type_slow.swift.
-/*
 SubstitutionMap TypeSubstituter::transformSubstitutionMap(SubstitutionMap subs) {
   // FIXME: Take level into account? Move level down into IFS?
   return subs.subst(IFS);
 }
-*/
 
 CanType TypeSubstituter::transformSILField(CanType fieldTy, TypePosition pos) {
   // Type substitution does not walk into the SILBoxType's field types, because

validation-test/compiler_crashers_2/174f557922f5c3cc.swift renamed to validation-test/compiler_crashers_2_fixed/174f557922f5c3cc.swift

@@ -1,5 +1,5 @@
 // {"kind":"typecheck","original":"2fdf1565","signature":"(anonymous namespace)::TypeSubstituter::transformDependentMemberType(swift::DependentMemberType*, swift::TypePosition)","stackOverflow":true}
-// RUN: not --crash %target-swift-frontend -typecheck %s
+// RUN: not %target-swift-frontend -typecheck %s
 protocol a {
   typealias b = c
   associatedtype d: b