[Profiler] NFC: Remove unnecessary parameter

`SILProfiler::create` is only ever called when
emitting a definition, so this check is redundant.

Author: hamishknight

include/swift/SIL/SILFunction.h

@@ -562,8 +562,7 @@ class SILFunction
     Profiler = InheritedProfiler;
   }
 
-  void createProfiler(ASTNode Root, SILDeclRef forDecl,
-                      ForDefinition_t forDefinition);
+  void createProfiler(ASTNode Root, SILDeclRef Ref);
 
   void discardProfiler() { Profiler = nullptr; }
 

include/swift/SIL/SILProfiler.h

@@ -69,8 +69,7 @@ class SILProfiler : public SILAllocated<SILProfiler> {
         EmitCoverageMapping(EmitCoverageMapping) {}
 
 public:
-  static SILProfiler *create(SILModule &M, ForDefinition_t forDefinition,
-                             ASTNode N, SILDeclRef forDecl);
+  static SILProfiler *create(SILModule &M, ASTNode N, SILDeclRef Ref);
 
   /// Check if the function is set up for profiling.
   bool hasRegionCounters() const { return NumRegionCounters != 0; }

lib/SIL/IR/SILFunction.cpp

@@ -322,10 +322,9 @@ void SILFunction::deleteSnapshot(int ID) {
   } while ((f = f->snapshots) != nullptr);
 }
 
-void SILFunction::createProfiler(ASTNode Root, SILDeclRef forDecl,
-                                 ForDefinition_t forDefinition) {
+void SILFunction::createProfiler(ASTNode Root, SILDeclRef Ref) {
   assert(!Profiler && "Function already has a profiler");
-  Profiler = SILProfiler::create(Module, forDefinition, Root, forDecl);
+  Profiler = SILProfiler::create(Module, Root, Ref);
 }
 
 bool SILFunction::hasForeignBody() const {

lib/SIL/IR/SILProfiler.cpp

@@ -147,24 +147,19 @@ static bool canCreateProfilerForAST(ASTNode N, SILDeclRef forDecl) {
   return false;
 }
 
-SILProfiler *SILProfiler::create(SILModule &M, ForDefinition_t forDefinition,
-                                 ASTNode N, SILDeclRef forDecl) {
-  // Avoid generating profiling state for declarations.
-  if (!forDefinition)
-    return nullptr;
-
+SILProfiler *SILProfiler::create(SILModule &M, ASTNode N, SILDeclRef Ref) {
   const auto &Opts = M.getOptions();
   if (!doesASTRequireProfiling(M, N) && Opts.UseProfile.empty())
     return nullptr;
 
-  if (!canCreateProfilerForAST(N, forDecl)) {
+  if (!canCreateProfilerForAST(N, Ref)) {
     N.dump(llvm::errs());
     llvm_unreachable("Invalid AST node for profiling");
   }
 
   auto *Buf = M.allocate<SILProfiler>(1);
   auto *SP =
-      ::new (Buf) SILProfiler(M, N, forDecl, Opts.EmitProfileCoverageMapping);
+      ::new (Buf) SILProfiler(M, N, Ref, Opts.EmitProfileCoverageMapping);
   SP->assignRegionCounters();
   return SP;
 }

lib/SILGen/SILGen.cpp

@@ -667,12 +667,12 @@ static void setUpForProfiling(SILDeclRef constant, SILFunction *F,
     if (constant.hasDecl()) {
       if (auto *fd = constant.getFuncDecl()) {
         if (fd->hasBody()) {
-          F->createProfiler(fd, constant, forDefinition);
+          F->createProfiler(fd, constant);
           profiledNode = fd->getBody(/*canSynthesize=*/false);
         }
       }
     } else if (auto *ace = constant.getAbstractClosureExpr()) {
-      F->createProfiler(ace, constant, forDefinition);
+      F->createProfiler(ace, constant);
       profiledNode = ace;
     }
     // Set the function entry count for PGO.
@@ -914,7 +914,7 @@ void SILGenModule::emitFunctionDefinition(SILDeclRef constant, SILFunction *f) {
     } else {
       preEmitFunction(constant, f, decl);
       PrettyStackTraceSILFunction X("silgen emitConstructor", f);
-      f->createProfiler(decl, constant, ForDefinition);
+      f->createProfiler(decl, constant);
       SILGenFunction(*this, *f, decl).emitValueConstructor(decl);
       postEmitFunction(constant, f);
     }
@@ -927,7 +927,7 @@ void SILGenModule::emitFunctionDefinition(SILDeclRef constant, SILFunction *f) {
 
     preEmitFunction(constant, f, decl);
     PrettyStackTraceSILFunction X("silgen constructor initializer", f);
-    f->createProfiler(decl, constant, ForDefinition);
+    f->createProfiler(decl, constant);
     SILGenFunction(*this, *f, decl).emitClassConstructorInitializer(decl);
     postEmitFunction(constant, f);
     break;
@@ -993,7 +993,7 @@ void SILGenModule::emitFunctionDefinition(SILDeclRef constant, SILFunction *f) {
     auto loc = RegularLocation::getAutoGeneratedLocation(init);
     preEmitFunction(constant, f, loc);
     PrettyStackTraceSILFunction X("silgen emitStoredPropertyInitialization", f);
-    f->createProfiler(init, constant, ForDefinition);
+    f->createProfiler(init, constant);
     SILGenFunction SGF(*this, *f, initDC);
 
     // If this is a stored property initializer inside a type at global scope,
@@ -1020,8 +1020,7 @@ void SILGenModule::emitFunctionDefinition(SILDeclRef constant, SILFunction *f) {
         "silgen emitPropertyWrapperBackingInitializer", f);
     auto wrapperInfo = var->getPropertyWrapperInitializerInfo();
     assert(wrapperInfo.hasInitFromWrappedValue());
-    f->createProfiler(wrapperInfo.getInitFromWrappedValue(), constant,
-                      ForDefinition);
+    f->createProfiler(wrapperInfo.getInitFromWrappedValue(), constant);
     auto varDC = var->getInnermostDeclContext();
     SILGenFunction SGF(*this, *f, varDC);
     SGF.emitGeneratorFunction(constant, wrapperInfo.getInitFromWrappedValue());
@@ -1038,8 +1037,7 @@ void SILGenModule::emitFunctionDefinition(SILDeclRef constant, SILFunction *f) {
         "silgen emitPropertyWrapperInitFromProjectedValue", f);
     auto initInfo = var->getPropertyWrapperInitializerInfo();
     assert(initInfo.hasInitFromProjectedValue());
-    f->createProfiler(initInfo.getInitFromProjectedValue(), constant,
-                      ForDefinition);
+    f->createProfiler(initInfo.getInitFromProjectedValue(), constant);
     auto varDC = var->getInnermostDeclContext();
     SILGenFunction SGF(*this, *f, varDC);
     SGF.emitGeneratorFunction(constant, initInfo.getInitFromProjectedValue());
@@ -1079,7 +1077,7 @@ void SILGenModule::emitFunctionDefinition(SILDeclRef constant, SILFunction *f) {
     auto *dd = cast<DestructorDecl>(constant.getDecl());
     preEmitFunction(constant, f, dd);
     PrettyStackTraceSILFunction X("silgen emitDestroyingDestructor", f);
-    f->createProfiler(dd, constant, ForDefinition);
+    f->createProfiler(dd, constant);
     SILGenFunction(*this, *f, dd).emitDestroyingDestructor(dd);
     postEmitFunction(constant, f);
     return;
@@ -1092,7 +1090,7 @@ void SILGenModule::emitFunctionDefinition(SILDeclRef constant, SILFunction *f) {
     if (usesObjCAllocator(cd)) {
       preEmitFunction(constant, f, dd);
       PrettyStackTraceSILFunction X("silgen emitDestructor -dealloc", f);
-      f->createProfiler(dd, constant, ForDefinition);
+      f->createProfiler(dd, constant);
       SILGenFunction(*this, *f, dd).emitObjCDestructor(constant);
       postEmitFunction(constant, f);
       return;
@@ -1954,7 +1952,7 @@ void SILGenModule::visitTopLevelCodeDecl(TopLevelCodeDecl *td) {
   // A single SILFunction may be used to lower multiple top-level decls. When
   // this happens, fresh profile counters must be assigned to the new decl.
   TopLevelSGF->F.discardProfiler();
-  TopLevelSGF->F.createProfiler(td, SILDeclRef(), ForDefinition);
+  TopLevelSGF->F.createProfiler(td, SILDeclRef());
 
   TopLevelSGF->emitProfilerIncrement(td->getBody());