Merge pull request #82792 from xedin/rdar-154719565-workaround-with-disfavored

xedin · web-flow · commit 5195e899ee25 · 2025-07-04T09:32:10.000-07:00
[SwiftCompilerSources] Disfavor overload of `==` that takes `StringRef`
diff --git a/SwiftCompilerSources/Sources/Basic/Utils.swift b/SwiftCompilerSources/Sources/Basic/Utils.swift
@@ -110,6 +110,10 @@ public struct StringRef : CustomStringConvertible, NoReflectionChildren, Express
     }
   }
 
+  /// This overload is disfavored to make sure that it's only used for cases that don't involve literals, for that
+  /// `==(StringRef, StaticString) -> Bool` is preferred. Otherwise these overloads are
+  /// going to be ambiguous because both StringRef, StaticString conform to `ExpressibleByStringLiteral`.
+  @_disfavoredOverload
   public static func ==(lhs: StringRef, rhs: StringRef) -> Bool {
     let lhsBuffer = UnsafeBufferPointer<UInt8>(start: lhs._bridged.data, count: lhs.count)
     let rhsBuffer = UnsafeBufferPointer<UInt8>(start: rhs._bridged.data, count: rhs.count)

Original file line number	Diff line number	Diff line change
`@@ -110,6 +110,10 @@ public struct StringRef : CustomStringConvertible, NoReflectionChildren, Express`
`110`	`110`	`}`
`111`	`111`	`}`
`112`	`112`
	`113`	`+ /// This overload is disfavored to make sure that it's only used for cases that don't involve literals, for that`
	`114`	+ /// `==(StringRef, StaticString) -> Bool` is preferred. Otherwise these overloads are
	`115`	+ /// going to be ambiguous because both StringRef, StaticString conform to `ExpressibleByStringLiteral`.
	`116`	`+ @_disfavoredOverload`
`113`	`117`	`public static func ==(lhs: StringRef, rhs: StringRef) -> Bool {`
`114`	`118`	`let lhsBuffer = UnsafeBufferPointer<UInt8>(start: lhs._bridged.data, count: lhs.count)`
`115`	`119`	`let rhsBuffer = UnsafeBufferPointer<UInt8>(start: rhs._bridged.data, count: rhs.count)`