Merge pull request #35923 from apple/QuietMisdreavus/dont-crash-on-failed-loads

don't crash the symbol graph tool when a module fails to load

Author: QuietMisdreavus

test/SymbolGraph/Module/FailedLoad.swift

@@ -0,0 +1,15 @@
+// RUN: %empty-directory(%t)
+// RUN: %target-build-swift %S/Inputs/FailedLoad/A.swift -module-name A -emit-module -emit-module-path %t/
+// RUN: %target-build-swift %s -module-name FailedLoad -emit-module -I %t -emit-module-path %t/
+
+// RUN: rm %t/A.swiftmodule
+
+// RUN: not %target-swift-symbolgraph-extract -module-name FailedLoad -I %t -pretty-print -output-dir %t 2>&1 | %FileCheck %s
+
+// CHECK-NOT: Emitting symbol graph for module file
+
+import A
+
+public struct Outer {
+    public var Something: A.Inner
+}

test/SymbolGraph/Module/Inputs/FailedLoad/A.swift

@@ -0,0 +1,3 @@
+public struct Inner {
+    public var Field: String
+}

tools/driver/swift_symbolgraph_extract_main.cpp

@@ -238,6 +238,14 @@ int swift_symbolgraph_extract_main(ArrayRef<const char *> Args, const char *Argv
     }
     return EXIT_FAILURE;
   }
+  
+  if (M->failedToLoad()) {
+    llvm::errs() << "Error: Failed to load the module '" << options::ModuleName
+      << "'. Are you missing build dependencies or include/framework directories?\n"
+      << "See the previous error messages for details. Aborting.\n";
+    
+    return EXIT_FAILURE;
+  }
 
   const auto &MainFile = M->getMainFile(FileUnitKind::SerializedAST);
   llvm::errs() << "Emitting symbol graph for module file: " << MainFile.getModuleDefiningPath() << '\n';