Build swift-syntax as shared libraries instead of static libraries.

This allows the various binaries (swift-frontend, SourceKit, etc.) to
share the same code, as well as allowing plugins to link against these
shared libraries.

Author: DougGregor

lib/ASTGen/CMakeLists.txt

@@ -51,11 +51,8 @@ if (SWIFT_SWIFT_PARSER)
     cmake_parse_arguments(ARGS "" "" "PUBLIC" ${ARGN})
 
     foreach(DEPENDENCY ${ARGS_PUBLIC})
-      # This is a hack to workaround a cmake bug that results in multiple ninja targets producing
-      # the same file in a downstream SourceKit target. This should use `PUBLIC`, the dependency
-      # directly (rather than `TARGET_OBJECTS`), and no `add_dependencies`.
       target_link_libraries(${TARGET} PRIVATE
-       $<TARGET_OBJECTS:${DEPENDENCY}>
+        ${DEPENDENCY}
       )
       add_dependencies(${TARGET} ${DEPENDENCY})
 
@@ -69,23 +66,54 @@ if (SWIFT_SWIFT_PARSER)
     endforeach()
   endfunction()
 
+  set(SWIFT_SYNTAX_MODULES
+    SwiftBasicFormat
+    SwiftParser
+    SwiftParserDiagnostics
+    SwiftDiagnostics
+    SwiftSyntax
+    SwiftOperators
+    SwiftSyntaxBuilder
+    _SwiftSyntaxMacros
+    SwiftCompilerSupport
+  )
+
+  # Compute the list of SwiftSyntax targets
+  list(TRANSFORM SWIFT_SYNTAX_MODULES PREPEND "SwiftSyntax::"
+       OUTPUT_VARIABLE SWIFT_SYNTAX_TARGETS)
+
   # TODO: Change to target_link_libraries when cmake is fixed
   force_target_link_libraries(swiftASTGen PUBLIC
-    SwiftSyntax::SwiftBasicFormat
-    SwiftSyntax::SwiftParser
-    SwiftSyntax::SwiftParserDiagnostics
-    SwiftSyntax::SwiftDiagnostics
-    SwiftSyntax::SwiftSyntax
-    SwiftSyntax::SwiftOperators
-    SwiftSyntax::SwiftSyntaxBuilder
-    SwiftSyntax::_SwiftSyntaxMacros
-    SwiftSyntax::SwiftCompilerSupport
+    ${SWIFT_SYNTAX_TARGETS}
   )
   target_link_libraries(swiftASTGen PUBLIC
     swiftAST
     swift_CompilerPluginSupport
   )
 
+  set(SWIFT_SYNTAX_LIBRARIES_SOURCE_DIR
+      "${SWIFT_PATH_TO_EARLYSWIFTSYNTAX_BUILD_DIR}/lib/swift/host")
+  set(SWIFT_SYNTAX_LIBRARIES_DEST_DIR
+      "${CMAKE_LIBRARY_OUTPUT_DIRECTORY}/swift/host")
+
+  # Determine the SwiftSyntax shared library files that were built as
+  # part of earlyswiftsyntax.
+  list(TRANSFORM SWIFT_SYNTAX_MODULES PREPEND ${CMAKE_SHARED_LIBRARY_PREFIX}
+       OUTPUT_VARIABLE SWIFT_SYNTAX_SHARED_LIBRARIES)
+  list(TRANSFORM SWIFT_SYNTAX_SHARED_LIBRARIES APPEND
+       ${CMAKE_SHARED_LIBRARY_SUFFIX}
+       OUTPUT_VARIABLE SWIFT_SYNTAX_SHARED_LIBRARIES)
+
+  # Copy over all of the shared libraries from earlyswiftsyntax so they can
+  # be found via RPATH.
+  foreach (sharedlib ${SWIFT_SYNTAX_SHARED_LIBRARIES})
+    add_custom_command(
+      TARGET swiftASTGen PRE_BUILD
+      COMMAND ${CMAKE_COMMAND} -E copy_if_different ${SWIFT_SYNTAX_LIBRARIES_SOURCE_DIR}/${sharedlib} ${SWIFT_SYNTAX_LIBRARIES_DEST_DIR}/${sharedlib}
+      COMMENT "Copying ${sharedlib}"
+    )
+  endforeach()
+
   target_include_directories(swiftASTGen PUBLIC
     "${SWIFT_PATH_TO_EARLYSWIFTSYNTAX_BUILD_DIR}/lib/swift/host")
 

lib/Parse/CMakeLists.txt

@@ -38,15 +38,15 @@ if (SWIFT_SWIFT_PARSER)
   #   )
   target_link_libraries(swiftParse
     PRIVATE
-    $<TARGET_OBJECTS:SwiftSyntax::SwiftBasicFormat>
-    $<TARGET_OBJECTS:SwiftSyntax::SwiftParser>
-    $<TARGET_OBJECTS:SwiftSyntax::SwiftParserDiagnostics>
-    $<TARGET_OBJECTS:SwiftSyntax::SwiftDiagnostics>
-    $<TARGET_OBJECTS:SwiftSyntax::SwiftSyntax>
-    $<TARGET_OBJECTS:SwiftSyntax::SwiftOperators>
-    $<TARGET_OBJECTS:SwiftSyntax::SwiftSyntaxBuilder>
-    $<TARGET_OBJECTS:SwiftSyntax::_SwiftSyntaxMacros>
-    $<TARGET_OBJECTS:SwiftSyntax::SwiftCompilerSupport>
+    SwiftSyntax::SwiftBasicFormat
+    SwiftSyntax::SwiftParser
+    SwiftSyntax::SwiftParserDiagnostics
+    SwiftSyntax::SwiftDiagnostics
+    SwiftSyntax::SwiftSyntax
+    SwiftSyntax::SwiftOperators
+    SwiftSyntax::SwiftSyntaxBuilder
+    SwiftSyntax::_SwiftSyntaxMacros
+    SwiftSyntax::SwiftCompilerSupport
     $<TARGET_OBJECTS:swiftASTGen>
   )
 

utils/swift_build_support/swift_build_support/products/earlyswiftsyntax.py

@@ -49,7 +49,7 @@ def get_dependencies(cls):
     def build(self, host_target):
         self.cmake_options.define('CMAKE_BUILD_TYPE:STRING',
                                   self.args.swift_build_variant)
-        self.cmake_options.define('BUILD_SHARED_LIBS:STRING', 'NO')
+        self.cmake_options.define('BUILD_SHARED_LIBS:STRING', 'YES')
 
         (platform, arch) = host_target.split('-')