Skip to content

Commit 561e93c

Browse files
authored
Merge pull request #74026 from artemcm/ForgottenXccForModMapFlags
[Dependency Scanning] Add forgotten '-Xcc' qualifier to modulemap dependency flags
2 parents 0d4ff45 + 60af9b8 commit 561e93c

File tree

2 files changed

+14
-2
lines changed

2 files changed

+14
-2
lines changed

lib/DependencyScan/ScanDependencies.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -271,7 +271,8 @@ static llvm::Error resolveExplicitModuleInputs(
271271
auto optionalBridgingHeaderDepModuleInfo = cache.findKnownDependency(
272272
{bridgingHeaderDepName, ModuleDependencyKind::Clang});
273273
const auto bridgingHeaderDepModuleDetails =
274-
optionalBridgingHeaderDepModuleInfo.getAsClangModule();
274+
optionalBridgingHeaderDepModuleInfo.getAsClangModule();
275+
commandLine.push_back("-Xcc");
275276
commandLine.push_back(
276277
"-fmodule-map-file=" +
277278
remapPath(bridgingHeaderDepModuleDetails->moduleMapFile));

test/ScanDependencies/bridging_header_dep_module_map.swift

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,18 @@
4949
// CHECK-DAG: "clang": "Dart"
5050
// CHECK: ],
5151
// CHECK: "commandLine": [
52-
// CHECK: "-fmodule-map-file={{.*}}{{/|\\}}CHeaders{{/|\\}}module.modulemap"
52+
// CHECK: "-Xcc"
53+
// CHECK-NEXT: "-fno-implicit-modules"
54+
// CHECK: "-Xcc"
55+
// CHECK-NEXT: "-fno-implicit-module-maps"
56+
// CHECK-DAG: "-Xcc",
57+
// CHECK-NEXT: "-fmodule-file=Dart={{.*}}"
58+
// CHECK-DAG: "-Xcc"
59+
// CHECK-NEXT: "-fmodule-map-file={{.*}}{{/|\\}}CHeaders{{/|\\}}module.modulemap"
60+
// CHECK-DAG: "-Xcc",
61+
// CHECK-NEXT: "-fmodule-file=SwiftShims={{.*}}"
62+
// CHECK-DAG: "-Xcc",
63+
// CHECK-NEXT: "-fmodule-file=X={{.*}}"
5364
// CHECK-NOT: "-fmodule-map-file={{.*}}{{/|\\}}TestCHeaders{{/|\\}}module.modulemap"
5465
// CHECK: ]
5566

0 commit comments

Comments
 (0)