Merge pull request #41682 from tshortli/fix-warnings

NFC: Fix a number of warnings emitted when building swift-frontend

Author: tshortli

lib/APIDigester/ModuleAnalyzerNodes.cpp

@@ -2244,7 +2244,6 @@ struct ConstExprInfo {
 
 class ConstExtractor: public ASTWalker {
   SDKContext &SCtx;
-  ASTContext &Ctx;
   SourceManager &SM;
   std::vector<ConstExprInfo> allConsts;
 
@@ -2328,7 +2327,7 @@ class ConstExtractor: public ASTWalker {
     return { true, E };
   }
 public:
-  ConstExtractor(SDKContext &SCtx, ASTContext &Ctx): SCtx(SCtx), Ctx(Ctx),
+  ConstExtractor(SDKContext &SCtx, ASTContext &Ctx): SCtx(SCtx),
     SM(Ctx.SourceMgr) {}
   void extract(ModuleDecl *MD) { MD->walk(*this); }
   std::vector<ConstExprInfo> &getAllConstValues() { return allConsts; }

lib/AST/GenericSignatureBuilder.cpp

@@ -3330,7 +3330,6 @@ Type GenericSignatureBuilder::getCanonicalTypeParameter(Type type) {
   Type currentType = genericParamType;
   SmallVector<AssociatedTypeDecl *, 4> path(initialPath.getPath().begin(),
                                             initialPath.getPath().end());
-  bool simplified = false;
   do {
     CanType currentAnchor = currentType->getCanonicalType();
     if (auto rootNode = Impl->getRewriteTreeRootIfPresent(currentAnchor)) {
@@ -3366,7 +3365,6 @@ Type GenericSignatureBuilder::getCanonicalTypeParameter(Type type) {
         }
 
         // Move back to the beginning; we may have opened up other rewrites.
-        simplified = true;
         startIndex = 0;
         currentType = genericParamType;
         continue;

lib/AST/NameLookup.cpp

@@ -2174,7 +2174,6 @@ directReferencesForIdentTypeRepr(Evaluator &evaluator,
                                  DeclContext *dc) {
   DirectlyReferencedTypeDecls current;
 
-  bool firstComponent = true;
   for (const auto &component : ident->getComponentRange()) {
     // If we already set a declaration, use it.
     if (auto typeDecl = component->getBoundDecl()) {
@@ -2194,7 +2193,6 @@ directReferencesForIdentTypeRepr(Evaluator &evaluator,
       if (current.empty())
         return current;
 
-      firstComponent = false;
       continue;
     }
 

lib/ClangImporter/ClangImporter.cpp

@@ -2259,8 +2259,9 @@ ClangImporter::Implementation::Implementation(
       IsReadingBridgingPCH(false),
       CurrentVersion(ImportNameVersion::fromOptions(ctx.LangOpts)),
       Walker(DiagnosticWalker(*this)),
+      BuffersForDiagnostics(ctx.SourceMgr),
       BridgingHeaderLookupTable(new SwiftLookupTable(nullptr)),
-      BuffersForDiagnostics(ctx.SourceMgr), platformAvailability(ctx.LangOpts),
+      platformAvailability(ctx.LangOpts),
       nameImporter(),
       DisableSourceImport(ctx.ClangImporterOpts.DisableSourceImport),
       DWARFImporter(dwarfImporterDelegate) {}
@@ -4587,12 +4588,6 @@ synthesizeBaseClassFieldGetterBody(AbstractFunctionDecl *afd, void *context) {
   casted->setType(baseStruct->getSelfInterfaceType());
   casted->setThrows(false);
 
-  // If the base class var has a clang decl, that means it's an access into a
-  // stored field. Otherwise, we're looking into another base class, so it's a
-  // another synthesized accessor.
-  AccessSemantics accessKind = baseClassVar->getClangDecl()
-                                   ? AccessSemantics::DirectToStorage
-                                   : AccessSemantics::DirectToImplementation;
   Expr *baseMember = nullptr;
   if (auto subscript = dyn_cast<SubscriptDecl>(baseClassVar)) {
     auto paramDecl = getterDecl->getParameters()->get(0);

lib/ClangImporter/ImportDecl.cpp

@@ -4456,8 +4456,6 @@ namespace {
       auto setterDecl = cast<AccessorDecl>(afd);
       auto setterImpl = static_cast<FuncDecl *>(context);
 
-      ASTContext &ctx = setterDecl->getASTContext();
-
       Expr *selfExpr = createSelfExpr(setterDecl);
       DeclRefExpr *valueParamRefExpr = createParamRefExpr(setterDecl, 0);
 

lib/IRGen/GenStruct.cpp

@@ -429,8 +429,6 @@ namespace {
 
     void addToAggLowering(IRGenModule &IGM, SwiftAggLowering &lowering,
                           Size offset) const override {
-      auto &layout = ClangDecl->getASTContext().getASTRecordLayout(ClangDecl);
-
       forEachNonEmptyBase([&](clang::QualType type, clang::CharUnits offset,
                               clang::CharUnits) {
         lowering.addTypedData(type, offset);

lib/IRGen/Linking.cpp

@@ -88,8 +88,8 @@ UniversalLinkageInfo::UniversalLinkageInfo(const llvm::Triple &triple,
                                            bool forcePublicDecls,
                                            bool isStaticLibrary)
     : IsELFObject(triple.isOSBinFormatELF()),
-      UseDLLStorage(useDllStorage(triple)), HasMultipleIGMs(hasMultipleIGMs),
-      Internalize(isStaticLibrary), ForcePublicDecls(forcePublicDecls) {}
+      UseDLLStorage(useDllStorage(triple)), Internalize(isStaticLibrary),
+      HasMultipleIGMs(hasMultipleIGMs), ForcePublicDecls(forcePublicDecls) {}
 
 /// Mangle this entity into the given buffer.
 void LinkEntity::mangle(SmallVectorImpl<char> &buffer) const {

lib/Sema/TypeCheckProtocol.cpp

@@ -2924,7 +2924,6 @@ bool ConformanceChecker::checkActorIsolation(
   // Ensure that the witness is not actor-isolated in a manner that makes it
   // unsuitable as a witness.
   bool isCrossActor = false;
-  bool witnessIsUnsafe = false;
   DiagnosticBehavior behavior = SendableCheckContext(
       Conformance->getDeclContext()).defaultDiagnosticBehavior();
   Type witnessGlobalActor;
@@ -3146,7 +3145,6 @@ bool ConformanceChecker::checkActorIsolation(
   }
 
   case ActorIsolationRestriction::GlobalActorUnsafe:
-    witnessIsUnsafe = true;
     LLVM_FALLTHROUGH;
 
   case ActorIsolationRestriction::GlobalActor: {
@@ -3167,13 +3165,11 @@ bool ConformanceChecker::checkActorIsolation(
 
   // Check whether the requirement requires some particular actor isolation.
   Type requirementGlobalActor;
-  bool requirementIsUnsafe = false;
   switch (auto requirementIsolation = getActorIsolation(requirement)) {
   case ActorIsolation::ActorInstance:
     llvm_unreachable("There are not actor protocols");
 
   case ActorIsolation::GlobalActorUnsafe:
-    requirementIsUnsafe = true;
     LLVM_FALLTHROUGH;
 
   case ActorIsolation::GlobalActor: {

stdlib/public/Concurrency/Actor.cpp

@@ -652,15 +652,15 @@ class alignas(sizeof(void *) * 2) ActiveActorStatus {
 #if SWIFT_CONCURRENCY_ENABLE_PRIORITY_ESCALATION && SWIFT_POINTER_IS_4_BYTES
   uint32_t Flags;
   dispatch_lock_t DrainLock;
-  uint32_t Unused;
+  LLVM_ATTRIBUTE_UNUSED uint32_t Unused = {};
 #elif SWIFT_CONCURRENCY_ENABLE_PRIORITY_ESCALATION && SWIFT_POINTER_IS_8_BYTES
   uint32_t Flags;
   dispatch_lock_t DrainLock;
 #elif !SWIFT_CONCURRENCY_ENABLE_PRIORITY_ESCALATION && SWIFT_POINTER_IS_4_BYTES
   uint32_t Flags;
 #else /* !SWIFT_CONCURRENCY_ENABLE_PRIORITY_ESCALATION && SWIFT_POINTER_IS_8_BYTES */
   uint32_t Flags;
-  uint32_t Unused;
+  LLVM_ATTRIBUTE_UNUSED uint32_t Unused = {};
 #endif
   JobRef FirstJob;
 
@@ -701,7 +701,7 @@ class alignas(sizeof(void *) * 2) ActiveActorStatus {
   bool isIdle() const {
     bool isIdle = (getActorState() == Idle);
     if (isIdle) {
-      assert(FirstJob == NULL);
+      assert(!FirstJob);
     }
     return isIdle;
   }
@@ -1063,7 +1063,7 @@ preprocessQueue(JobRef unprocessedStart, JobRef unprocessedEnd, Job *existingPro
 // Preprocess the queue starting from the top
 static Job *
 preprocessQueue(JobRef start) {
-  if (start == NULL) {
+  if (!start) {
     return NULL;
   }
 
@@ -1081,7 +1081,7 @@ preprocessQueue(JobRef start) {
   Job *wellFormedListStart = NULL;
 
   auto current = start;
-  while (current != NULL) {
+  while (current) {
     if (!current.needsPreprocessing()) {
       // We can assume that everything from here onwards as being well formed
       // and sorted
@@ -1241,7 +1241,7 @@ retry:;
       }
 
       assert(oldState.getMaxPriority() == JobPriority::Unspecified);
-      assert(oldState.getFirstJob() == NULL);
+      assert(!oldState.getFirstJob());
     }
 
     auto newState = oldState.withRunning();
@@ -1352,7 +1352,7 @@ bool DefaultActorImpl::unlock(bool forceUnlock)
     }
 
     auto newState = oldState;
-    if (oldState.getFirstJob() != NULL) {
+    if (oldState.getFirstJob()) {
       // There is work left to do, don't unlock the actor
       if (!forceUnlock) {
         SWIFT_TASK_DEBUG_LOG("Unlock-ing actor %p failed", this);
@@ -1375,7 +1375,7 @@ bool DefaultActorImpl::unlock(bool forceUnlock)
 
       if (newState.isScheduled()) {
         // See ownership rule (6) in DefaultActorImpl
-        assert(newState.getFirstJob() != NULL);
+        assert(newState.getFirstJob());
         scheduleActorProcessJob(newState.getMaxPriority(), true);
       } else {
         // See ownership rule (5) in DefaultActorImpl

stdlib/public/Concurrency/Clock.cpp

@@ -58,7 +58,7 @@ void swift_get_time(
 #else
 #error Missing platform continuous time definition
 #endif
-      break;
+      return;
     }
     case swift_clock_id_suspending: {
 #if defined(__linux__) && HAS_TIME
@@ -87,11 +87,10 @@ void swift_get_time(
 #else
 #error Missing platform suspending time definition
 #endif
-      break;
+      return;
     }
-    default:
-      abort();
   }
+  abort(); // Invalid clock_id
 }
 
 SWIFT_EXPORT_FROM(swift_Concurrency)
@@ -118,7 +117,7 @@ switch (clock_id) {
 #else
 #error Missing platform continuous time definition
 #endif
-      break;
+      return;
     }
     case swift_clock_id_suspending: {
       struct timespec suspending;
@@ -136,9 +135,8 @@ switch (clock_id) {
 #else
 #error Missing platform suspending time definition
 #endif
-      break;
+      return;
     }
-   default:
-     abort();
   }
+  abort(); // Invalid clock_id
 }