Merge pull request #61338 from apple/egorzhdan/cxx-string-non-ascii

[cxx-interop] Do not crash for non-ASCII strings

Author: egorzhdan

stdlib/public/Cxx/std/String.swift

@@ -14,7 +14,7 @@ extension std.string {
   public init(_ string: String) {
     self.init()
     for char in string.utf8 {
-      self.push_back(value_type(char))
+      self.push_back(value_type(bitPattern: char))
     }
   }
 }

test/Interop/Cxx/stdlib/overlay/std-string-overlay.swift

@@ -19,6 +19,17 @@ StdStringOverlayTestSuite.test("std::string <=> Swift.String") {
 
   let cxx3: std.string = "literal"
   expectEqual(cxx3.size(), 7)
+
+  // Non-ASCII characters are represented by more than one CChar.
+  let cxx4: std.string = "тест"
+  expectEqual(cxx4.size(), 8)
+  let swift4 = String(cxxString: cxx4)
+  expectEqual(swift4, "тест")
+
+  let cxx5: std.string = "emoji_🤖"
+  expectEqual(cxx5.size(), 10)
+  let swift5 = String(cxxString: cxx5)
+  expectEqual(swift5, "emoji_🤖")
 }
 
 extension std.string.const_iterator: UnsafeCxxInputIterator {