Skip to content

Commit 5c14017

Browse files
committed
For size comparisons, build the result objects directly with sample data
1 parent e1ab70a commit 5c14017

File tree

1 file changed

+7
-13
lines changed

1 file changed

+7
-13
lines changed

benchmark/scripts/run_smoke_bench

Lines changed: 7 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ import subprocess
2828
import sys
2929
from imp import load_source
3030

31-
from compare_perf_tests import LogParser, TestComparator, create_report
31+
from compare_perf_tests import PerformanceTestResult, TestComparator, create_report
3232

3333
# import Benchmark_Driver # doesn't work because it misses '.py' extension
3434
Benchmark_Driver = load_source(
@@ -283,26 +283,20 @@ def report_code_size(opt_level, old_dir, new_dir, architecture, platform, output
283283
)
284284

285285
idx = 1
286-
old_lines = ""
287-
new_lines = ""
286+
old_results = {}
287+
new_results = {}
288288
for oldfile in files:
289289
new_dir = os.path.join(new_dir, '')
290290
newfile = oldfile.replace(old_dir, new_dir, 1)
291291
if os.path.isfile(newfile):
292292
oldsize = get_codesize(oldfile)
293293
newsize = get_codesize(newfile)
294294
bname = os.path.basename(oldfile)
295-
296-
def result_line(value):
297-
v = "," + str(value)
298-
return str(idx) + "," + bname + ",1" + (v * 3) + ",0" + v + "\n"
299-
300-
old_lines += result_line(oldsize)
301-
new_lines += result_line(newsize)
295+
old_json = {"number":idx, "name":bname, "samples":[oldsize]}
296+
new_json = {"number":idx, "name":bname, "samples":[newsize]}
297+
old_results[bname] = PerformanceTestResult(old_json)
298+
new_results[bname] = PerformanceTestResult(new_json)
302299
idx += 1
303-
304-
old_results = LogParser.results_from_string(old_lines)
305-
new_results = LogParser.results_from_string(new_lines)
306300
return report_results(
307301
"Code size: -" + opt_level, 0.01, output_file, old_results, new_results
308302
)

0 commit comments

Comments
 (0)