Revert "[CSBindings] Prefer conjunctions over closure variables without bindings"

This reverts commit 11ee82d.

Author: xedin

lib/Sema/CSBindings.cpp

@@ -1094,13 +1094,6 @@ bool BindingSet::favoredOverConjunction(Constraint *conjunction) const {
   if (locator->directlyAt<ClosureExpr>()) {
     auto *closure = castToExpr<ClosureExpr>(locator->getAnchor());
 
-    // If there are no bindings for the closure yet we cannot prioritize
-    // it because that runs into risk of missing a result builder transform.
-    if (TypeVar->getImpl().isClosureType()) {
-      if (Bindings.empty())
-        return false;
-    }
-
     if (auto transform = CS.getAppliedResultBuilderTransform(closure)) {
       // Conjunctions that represent closures with result builder transformed
       // bodies could be attempted right after their resolution if they meet

test/Constraints/issue67363.swift

@@ -694,27 +694,3 @@ func test_recursive_var_reference_in_multistatement_closure() {
     }
   }
 }
-
-// https://github.com/apple/swift/issues/67363
-func test_result_builder_in_member_chaining() {
-  @resultBuilder
-  struct Builder {
-    static func buildBlock<T>(_: T) -> Int { 42 }
-  }
-
-  struct Test {
-    static func test<T>(fn: () -> T) -> T {
-      fn()
-    }
-
-    func builder(@Builder _: () -> Int) {}
-  }
-
-  Test.test {
-    let test = Test()
-    return test
-  }.builder { // Ok
-    let result = ""
-    result
-  }
-}