use the new ASSERT macro for two asserts which should also fire in a release-built compiler

Author: eeckstein

lib/SIL/IR/OperandOwnership.cpp

@@ -510,7 +510,7 @@ static OperandOwnership getFunctionArgOwnership(SILArgumentConvention argConv,
   case SILArgumentConvention::Indirect_Out:
   case SILArgumentConvention::Indirect_Inout:
   case SILArgumentConvention::Indirect_InoutAliasable:
-    llvm_unreachable("Illegal convention for non-address types");
+    ASSERT(false && "Illegal convention for non-address types");
   }
   llvm_unreachable("covered switch");
 }

lib/SILOptimizer/Utils/Devirtualize.cpp

@@ -801,7 +801,7 @@ swift::devirtualizeClassMethod(SILPassManager *pm, FullApplySite applySite,
 
   if (SILType errorTy = substConv.getIndirectErrorResultType(applySite.getFunction()->getTypeExpansionContext())) {
     auto errorArgs = applySite.getIndirectSILErrorResults();
-    assert(errorArgs.size() == 1);
+    ASSERT(errorArgs.size() == 1);
     SILValue errorArg = errorArgs[0];
     auto castRes = castValueToABICompatibleType(
         &builder, pm, loc, errorArg, errorArg->getType(),