Skip to content

Commit 65d6a01

Browse files
committed
[docs] FirstPullRequest: Rewrite "Asking for code review" section
* Account for automatic review requests * Add a proper fallback course of action * Link out to commit access section on our official website
1 parent 140caf6 commit 65d6a01

File tree

1 file changed

+18
-11
lines changed

1 file changed

+18
-11
lines changed

docs/HowToGuides/FirstPullRequest.md

Lines changed: 18 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -124,17 +124,24 @@ show a helpful "Compare & Pull Request" button.
124124

125125
## Asking for code review
126126

127-
If you had an active discussion with someone on how to implement your change,
128-
you can `@` mention them in the PR description and ask for code review.
129-
If you directly implemented the change without any guidance from anyone else,
130-
`@` mention someone from GitHub's suggested reviewers. If GitHub doesn't
131-
make any suggestions, ask the [Code Owner](https://github.com/apple/swift/blob/main/CODE_OWNERS.TXT) based on the
132-
component for your change. Please ask someone though! We don't want you to get
133-
stuck because you were not sure who to ask for code review.
134-
135-
At the beginning, contributors are not able to run the continuous integration
136-
(CI) bot, which builds the project and runs tests. Please ask your code
137-
reviewer(s) to invoke the bot for you.
127+
Collaborators and code owners are automatically requested for review per the
128+
[CODEOWNERS](/.github/CODEOWNERS) file. If no one is automatically requested for
129+
review, @mention and ask a suggested person under **Reviewers** to review your
130+
changes. If no reviewer suggestions are shown either, please
131+
[message][contributor-experience] the Contributor Experience Workgroup on the
132+
Swift forums to sort out review requests for you.
133+
134+
You are welcome to invite other people for review as well — say, someone you
135+
had an active discussion with on how to implement your change.
136+
Anyone with a GitHub account can review or comment on changes proposed to
137+
this repository!
138+
139+
Contributors without
140+
[write access](https://swift.org/contributing/#commit-access) are not able to
141+
run the continuous integration (CI) bot, which builds the project and runs
142+
tests. Please ask a code reviewer with write access to invoke the bot for you.
143+
144+
[contributor-experience]: https://forums.swift.org/g/contributor-experience-workgroup
138145

139146
## Responding to code review comments
140147

0 commit comments

Comments
 (0)