Merge pull request #60718 from AnthonyLatsis/migrate-test-suite-to-gh-issues-9

AnthonyLatsis · web-flow · commit 6fe9dd34d049 · 2022-08-26T14:39:52.000+03:00
diff --git a/test/CrossImport/horrible.swift b/test/CrossImport/horrible.swift
@@ -16,7 +16,8 @@ import UnitaryGoose
 // expected-error@-1 {{cannot list cross-import overlays for 'UnitaryGoose':}}
 
 // FIXME: It might be better to diagnose these errors on HorribleGoose's import
-// decl, since they actually belong to HorribleGoose. (SR-12223)
+// decl, since they actually belong to HorribleGoose.
+// (https://github.com/apple/swift/issues/54649)
 
 import FlockOfGoose
 // expected-error@-1 {{cannot load cross-import overlay for 'HorribleGoose' and 'FlockOfGoose':}}
diff --git a/test/CrossImport/remark-option.swift b/test/CrossImport/remark-option.swift
@@ -4,6 +4,7 @@
 // RUN: %target-typecheck-verify-swift -enable-cross-import-overlays -Rcross-import -I %t/include -I %t/lib/swift -F %t/Frameworks
 
 import DeclaringLibrary
-// FIXME: Similarly to horrible.swift, ideally we would emit this remark on DeclaringLibrary
-// decl, since the cross-import overlay actually belongs to the DeclaringLibrary. (SR-12223)
+// FIXME: Similarly to horrible.swift, ideally we would emit this remark on
+// DeclaringLibrary decl, since the cross-import overlay actually belongs to
+// the DeclaringLibrary. (https://github.com/apple/swift/issues/54649)
 import BystandingLibrary // expected-remark {{import of 'DeclaringLibrary' and 'BystandingLibrary' triggered a cross-import of '_OverlayLibrary'}}
diff --git a/test/DebugInfo/debug_variable.sil b/test/DebugInfo/debug_variable.sil
@@ -6,8 +6,8 @@ import Swift
 
 sil_scope 2 { loc "simple.swift":1:2 parent @test_debug_value : $@convention(thin) (Int) -> () }
 
-// SR-14868: Incorrect source location on `llvm.dbg.declare` when the input
-// is SIL file.
+// https://github.com/apple/swift/issues/57215
+// Incorrect source location on 'llvm.dbg.declare' when the input is a SIL file
 
 // CHECK: @test_debug_value
 // CHECK-SAME: !dbg ![[FUNC_DI:[0-9]+]]
diff --git a/test/DebugInfo/optimizer_pipeline.swift b/test/DebugInfo/optimizer_pipeline.swift
@@ -5,7 +5,9 @@
 import Swift
 
 // Test that DCE correctly preserves debug locations.
-// SR-15300: Compiler crash when using Builtin.unreachable in initializers
+
+// https://github.com/apple/swift/issues/57622
+// Compiler crash when using 'Builtin.unreachable' in initializers
 //
 // CHECK: sil_scope [[S1:[0-9]+]] { {{.*}} parent @$s18optimizer_pipeline1AVyACs13KeyValuePairsVyypypGcfC
 // CHECK: sil_scope [[S2:[0-9]+]] { {{.*}} parent [[S1]] }
diff --git a/test/DebugInfo/retroactive_conformance_witness_thunk.swift b/test/DebugInfo/retroactive_conformance_witness_thunk.swift
@@ -1,6 +1,6 @@
 // RUN: %target-swift-frontend -emit-ir -g -primary-file %s
 
-// https://bugs.swift.org/browse/SR-14016
+// https://github.com/apple/swift/issues/56409
 
 public struct PowerCollection<C : Collection> : Collection {
   public typealias Index = [C.Index]
diff --git a/test/decl/circularity.swift b/test/decl/circularity.swift
@@ -110,10 +110,10 @@ class D4 : C4, P1 { // expected-note 3 {{through reference here}}
   }
 }
 
-// SR-12236
+// https://github.com/apple/swift/issues/54662
 // N.B. This used to compile in 5.1.
-protocol SR12236 { }
-class SR12236_A { // expected-note {{through reference here}}
-    typealias Nest = SR12236 // expected-error {{circular reference}} expected-note {{through reference here}}
+protocol P_54662 { }
+class C_54662 { // expected-note {{through reference here}}
+    typealias Nest = P_54662 // expected-error {{circular reference}} expected-note {{through reference here}}
 }
-extension SR12236_A: SR12236_A.Nest { }
+extension C_54662: C_54662.Nest { }
diff --git a/test/decl/enum/enumtest.swift b/test/decl/enum/enumtest.swift
@@ -299,7 +299,8 @@ func testSimpleEnum() {
   let _ : SimpleEnum=.X    // expected-error {{'=' must have consistent whitespace on both sides}}
 }
 
-enum SR510: String {
+// https://github.com/apple/swift/issues/43127
+enum E_43127: String {
     case Thing = "thing"
     case Bob = {"test"} // expected-error {{raw value for enum case must be a literal}}
 }
@@ -337,7 +338,8 @@ enum HasVariadic {
   case variadic(x: Int...) // expected-error {{variadic enum cases are not supported}}
 }
 
-// SR-2176
+// https://github.com/apple/swift/issues/44784
+
 enum Foo {
   case bar
   case none
@@ -446,7 +448,7 @@ protocol P {}
 enum E : C & P {}
 // expected-error@-1 {{inheritance from class-constrained protocol composition type 'C & P'}}
 
-// SR-11522
+// https://github.com/apple/swift/issues/53923
 
 enum EnumWithStaticNone1 {
   case a
@@ -573,7 +575,7 @@ let _: EnumWithTypealiasNone? = .none // Okay
 let _: EnumWithBothStructAndComputedNone? = .none // Okay
 let _: EnumWithBothTypealiasAndComputedNone? = .none // Okay
 
-// SR-12063
+// https://github.com/apple/swift/issues/54499
 
 let foo1: Foo? = Foo.none
 let foo2: Foo?? = Foo.none
diff --git a/test/decl/enum/special_case_name.swift b/test/decl/enum/special_case_name.swift
@@ -1,6 +1,6 @@
 // RUN: %target-typecheck-verify-swift -swift-version 5
 
-// https://bugs.swift.org/browse/SR-1660
+// https://github.com/apple/swift/issues/44269
 
 enum DayOfTheWeek : Int {
   case monday = 0
diff --git a/test/decl/ext/extensions.swift b/test/decl/ext/extensions.swift
@@ -122,9 +122,9 @@ extension X3 {
   func foo() -> Int { return 0 }
 }
 
-// Make sure the test case from https://bugs.swift.org/browse/SR-3847 doesn't
-// cause problems when the later extension is incorrectly nested inside another
-// declaration.
+// Make sure the test case from https://github.com/apple/swift/issues/46432
+// doesn't cause problems when the later extension is incorrectly nested inside
+// another declaration.
 extension C1.NestedStruct {
   static let originalValue = 0
 }
@@ -135,7 +135,7 @@ struct WrapperContext {
 }
 
 // Class-constrained extension where protocol does not impose class requirement
-// SR-11298
+// https://github.com/apple/swift/issues/53699
 
 protocol DoesNotImposeClassReq_1 {}
 
@@ -352,11 +352,12 @@ extension Tree.BoughPayload.Contents {
   // expected-note@-2 {{did you mean to extend 'Nest<Int>' instead?}}
 }
 
-// SR-10466 Check 'where' clause when referencing type defined inside extension
-struct SR_10466<T> {
-  var a : A // expected-error {{'SR_10466<T>.A' (aka 'Int') requires the types 'T' and 'Never' be equivalent}}
+// https://github.com/apple/swift/issues/52866
+// Check 'where' clause when referencing type defined inside extension.
+struct S_52866<T> {
+  var a : A // expected-error {{'S_52866<T>.A' (aka 'Int') requires the types 'T' and 'Never' be equivalent}}
 }
-extension SR_10466 where T == Never { // expected-note {{requirement specified as 'T' == 'Never' [with T = T]}}
+extension S_52866 where T == Never { // expected-note {{requirement specified as 'T' == 'Never' [with T = T]}}
   typealias A = Int
 }
 
diff --git a/test/decl/ext/generic.swift b/test/decl/ext/generic.swift
@@ -175,7 +175,7 @@ extension Array2 where QQQ : VVV {}
 // expected-error@-1 {{cannot find type 'QQQ' in scope}}
 // expected-error@-2 {{cannot find type 'VVV' in scope}}
 
-// https://bugs.swift.org/browse/SR-9009
+// https://github.com/apple/swift/issues/51512
 func foo() {
   extension Array where Element : P1 {
   // expected-error@-1 {{declaration is only valid at file scope}}
diff --git a/test/decl/ext/ordering.swift b/test/decl/ext/ordering.swift
@@ -122,7 +122,7 @@ extension OtherOuter5 {
   class Super {}
 }
 
-/// SR-5993
+/// https://github.com/apple/swift/issues/48550
 
 enum Outer5A {}
 
diff --git a/test/decl/ext/protocol.swift b/test/decl/ext/protocol.swift
@@ -288,7 +288,9 @@ extension ExtendedProtocol where Self : DerivedWithAlias {
   func f4(x: NestedNominal) {}
 }
 
-// rdar://problem/21991470 & https://bugs.swift.org/browse/SR-5022
+// rdar://problem/21991470
+// https://github.com/apple/swift/issues/47598
+
 class NonPolymorphicInit {
   init() { } // expected-note {{selected non-required initializer 'init()'}}
 }
diff --git a/test/decl/ext/specialize.swift b/test/decl/ext/specialize.swift
@@ -15,7 +15,7 @@ let _ = [1, 2, 3].makeString() // expected-error 3 {{cannot convert value of typ
 
 extension Set<_> {} // expected-error {{cannot extend a type that contains placeholders}}
 
-// https://bugs.swift.org/browse/SR-4875
+// https://github.com/apple/swift/issues/47452
 
 struct Foo<T, U> {
   var x: T
diff --git a/test/decl/ext/sr_12460.swift b/test/decl/ext/sr_12460.swift
@@ -1,6 +1,9 @@
 // RUN: %target-swift-ide-test -print-indexed-symbols -source-filename %s 2>&1 | %FileCheck -check-prefix CHECK %s
 
-// Test that we don't crash when validating members inside an extension with no type name.
+// https://github.com/apple/swift/issues/54900
+//
+// Test that we don't crash when validating members inside an extension with no
+// type name.
 
 // CHECK: :[[@LINE+1]]:11: error: expected type name in extension declaration
 extension {
diff --git a/test/decl/func/default-values-swift4.swift b/test/decl/func/default-values-swift4.swift
@@ -93,7 +93,7 @@ public func publicFunctionWithDefaultValue(
     y: Int = internalIntFunction()) {}
     // expected-error@-1 {{global function 'internalIntFunction()' is internal and cannot be referenced from a default argument value}}
 
-// https://bugs.swift.org/browse/SR-5559
+// https://github.com/apple/swift/issues/48131
 public class MyClass {
   public func method<T>(_: T.Type = T.self) -> T { }
 }
diff --git a/test/decl/func/default-values.swift b/test/decl/func/default-values.swift
@@ -123,7 +123,7 @@ struct X<T> {
 let testXa: X<Int> = .foo(i: 0)
 let testXb: X<Int> = .bar
 
-// SR-10062
+// https://github.com/apple/swift/issues/52464
 
 var aLiteral = 1
 let bLiteral = 2
@@ -175,16 +175,21 @@ let fooThing5 = Foo(a: 0, d: 1, h: nil) // expected-error {{missing arguments fo
 let fooThing6 = Foo(a: 0, d: 1, e: 2, h: nil) // expected-error {{missing argument for parameter 'f' in call}}
                                               // expected-note@-29 {{'init(a:b:d:e:f:g:h:)' declared here}}
 
-// SR-11085
-func sr_11085(x: Int) {}
-func sr_11085(line: String = #line) {} // expected-error {{default argument value of type 'Int' cannot be converted to type 'String'}}
-sr_11085()
+// https://github.com/apple/swift/issues/53477
+  do {
+  func f(x: Int) {}
+  func f(line: String = #line) {} // expected-error {{default argument value of type 'Int' cannot be converted to type 'String'}}
+  f()
 
-class SR_11085_C { init(line: String = #line) {} } // expected-error {{default argument value of type 'Int' cannot be converted to type 'String'}}
-let _ = SR_11085_C()
+  class C { init(line: String = #line) {} } // expected-error {{default argument value of type 'Int' cannot be converted to type 'String'}}
+  let _ = C()
+}
+
+// https://github.com/apple/swift/issues/54034
 
-// SR-11623
-func badGenericMagicLiteral<T : ExpressibleByIntegerLiteral>(_ x: T = #function) -> T { x } // expected-error {{default argument value of type 'String' cannot be converted to type 'T'}}
+// FIXME: Bad diagnostic
+// expected-error@+1 {{default argument value of type 'String' cannot be converted to type 'T'}}
+func badGenericMagicLiteral<T : ExpressibleByIntegerLiteral>(_ x: T = #function) -> T { x }
 let _: Int = badGenericMagicLiteral()
 
 func genericMagicLiteral<T : ExpressibleByIntegerLiteral>(_ x: T = #line) -> T { x } // expected-note {{where 'T' = 'String'}}
diff --git a/test/decl/func/functions.swift b/test/decl/func/functions.swift
@@ -181,7 +181,7 @@ func parentheticalInout2(_ fn: (((inout Int)), Int) -> ()) {
   fn(&value, 0)
 }
 
-// SR-11724
+// https://github.com/apple/swift/issues/54133
 // FIXME: None of these diagnostics is particularly good.
 func bogusDestructuring() {
   struct Bar {}
diff --git a/test/decl/func/rethrows.swift b/test/decl/func/rethrows.swift
@@ -536,7 +536,7 @@ func testDoRethrow() {
   DoRethrowGeneric<Int>().method(fn:) { (a, b) in return a }
 }
 
-// https://bugs.swift.org/browse/SR-7120 - capture lists
+// https://github.com/apple/swift/issues/49668
 func rethrowsWithCaptureList<R, T>(
   array: [T],
   operation: (Int) throws -> R
@@ -553,10 +553,10 @@ public func rdar40472018() {
 }
 
 
-// https://bugs.swift.org/browse/SR-6299
+// https://github.com/apple/swift/issues/48849
 // Verify that we do not emit an invalid
 //   "... can throw but the expression is not marked with 'try'"
-// error on the use of the operators.
+// error on the use of operators.
 
 infix operator <|: infixr0
 infix operator |>: infixl1
@@ -613,12 +613,16 @@ func rdar_47550715() {
   func bar(_: A<F>? = .none) {} // Ok
 }
 
-// SR-14270 - test case for diagnostic note 'because_rethrows_default_argument_throws'
+// https://github.com/apple/swift/issues/56630
+// Test cases for diagnostic note 'because_rethrows_default_argument_throws'
+
 func nonThrowableDefaultRethrows(_ f: () throws -> () = {}) rethrows {
   try f()
 }
-// NOTE: This should compile and not emit a diagnostic because ideally the compiler could statically
-// know the default argument value could never throw. See SR-1524.
+
+// FIXME: This should compile and not emit a diagnostic because ideally the
+// compiler could statically know the default argument value could never throw.
+// (https://github.com/apple/swift/issues/44143)
 nonThrowableDefaultRethrows() // expected-error {{call can throw but is not marked with 'try'}}
                               // expected-note@-1 {{call is to 'rethrows' function, but a defaulted argument function can throw}}
 
diff --git a/test/decl/func/throwing_functions_without_try.swift b/test/decl/func/throwing_functions_without_try.swift
@@ -52,14 +52,14 @@ func baz2() -> Int {
   return x
 }
 
-// SR-11016
+// https://github.com/apple/swift/issues/53406
 
-protocol SR_11016_P {
+protocol P_53406 {
   func bar() throws
 }
 
-class SR_11016_C {
-  var foo: SR_11016_P?
+class C_53406 {
+  var foo: P_53406?
 
   func someMethod() throws {
     foo?.bar() // expected-error {{call can throw but is not marked with 'try'}}
diff --git a/test/decl/func/trailing_closures.swift b/test/decl/func/trailing_closures.swift
@@ -1,5 +1,6 @@
 // RUN: %target-typecheck-verify-swift
 
-// SR-4205: Don't warn about non-trailing closures followed by parameters with
+// https://github.com/apple/swift/issues/46788
+// Don't warn about non-trailing closures followed by parameters with
 // default arguments.
 func f1(_ f: () -> (), bar: Int = 10) { } // no-warning
diff --git a/test/decl/inherit/inherit.swift b/test/decl/inherit/inherit.swift
@@ -18,7 +18,7 @@ class C : B, A { } // expected-error{{multiple inheritance from classes 'B' and
 // Superclass in the wrong position
 class D : P, A { } // expected-error{{superclass 'A' must appear first in the inheritance clause}}{{12-15=}}{{11-11=A, }}
 
-// SR-8160
+// https://github.com/apple/swift/issues/50692
 class D1 : Any, A { } // expected-error{{superclass 'A' must appear first in the inheritance clause}}{{15-18=}}{{12-12=A, }}
 
 class D2 : P & P1, A { } // expected-error{{superclass 'A' must appear first in the inheritance clause}}{{18-21=}}{{12-12=A, }}
diff --git a/test/decl/inherit/initializer.swift b/test/decl/inherit/initializer.swift
@@ -111,21 +111,21 @@ func testClassInGenericFunc<T>(t: T) {
 }
 
 
-// <https://bugs.swift.org/browse/SR-5056> Required convenience init inhibits inheritance
-
-class SR5056A {
+// https://github.com/apple/swift/issues/47632
+// Required convenience 'init' inhibits inheritance
+do {
+  class A {
     required init(a: Int) {}
-}
+  }
 
-class SR5056B : SR5056A {
+  class B : A {
     required convenience init(b: Int) {
         self.init(a: b)
     }
-}
+  }
 
-class SR5056C : SR5056B {}
+  class C : B {}
 
-func useSR5056C() {
-  _ = SR5056C(a: 0)
-  _ = SR5056C(b: 0)
+  _ = C(a: 0)
+  _ = C(b: 0)
 }
diff --git a/test/decl/nested/type_in_type.swift b/test/decl/nested/type_in_type.swift
diff --git a/test/decl/overload.swift b/test/decl/overload.swift
diff --git a/test/decl/overload_swift4.swift b/test/decl/overload_swift4.swift
diff --git a/test/decl/overload_swift5.swift b/test/decl/overload_swift5.swift
diff --git a/test/decl/subscript/subscripting.swift b/test/decl/subscript/subscripting.swift
diff --git a/test/decl/typealias/on_constrained_protocol.swift b/test/decl/typealias/on_constrained_protocol.swift

Original file line number	Diff line number	Diff line change
`@@ -110,10 +110,10 @@ class D4 : C4, P1 { // expected-note 3 {{through reference here}}`
`110`	`110`	`}`
`111`	`111`	`}`
`112`	`112`
`113`		`-// SR-12236`
	`113`	`+// https://github.com/apple/swift/issues/54662`
`114`	`114`	`// N.B. This used to compile in 5.1.`
`115`		`-protocol SR12236 { }`
`116`		`-class SR12236_A { // expected-note {{through reference here}}`
`117`		`- typealias Nest = SR12236 // expected-error {{circular reference}} expected-note {{through reference here}}`
	`115`	`+protocol P_54662 { }`
	`116`	`+class C_54662 { // expected-note {{through reference here}}`
	`117`	`+ typealias Nest = P_54662 // expected-error {{circular reference}} expected-note {{through reference here}}`
`118`	`118`	`}`
`119`		`-extension SR12236_A: SR12236_A.Nest { }`
	`119`	`+extension C_54662: C_54662.Nest { }`
Original file line number	Diff line number	Diff line change
`@@ -122,9 +122,9 @@ extension X3 {`
`122`	`122`	`func foo() -> Int { return 0 }`
`123`	`123`	`}`
`124`	`124`
`125`		`-// Make sure the test case from https://bugs.swift.org/browse/SR-3847 doesn't`
`126`		`-// cause problems when the later extension is incorrectly nested inside another`
`127`		`-// declaration.`
	`125`	`+// Make sure the test case from https://github.com/apple/swift/issues/46432`
	`126`	`+// doesn't cause problems when the later extension is incorrectly nested inside`
	`127`	`+// another declaration.`
`128`	`128`	`extension C1.NestedStruct {`
`129`	`129`	`static let originalValue = 0`
`130`	`130`	`}`
`@@ -135,7 +135,7 @@ struct WrapperContext {`
`135`	`135`	`}`
`136`	`136`
`137`	`137`	`// Class-constrained extension where protocol does not impose class requirement`
`138`		`-// SR-11298`
	`138`	`+// https://github.com/apple/swift/issues/53699`
`139`	`139`
`140`	`140`	`protocol DoesNotImposeClassReq_1 {}`
`141`	`141`
`@@ -352,11 +352,12 @@ extension Tree.BoughPayload.Contents {`
`352`	`352`	`// expected-note@-2 {{did you mean to extend 'Nest<Int>' instead?}}`
`353`	`353`	`}`
`354`	`354`
`355`		`-// SR-10466 Check 'where' clause when referencing type defined inside extension`
`356`		`-struct SR_10466<T> {`
`357`		`- var a : A // expected-error {{'SR_10466<T>.A' (aka 'Int') requires the types 'T' and 'Never' be equivalent}}`
	`355`	`+// https://github.com/apple/swift/issues/52866`
	`356`	`+// Check 'where' clause when referencing type defined inside extension.`
	`357`	`+struct S_52866<T> {`
	`358`	`+ var a : A // expected-error {{'S_52866<T>.A' (aka 'Int') requires the types 'T' and 'Never' be equivalent}}`
`358`	`359`	`}`
`359`		`-extension SR_10466 where T == Never { // expected-note {{requirement specified as 'T' == 'Never' [with T = T]}}`
	`360`	`+extension S_52866 where T == Never { // expected-note {{requirement specified as 'T' == 'Never' [with T = T]}}`
`360`	`361`	`typealias A = Int`
`361`	`362`	`}`
`362`	`363`