Skip to content

Commit 7091c87

Browse files
committed
[move-function] Update a test now that I have merged in the better debug info salvaging while coroutine splitting into LLVM.
Thanks again to Adrian Prantl for his help with this work!
1 parent 9da5a4b commit 7091c87

File tree

1 file changed

+10
-12
lines changed

1 file changed

+10
-12
lines changed

test/DebugInfo/move_function_dbginfo_async.swift

Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ public func forceSplit() async {}
4141

4242
// CHECK-LABEL: define swifttailcc void @"$s27move_function_dbginfo_async13letSimpleTestyyxnYalF"(%swift.context* swiftasync %0, %swift.opaque* noalias %1, %swift.type* %T)
4343
// CHECK: entry:
44-
// CHECK: call void @llvm.dbg.addr(metadata %swift.opaque** %msg.debug, metadata ![[SIMPLE_TEST_METADATA:[0-9]+]], metadata !DIExpression(DW_OP_deref)), !dbg ![[ADDR_LOC:[0-9]+]]
44+
// CHECK: call void @llvm.dbg.addr(metadata %swift.context* %0, metadata ![[SIMPLE_TEST_METADATA:[0-9]+]], metadata !DIExpression(DW_OP_plus_uconst, 16, DW_OP_plus_uconst, 8, DW_OP_deref)), !dbg ![[ADDR_LOC:[0-9]+]]
4545
// CHECK: musttail call swifttailcc void
4646
// CHECK-NEXT: ret void
4747

@@ -60,10 +60,8 @@ public func forceSplit() async {}
6060

6161
// DWARF: DW_AT_linkage_name ("$s3out13letSimpleTestyyxnYalF")
6262
// DWARF: DW_TAG_formal_parameter
63-
// Disable this part of the test due to a different codegen bug.
64-
// XWARF-NEXT: DW_AT_location (0x{{[a-f0-9]+}}:
65-
// XWARF-NEXT: [0x{{[a-f0-9]+}}, 0x{{[a-f0-9]+}}): DW_OP_breg0 RAX+0, DW_OP_deref)
66-
// XWARF-NEXT: DW_AT_name ("msg")
63+
// DWARF-NEXT: DW_AT_location (DW_OP_entry_value(DW_OP_reg14 R14), DW_OP_plus_uconst 0x10, DW_OP_plus_uconst 0x8, DW_OP_deref)
64+
// DWARF-NEXT: DW_AT_name ("msg")
6765
//
6866
// DWARF: DW_AT_linkage_name ("$s3out13letSimpleTestyyxnYalFTQ0_")
6967
// DWARF: DW_AT_name ("letSimpleTest")
@@ -83,7 +81,7 @@ public func letSimpleTest<T>(_ msg: __owned T) async {
8381
}
8482

8583
// CHECK-LABEL: define swifttailcc void @"$s27move_function_dbginfo_async13varSimpleTestyyxz_xtYalF"(%swift.context* swiftasync %0, %swift.opaque* %1, %swift.opaque* noalias %2, %swift.type* %T)
86-
// CHECK: call void @llvm.dbg.addr(metadata %swift.opaque** %msg.debug, metadata !{{[0-9]+}}, metadata !DIExpression(DW_OP_deref))
84+
// CHECK: call void @llvm.dbg.addr(metadata %swift.context* %0, metadata !{{[0-9]+}}, metadata !DIExpression(DW_OP_plus_uconst, 16, DW_OP_plus_uconst, 8, DW_OP_deref))
8785
// CHECK: musttail call swifttailcc void @"$s27move_function_dbginfo_async10forceSplityyYaF"(%swift.context* swiftasync %{{[0-9]+}})
8886
// CHECK-NEXT: ret void
8987
// CHECK-NEXT: }
@@ -118,10 +116,8 @@ public func letSimpleTest<T>(_ msg: __owned T) async {
118116
// DWARF: DW_AT_linkage_name ("$s3out13varSimpleTestyyxz_xtYalF")
119117
// DWARF: DW_AT_name ("varSimpleTest")
120118
// DWARF: DW_TAG_formal_parameter
121-
// Disable this part of the test due to an additional error.
122-
// XWARF-NEXT: DW_AT_location (0x{{[a-f0-9]+}}:
123-
// XWARF-NEXT: [0x{{[a-f0-9]+}}, 0x{{[a-f0-9]+}}): DW_OP_breg2 RCX+0, DW_OP_deref)
124-
// XWARF-NEXT: DW_AT_name ("msg")
119+
// DWARF-NEXT: DW_AT_location (DW_OP_entry_value(DW_OP_reg14 R14), DW_OP_plus_uconst 0x10, DW_OP_plus_uconst 0x8, DW_OP_deref)
120+
// DWARF-NEXT: DW_AT_name ("msg")
125121
//
126122
// DWARF: DW_AT_linkage_name ("$s3out13varSimpleTestyyxz_xtYalFTQ0_")
127123
// DWARF: DW_AT_name ("varSimpleTest")
@@ -162,8 +158,10 @@ public func letSimpleTest<T>(_ msg: __owned T) async {
162158
// DWARF: DW_AT_linkage_name ("$s3out13varSimpleTestyyxz_xtYalFTY5_")
163159
// DWARF: DW_AT_name ("varSimpleTest")
164160
// DWARF: DW_TAG_formal_parameter
165-
// DWARF-NEXT: DW_AT_location (DW_OP_entry_value(DW_OP_reg14 R14), DW_OP_plus_uconst 0x[[MSG_LOC]], DW_OP_plus_uconst 0x8, DW_OP_deref)
166-
// DWARF-NEXT: DW_AT_name ("msg")
161+
// DWARF: DW_AT_location (0x{{[a-f0-9]+}}:
162+
// DWARF: [0x{{[a-f0-9]+}}, 0x{{[a-f0-9]+}}): DW_OP_entry_value(DW_OP_reg14 R14), DW_OP_plus_uconst 0x10, DW_OP_plus_uconst 0x8, DW_OP_deref
163+
// DWARF: [0x{{[a-f0-9]+}}, 0x{{[a-f0-9]+}}): DW_OP_breg6 RBP-88, DW_OP_deref, DW_OP_plus_uconst 0x10, DW_OP_plus_uconst 0x8, DW_OP_deref)
164+
// DWARF: DW_AT_name ("msg")
167165

168166
public func varSimpleTest<T>(_ msg: inout T, _ msg2: T) async {
169167
await forceSplit()

0 commit comments

Comments
 (0)