Skip to content

Commit 73106dd

Browse files
authored
Rename initialize(with:count:) to initialize(to:count:). (#3601)
As proposed in SE-0107: UnsafeRawPointer. "with" is considered a vacuous preposition. "to" implies direction.
1 parent d82483b commit 73106dd

34 files changed

+94
-88
lines changed

stdlib/private/StdlibUnittest/OpaqueIdentityFunctions.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ func _stdlib_getPointer(_ x: OpaquePointer) -> OpaquePointer
1515

1616
public func _opaqueIdentity<T>(_ x: T) -> T {
1717
let ptr = UnsafeMutablePointer<T>(allocatingCapacity: 1)
18-
ptr.initialize(with: x)
18+
ptr.initialize(to: x)
1919
let result =
2020
UnsafeMutablePointer<T>(_stdlib_getPointer(OpaquePointer(ptr))).pointee
2121
ptr.deinitialize()

stdlib/private/SwiftPrivate/ShardedAtomicCounter.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ public struct _stdlib_ShardedAtomicCounter {
3535
let count = max(8, hardwareConcurrency * hardwareConcurrency)
3636
let shards = UnsafeMutablePointer<Int>(allocatingCapacity: count)
3737
for i in 0..<count {
38-
(shards + i).initialize(with: 0)
38+
(shards + i).initialize(to: 0)
3939
}
4040
self._shardsPtr = shards
4141
self._shardsCount = count

stdlib/private/SwiftPrivatePthreadExtras/SwiftPrivatePthreadExtras.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ internal class PthreadBlockContextImpl<Argument, Result>: PthreadBlockContext {
4242

4343
override func run() -> UnsafeMutablePointer<Void> {
4444
let result = UnsafeMutablePointer<Result>(allocatingCapacity: 1)
45-
result.initialize(with: block(arg))
45+
result.initialize(to: block(arg))
4646
return UnsafeMutablePointer(result)
4747
}
4848
}

stdlib/private/SwiftReflectionTest/SwiftReflectionTest.swift

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -357,7 +357,7 @@ public func reflect(object: AnyObject) {
357357
public func reflect<T>(any: T) {
358358
let any: Any = any
359359
let anyPointer = UnsafeMutablePointer<Any>(allocatingCapacity: sizeof(Any.self))
360-
anyPointer.initialize(with: any)
360+
anyPointer.initialize(to: any)
361361
let anyPointerValue = unsafeBitCast(anyPointer, to: UInt.self)
362362
reflect(instanceAddress: anyPointerValue, kind: .Existential)
363363
anyPointer.deallocateCapacity(sizeof(Any.self))
@@ -421,7 +421,7 @@ struct ThickFunctionParts {
421421
public func reflect(function: () -> ()) {
422422
let fn = UnsafeMutablePointer<ThickFunction0>(
423423
allocatingCapacity: sizeof(ThickFunction0.self))
424-
fn.initialize(with: ThickFunction0(function: function))
424+
fn.initialize(to: ThickFunction0(function: function))
425425

426426
let parts = unsafeBitCast(fn, to: UnsafePointer<ThickFunctionParts>.self)
427427
let contextPointer = unsafeBitCast(parts.pointee.context, to: UInt.self)
@@ -436,7 +436,7 @@ public func reflect(function: () -> ()) {
436436
public func reflect(function: (Int) -> ()) {
437437
let fn = UnsafeMutablePointer<ThickFunction1>(
438438
allocatingCapacity: sizeof(ThickFunction1.self))
439-
fn.initialize(with: ThickFunction1(function: function))
439+
fn.initialize(to: ThickFunction1(function: function))
440440

441441
let parts = unsafeBitCast(fn, to: UnsafePointer<ThickFunctionParts>.self)
442442
let contextPointer = unsafeBitCast(parts.pointee.context, to: UInt.self)
@@ -451,7 +451,7 @@ public func reflect(function: (Int) -> ()) {
451451
public func reflect(function: (Int, String) -> ()) {
452452
let fn = UnsafeMutablePointer<ThickFunction2>(
453453
allocatingCapacity: sizeof(ThickFunction2.self))
454-
fn.initialize(with: ThickFunction2(function: function))
454+
fn.initialize(to: ThickFunction2(function: function))
455455

456456
let parts = unsafeBitCast(fn, to: UnsafePointer<ThickFunctionParts>.self)
457457
let contextPointer = unsafeBitCast(parts.pointee.context, to: UInt.self)
@@ -466,7 +466,7 @@ public func reflect(function: (Int, String) -> ()) {
466466
public func reflect(function: (Int, String, AnyObject?) -> ()) {
467467
let fn = UnsafeMutablePointer<ThickFunction3>(
468468
allocatingCapacity: sizeof(ThickFunction3.self))
469-
fn.initialize(with: ThickFunction3(function: function))
469+
fn.initialize(to: ThickFunction3(function: function))
470470

471471
let parts = unsafeBitCast(fn, to: UnsafePointer<ThickFunctionParts>.self)
472472
let contextPointer = unsafeBitCast(parts.pointee.context, to: UInt.self)

stdlib/public/SDK/Foundation/NSError.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -282,7 +282,7 @@ public func _stdlib_bridgeNSErrorToError<
282282
T : _ObjectiveCBridgeableError
283283
>(_ error: NSError, out: UnsafeMutablePointer<T>) -> Bool {
284284
if let bridged = T(_bridgedNSError: error) {
285-
out.initialize(with: bridged)
285+
out.initialize(to: bridged)
286286
return true
287287
} else {
288288
return false

stdlib/public/core/ArrayBuffer.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -217,7 +217,7 @@ extension _ArrayBuffer {
217217
// Make another pass to retain the copied objects
218218
var result = target
219219
for _ in CountableRange(bounds) {
220-
result.initialize(with: result.pointee)
220+
result.initialize(to: result.pointee)
221221
result += 1
222222
}
223223
return result

stdlib/public/core/ArrayBufferProtocol.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ extension _ArrayBufferProtocol where Index == Int {
163163
}
164164
// Initialize the hole left by sliding the tail forward
165165
for j in oldTailIndex..<newTailIndex {
166-
(elements + j).initialize(with: newValues[i])
166+
(elements + j).initialize(to: newValues[i])
167167
newValues.formIndex(after: &i)
168168
}
169169
_expectEnd(i, newValues)

stdlib/public/core/Arrays.swift.gyb

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1061,7 +1061,7 @@ extension ${Self} : RangeReplaceableCollection, _ArrayProtocol {
10611061
var p: UnsafeMutablePointer<Element>
10621062
(self, p) = ${Self}._allocateUninitialized(count)
10631063
for _ in 0..<count {
1064-
p.initialize(with: repeatedValue)
1064+
p.initialize(to: repeatedValue)
10651065
p += 1
10661066
}
10671067
}
@@ -1252,7 +1252,7 @@ extension ${Self} : RangeReplaceableCollection, _ArrayProtocol {
12521252
_sanityCheck(_buffer.capacity >= _buffer.count + 1)
12531253

12541254
_buffer.count = oldCount + 1
1255-
(_buffer.firstElementAddress + oldCount).initialize(with: newElement)
1255+
(_buffer.firstElementAddress + oldCount).initialize(to: newElement)
12561256
}
12571257

12581258
/// Adds a new element at the end of the array.
@@ -1616,7 +1616,7 @@ internal struct _InitializeMemoryFromCollection<
16161616
var p = rawMemory
16171617
var q = newValues.startIndex
16181618
for _ in 0..<count {
1619-
p.initialize(with: newValues[q])
1619+
p.initialize(to: newValues[q])
16201620
newValues.formIndex(after: &q)
16211621
p += 1
16221622
}
@@ -1923,7 +1923,7 @@ internal struct _InitializePointer<T> : _PointerFunction {
19231923
internal func call(_ rawMemory: UnsafeMutablePointer<T>, count: Int) {
19241924
_sanityCheck(count == 1)
19251925
// FIXME: it would be better if we could find a way to move, here
1926-
rawMemory.initialize(with: newValue)
1926+
rawMemory.initialize(to: newValue)
19271927
}
19281928

19291929
@_transparent
@@ -2003,7 +2003,7 @@ internal func _arrayAppendSequence<Buffer, S>(
20032003
let base = buffer.firstElementAddress
20042004

20052005
while (nextItem != nil) && count < capacity {
2006-
(base + count).initialize(with: nextItem!)
2006+
(base + count).initialize(to: nextItem!)
20072007
count += 1
20082008
nextItem = stream.next()
20092009
}

stdlib/public/core/Collection.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1680,7 +1680,7 @@ extension Sequence
16801680
} else {
16811681
var p = ptr
16821682
for x in self {
1683-
p.initialize(with: x)
1683+
p.initialize(to: x)
16841684
p += 1
16851685
}
16861686
return p

stdlib/public/core/ContiguousArrayBuffer.swift

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ final class _ContiguousArrayStorage<Element> : _ContiguousArrayStorage1 {
145145
let resultPtr = result.baseAddress
146146
let p = __manager._elementPointer
147147
for i in 0..<count {
148-
(resultPtr + i).initialize(with: _bridgeToObjectiveCUnconditional(p[i]))
148+
(resultPtr + i).initialize(to: _bridgeToObjectiveCUnconditional(p[i]))
149149
}
150150
_fixLifetime(__manager)
151151
return result
@@ -239,7 +239,7 @@ struct _ContiguousArrayBuffer<Element> : _ArrayBufferProtocol {
239239
let verbatim = false
240240
#endif
241241

242-
__bufferPointer._headerPointer.initialize(with:
242+
__bufferPointer._headerPointer.initialize(to:
243243
_ArrayBody(
244244
count: count,
245245
capacity: capacity,
@@ -608,7 +608,7 @@ internal func _copyCollectionToContiguousArray<
608608
var i = source.startIndex
609609
for _ in 0..<count {
610610
// FIXME(performance): use _copyContents(initializing:).
611-
p.initialize(with: source[i])
611+
p.initialize(to: source[i])
612612
source.formIndex(after: &i)
613613
p += 1
614614
}
@@ -667,7 +667,7 @@ internal struct _UnsafePartiallyInitializedContiguousArrayBuffer<Element> {
667667
"_UnsafePartiallyInitializedContiguousArrayBuffer has no more capacity")
668668
remainingCapacity -= 1
669669

670-
p.initialize(with: element)
670+
p.initialize(to: element)
671671
p += 1
672672
}
673673

0 commit comments

Comments
 (0)