Skip to content

Commit 73b6784

Browse files
committed
Gardening: Migrate test suite to GH issues: validation-test/stdlib
1 parent 42e47d7 commit 73b6784

File tree

6 files changed

+15
-10
lines changed

6 files changed

+15
-10
lines changed

validation-test/stdlib/CollectionType.swift.gyb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -660,7 +660,7 @@ CollectionTypeTests.test("firstIndex(of:)/ContinueSearch") {
660660
// Collection indices types
661661
//===----------------------------------------------------------------------===//
662662

663-
// SR-2121
663+
// https://github.com/apple/swift/issues/44729
664664
extension Collection {
665665
func testIndicesElementType() {
666666
for index in self.indices {

validation-test/stdlib/Dictionary.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5176,7 +5176,7 @@ DictionaryTestSuite.test("updateValue") {
51765176

51775177
DictionaryTestSuite.test("localHashSeeds") {
51785178
// With global hashing, copying elements in hash order between hash tables
5179-
// can become quadratic. (See https://bugs.swift.org/browse/SR-3268)
5179+
// can become quadratic (see https://github.com/apple/swift/issues/45856).
51805180
//
51815181
// We defeat this by mixing the local storage capacity into the global hash
51825182
// seed, thereby breaking the correlation between bucket indices across

validation-test/stdlib/Random.swift

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,8 @@ RandomTests.test("different random number generators") {
236236
expectEqual(shufflePasses[0], shufflePasses[1])
237237
}
238238

239-
// Random floating points with max values (SR-8178)
239+
// https://github.com/apple/swift/issues/50710
240+
// Random floating points with max values
240241

241242
var lcrng = LCRNG(seed: 1234567890)
242243

validation-test/stdlib/Set.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4443,7 +4443,7 @@ SetTestSuite.test("SetAlgebra.UpdateWith.EmptySet") {
44434443

44444444
SetTestSuite.test("localHashSeeds") {
44454445
// With global hashing, copying elements in hash order between hash tables
4446-
// can become quadratic. (See https://bugs.swift.org/browse/SR-3268)
4446+
// can become quadratic (see https://github.com/apple/swift/issues/45856).
44474447
//
44484448
// We defeat this by mixing the local storage capacity into the global hash
44494449
// seed, thereby breaking the correlation between bucket indices across

validation-test/stdlib/Sort-ABI.swift

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,8 @@ SortABITestSuite.test("_merge-ABI") {
2020
}
2121
}
2222
// The return value is legacy ABI. It was originally added as a
23-
// workaround for a compiler bug (now fixed). See SR-14750 (rdar://45044610).
23+
// workaround for a compiler bug (now fixed). See
24+
// https://github.com/apple/swift/issues/57100 (rdar://45044610).
2425
// `_merge` always returns `true`
2526
expectEqual(result, true)
2627
}
@@ -36,7 +37,8 @@ SortABITestSuite.test("_mergeRuns-ABI") {
3637
}
3738
}
3839
// The return value is legacy ABI. It was originally added as a
39-
// workaround for a compiler bug (now fixed). See SR-14750 (rdar://45044610).
40+
// workaround for a compiler bug (now fixed). See
41+
// https://github.com/apple/swift/issues/57100 (rdar://45044610).
4042
// `_mergeRuns` always returns `true`
4143
expectEqual(result, true)
4244
}
@@ -52,7 +54,8 @@ SortABITestSuite.test("_mergeTopRuns-ABI") {
5254
}
5355
}
5456
// The return value is legacy ABI. It was originally added as a
55-
// workaround for a compiler bug (now fixed). See SR-14750 (rdar://45044610).
57+
// workaround for a compiler bug (now fixed). See
58+
// https://github.com/apple/swift/issues/57100 (rdar://45044610).
5659
// `_mergeTopRuns` always returns `true`
5760
expectEqual(result, true)
5861
}
@@ -68,7 +71,8 @@ SortABITestSuite.test("_finalizeRuns-ABI") {
6871
}
6972
}
7073
// The return value is legacy ABI. It was originally added as a
71-
// workaround for a compiler bug (now fixed). See SR-14750 (rdar://45044610).
74+
// workaround for a compiler bug (now fixed). See
75+
// https://github.com/apple/swift/issues/57100 (rdar://45044610).
7276
// `_finalizeRuns` always returns `true`
7377
expectEqual(result, true)
7478
}

validation-test/stdlib/ValidationNSNumberBridging.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -423,7 +423,7 @@ func testNSNumberBridgeFromInt32() {
423423

424424
let float = (number!) as? Float
425425
let expectedFloat = Float(exactly: int32!)
426-
// these are disabled because of https://bugs.swift.org/browse/SR-4634
426+
// FIXME: These are disabled because of https://github.com/apple/swift/issues/47211
427427
if (int32! != Int32.min && int32! != Int32.max &&
428428
int32! != Int32.min + 1 && int32! != Int32.max - 1) {
429429
testFloat(expectedFloat, float)
@@ -468,7 +468,7 @@ func testNSNumberBridgeFromUInt32() {
468468

469469
let float = (number!) as? Float
470470
let expectedFloat = Float(uint32!)
471-
// these are disabled because of https://bugs.swift.org/browse/SR-4634
471+
// FIXME: These are disabled because of https://github.com/apple/swift/issues/47211
472472
if (uint32! != UInt32.max && uint32! != UInt32.max - UInt32(1)) {
473473
testFloat(expectedFloat, float)
474474
}

0 commit comments

Comments
 (0)