[Sema] Run structural/availability diagnostics on tap bodies

Since interpolations are now type-checked using conjunctions
these diagnostics could be rank as part of the root expression
or statement verification.

Author: xedin

lib/Sema/ConstantnessSemaDiagnostics.cpp

@@ -353,14 +353,7 @@ void swift::diagnoseConstantArgumentRequirement(
         return walkToClosureExprPre(closureExpr);
       }
 
-      // Interpolated expressions' bodies will be type checked
-      // separately so exit early to avoid duplicate diagnostics.
-      // The caveat is that they won't be checked inside closure
-      // bodies because we manually check all closures to avoid
-      // duplicate diagnostics. Therefore we must still descend into
-      // interpolated expressions if we are inside of a closure.
-      if (!expr || isa<ErrorExpr>(expr) || !expr->getType() ||
-          (isa<InterpolatedStringLiteralExpr>(expr) && !insideClosure))
+      if (!expr || isa<ErrorExpr>(expr) || !expr->getType())
         return Action::SkipChildren(expr);
       if (auto *callExpr = dyn_cast<CallExpr>(expr)) {
         diagnoseConstantArgumentRequirementOfCall(callExpr, DC->getASTContext());

lib/Sema/MiscDiagnostics.cpp

@@ -134,8 +134,6 @@ static void diagSyntacticUseRestrictions(const Expr *E, const DeclContext *DC,
 
     bool shouldWalkCaptureInitializerExpressions() override { return true; }
 
-    bool shouldWalkIntoTapExpression() override { return false; }
-
     PreWalkResult<Expr *> walkToExprPre(Expr *E) override {
       // See through implicit conversions of the expression.  We want to be able
       // to associate the parent of this expression with the ultimate callee.
@@ -1482,8 +1480,6 @@ static void diagRecursivePropertyAccess(const Expr *E, const DeclContext *DC) {
 
     bool shouldWalkCaptureInitializerExpressions() override { return true; }
 
-    bool shouldWalkIntoTapExpression() override { return false; }
-
     MacroWalking getMacroWalkingBehavior() const override {
       return MacroWalking::Expansion;
     }
@@ -1774,8 +1770,6 @@ static void diagnoseImplicitSelfUseInClosure(const Expr *E,
 
     bool shouldWalkCaptureInitializerExpressions() override { return true; }
 
-    bool shouldWalkIntoTapExpression() override { return false; }
-
     PreWalkResult<Expr *> walkToExprPre(Expr *E) override {
       if (auto *CE = dyn_cast<AbstractClosureExpr>(E)) {
         // If this is a potentially-escaping closure expression, start looking
@@ -4245,8 +4239,6 @@ static void checkStmtConditionTrailingClosure(ASTContext &ctx, const Expr *E) {
 
     bool shouldWalkCaptureInitializerExpressions() override { return true; }
 
-    bool shouldWalkIntoTapExpression() override { return false; }
-
     MacroWalking getMacroWalkingBehavior() const override {
       return MacroWalking::Expansion;
     }
@@ -4376,8 +4368,6 @@ class ObjCSelectorWalker : public ASTWalker {
 
   bool shouldWalkCaptureInitializerExpressions() override { return true; }
 
-  bool shouldWalkIntoTapExpression() override { return false; }
-
   MacroWalking getMacroWalkingBehavior() const override {
     return MacroWalking::Expansion;
   }
@@ -5240,8 +5230,6 @@ static void diagnoseUnintendedOptionalBehavior(const Expr *E,
 
     bool shouldWalkCaptureInitializerExpressions() override { return true; }
 
-    bool shouldWalkIntoTapExpression() override { return false; }
-
     MacroWalking getMacroWalkingBehavior() const override {
       return MacroWalking::Expansion;
     }
@@ -5321,8 +5309,6 @@ static void diagnoseDeprecatedWritableKeyPath(const Expr *E,
 
     bool shouldWalkCaptureInitializerExpressions() override { return true; }
 
-    bool shouldWalkIntoTapExpression() override { return false; }
-
     MacroWalking getMacroWalkingBehavior() const override {
       return MacroWalking::Expansion;
     }
@@ -5617,8 +5603,6 @@ static void diagUnqualifiedAccessToMethodNamedSelf(const Expr *E,
       return false;
     }
 
-    bool shouldWalkIntoTapExpression() override { return false; }
-
     MacroWalking getMacroWalkingBehavior() const override {
       return MacroWalking::Expansion;
     }
@@ -5778,8 +5762,6 @@ diagnoseDictionaryLiteralDuplicateKeyEntries(const Expr *E,
       return false;
     }
 
-    bool shouldWalkIntoTapExpression() override { return false; }
-
     MacroWalking getMacroWalkingBehavior() const override {
       return MacroWalking::Expansion;
     }

lib/Sema/TypeCheckAvailability.cpp

@@ -3191,8 +3191,6 @@ class ExprAvailabilityWalker : public ASTWalker {
     return false;
   }
 
-  bool shouldWalkIntoTapExpression() override { return false; }
-
   MacroWalking getMacroWalkingBehavior() const override {
     // Expanded source should be type checked and diagnosed separately.
     return MacroWalking::Arguments;

lib/Sema/TypeCheckConcurrency.cpp

@@ -2156,8 +2156,6 @@ namespace {
 
     bool shouldWalkCaptureInitializerExpressions() override { return true; }
 
-    bool shouldWalkIntoTapExpression() override { return true; }
-
     MacroWalking getMacroWalkingBehavior() const override {
       return MacroWalking::Expansion;
     }