Skip to content

Commit 7ce49a4

Browse files
authored
Bump macOS deployment target for TSan to 10.13 for LLVM only preset (#64640)
This allows LLVM TSAN tests to pass when using Xcode 14.3. Long term we want to switch to `LLVM_USE_RUNTIMES` to build compiler-rt, so we can leverage the value of `SANITIZER_MIN_OSX_VERSION` set in `cmake_product.py`. In the meantime, we prefer enforcing the deployment in the only preset that needs this, since this currently requires leveraging an intermediate variable (`CLANG_COMPILER_RT_CMAKE_ARGS`) which cannot be easily augmented in preset mixins. Addresses rdar://106441106
1 parent 3f8b9e2 commit 7ce49a4

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

utils/build-presets.ini

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -684,6 +684,12 @@ reconfigure
684684
verbose-build
685685
build-ninja
686686

687+
# TODO: remove when we will transition from LLVM_TOOL_COMPILER_RT_BUILD
688+
# to LLVM_USE_RUNTIMES to build compiler-rt (#60993), so we can leverage
689+
# the value for SANITIZER_MIN_OSX_VERSION set in cmake_product.py
690+
extra-cmake-options=
691+
-DCLANG_COMPILER_RT_CMAKE_ARGS:STRING="-DSANITIZER_MIN_OSX_VERSION:STRING=10.13"
692+
687693
# Do not build swift or cmark
688694
skip-build-swift
689695
skip-build-cmark

0 commit comments

Comments
 (0)