Skip to content

Commit 7e286fd

Browse files
committed
Don’t suggest adding the project in the "submit a bug report" message
Instead, stimulate users to follow the referenced bug reporting guidelines, which contain all the necessary information. We’d rather encourage attempts at reducing issues before attaching Xcode projects. This is an accompaniment to swiftlang/swift-org-website#158.
1 parent d124b35 commit 7e286fd

File tree

4 files changed

+5
-6
lines changed

4 files changed

+5
-6
lines changed

include/swift/Basic/Compiler.h

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -94,14 +94,13 @@
9494
#endif
9595

9696
#define SWIFT_BUG_REPORT_MESSAGE_BASE \
97-
"submit a bug report (" SWIFT_BUG_REPORT_URL \
98-
") and include the project"
97+
"submit a bug report (" SWIFT_BUG_REPORT_URL ")"
9998

10099
#define SWIFT_BUG_REPORT_MESSAGE \
101100
"please " SWIFT_BUG_REPORT_MESSAGE_BASE
102101

103102
#define SWIFT_CRASH_BUG_REPORT_MESSAGE \
104-
"Please " SWIFT_BUG_REPORT_MESSAGE_BASE " and the crash backtrace."
103+
"Please " SWIFT_BUG_REPORT_MESSAGE_BASE " and include the crash backtrace."
105104

106105
// Conditionally exclude declarations or statements that are only needed for
107106
// assertions from release builds (NDEBUG) without cluttering the surrounding

test/Frontend/batch_mode_output_file_map_missing_primary.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,4 @@
55
// RUN: not %target-swift-frontend -parse -primary-file main.swift -primary-file file-01.swift -supplementary-output-file-map %S/Inputs/supplementary_output_filemap_missing_a_primary.yaml >%t/errs.txt 2>&1
66
// RUN: %FileCheck %s <%t/errs.txt
77

8-
// CHECK: error: supplementary output file map '{{.*}}supplementary_output_filemap_missing_a_primary.yaml' is missing an entry for 'file-01.swift' (this likely indicates a compiler issue; please submit a bug report (https://swift.org/contributing/#reporting-bugs) and include the project)
8+
// CHECK: error: supplementary output file map '{{.*}}supplementary_output_filemap_missing_a_primary.yaml' is missing an entry for 'file-01.swift' (this likely indicates a compiler issue; please submit a bug report (https://swift.org/contributing/#reporting-bugs)){{$}}

test/Sema/rdar38885760.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
// RUN: not %target-swift-frontend -typecheck %s -parse-stdlib 2>%t/fallback_diagnostic.txt
44
// RUN: %FileCheck %s --check-prefix FALLBACK-DIAGNOSTIC <%t/fallback_diagnostic.txt
55
//
6-
// FALLBACK-DIAGNOSTIC: error: failed to produce diagnostic for expression; please submit a bug report (https://swift.org/contributing/#reporting-bugs) and include the project
6+
// FALLBACK-DIAGNOSTIC: error: failed to produce diagnostic for expression; please submit a bug report (https://swift.org/contributing/#reporting-bugs){{$}}
77

88
import Swift
99

test/Serialization/Recovery/crash-recovery.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ public class Sub: Base {
1212
public override func disappearingMethod() {}
1313
}
1414

15-
// CHECK-CRASH: error: fatal error encountered while reading from module 'Lib'; please submit a bug report (https://swift.org/contributing/#reporting-bugs) and include the project
15+
// CHECK-CRASH: error: fatal error encountered while reading from module 'Lib'; please submit a bug report (https://swift.org/contributing/#reporting-bugs){{$}}
1616
// CHECK-CRASH-4: Compiling with effective version 4.1.50
1717
// CHECK-CRASH-4_2: Compiling with effective version 4.2
1818
// CHECK-CRASH: While loading members for 'Sub' (in module 'Lib')

0 commit comments

Comments
 (0)