[NFC] [ASTGen] Make BridgedDecl.attrs property

…subsuming BridgedDecl.setAttrs(_:) as its setter.

Author: beccadax

include/swift/AST/ASTBridging.h

@@ -841,7 +841,10 @@ BridgedSILGenNameAttr BridgedSILGenNameAttr_createParsed(
 // MARK: Decls
 //===----------------------------------------------------------------------===//
 
-SWIFT_NAME("BridgedDecl.setAttrs(self:_:)")
+SWIFT_NAME("getter:BridgedDecl.attrs(self:)")
+BridgedDeclAttributes BridgedDecl_getAttrs(BridgedDecl decl);
+
+SWIFT_NAME("setter:BridgedDecl.attrs(self:newValue:)")
 void BridgedDecl_setAttrs(BridgedDecl decl, BridgedDeclAttributes attrs);
 
 enum ENUM_EXTENSIBILITY_ATTR(closed) BridgedStaticSpelling {

lib/AST/Bridging/DeclBridging.cpp

@@ -115,6 +115,10 @@ static AccessorKind unbridged(BridgedAccessorKind kind) {
   return static_cast<AccessorKind>(kind);
 }
 
+BridgedDeclAttributes BridgedDecl_getAttrs(BridgedDecl decl) {
+  return decl.unbridged()->getAttrs();
+}
+
 void BridgedDecl_setAttrs(BridgedDecl decl, BridgedDeclAttributes attrs) {
   decl.unbridged()->getAttrs() = attrs.unbridged();
 }

lib/ASTGen/Sources/ASTGen/Decls.swift

@@ -96,7 +96,7 @@ extension ASTGenVisitor {
       underlyingType: self.generate(type: node.initializer.value),
       genericWhereClause: self.generate(genericWhereClause: node.genericWhereClause)
     )
-    decl.asDecl.setAttrs(attrs.attributes)
+    decl.asDecl.attrs = attrs.attributes
     return decl
   }
 
@@ -118,7 +118,7 @@ extension ASTGenVisitor {
         end: node.memberBlock.rightBrace
       )
     )
-    decl.asDecl.setAttrs(attrs.attributes)
+    decl.asDecl.attrs = attrs.attributes
 
     self.withDeclContext(decl.asDeclContext) {
       decl.setParsedMembers(self.generate(memberBlockItemList: node.memberBlock.members))
@@ -145,7 +145,7 @@ extension ASTGenVisitor {
         end: node.memberBlock.rightBrace
       )
     )
-    decl.asDecl.setAttrs(attrs.attributes)
+    decl.asDecl.attrs = attrs.attributes
 
     self.withDeclContext(decl.asDeclContext) {
       decl.setParsedMembers(self.generate(memberBlockItemList: node.memberBlock.members))
@@ -173,7 +173,7 @@ extension ASTGenVisitor {
       ),
       isActor: false
     )
-    decl.asDecl.setAttrs(attrs.attributes)
+    decl.asDecl.attrs = attrs.attributes
 
     self.withDeclContext(decl.asDeclContext) {
       decl.setParsedMembers(self.generate(memberBlockItemList: node.memberBlock.members))
@@ -201,7 +201,7 @@ extension ASTGenVisitor {
       ),
       isActor: true
     )
-    decl.asDecl.setAttrs(attrs.attributes)
+    decl.asDecl.attrs = attrs.attributes
 
     self.withDeclContext(decl.asDeclContext) {
       decl.setParsedMembers(self.generate(memberBlockItemList: node.memberBlock.members))
@@ -231,7 +231,7 @@ extension ASTGenVisitor {
         end: node.memberBlock.rightBrace
       )
     )
-    decl.asDecl.setAttrs(attrs.attributes)
+    decl.asDecl.attrs = attrs.attributes
 
     self.withDeclContext(decl.asDeclContext) {
       decl.setParsedMembers(self.generate(memberBlockItemList: node.memberBlock.members))
@@ -254,7 +254,7 @@ extension ASTGenVisitor {
       defaultType: self.generate(type: node.initializer?.value),
       genericWhereClause: self.generate(genericWhereClause: node.genericWhereClause)
     )
-    decl.asDecl.setAttrs(attrs.attributes)
+    decl.asDecl.attrs = attrs.attributes
     return decl
   }
 }
@@ -276,7 +276,7 @@ extension ASTGenVisitor {
         end: node.memberBlock.rightBrace
       )
     )
-    decl.asDecl.setAttrs(attrs.attributes)
+    decl.asDecl.attrs = attrs.attributes
 
     self.withDeclContext(decl.asDeclContext) {
       decl.setParsedMembers(self.generate(memberBlockItemList: node.memberBlock.members))
@@ -309,7 +309,7 @@ extension ASTGenVisitor {
     // All attributes goes to each element.
     let elements = node.elements.lazy.map({ elem -> BridgedEnumElementDecl in
       let elemDecl = self.generate(enumCaseElement: elem)
-      elemDecl.asDecl.setAttrs(attrs.attributes)
+      elemDecl.asDecl.attrs = attrs.attributes
       return elemDecl
     })
     return .createParsed(
@@ -536,7 +536,7 @@ extension ASTGenVisitor {
       arrowLoc: self.generateSourceLoc(node.returnClause.arrow),
       returnType: self.generate(type: node.returnClause.type)
     )
-    subscriptDecl.asDecl.setAttrs(attrs.attributes)
+    subscriptDecl.asDecl.attrs = attrs.attributes
 
     if let accessors = node.accessorBlock {
       let storage = subscriptDecl.asAbstractStorageDecl
@@ -570,7 +570,7 @@ extension ASTGenVisitor {
       returnType: self.generate(type: node.signature.returnClause?.type),
       genericWhereClause: self.generate(genericWhereClause: node.genericWhereClause)
     )
-    decl.asDecl.setAttrs(attrs.attributes)
+    decl.asDecl.attrs = attrs.attributes
 
     if let body = node.body {
       self.withDeclContext(decl.asDeclContext) {
@@ -597,7 +597,7 @@ extension ASTGenVisitor {
       thrownType: self.generate(type: node.signature.effectSpecifiers?.thrownError),
       genericWhereClause: self.generate(genericWhereClause: node.genericWhereClause)
     )
-    decl.asDecl.setAttrs(attrs.attributes)
+    decl.asDecl.attrs = attrs.attributes
 
     if let body = node.body {
       self.withDeclContext(decl.asDeclContext) {
@@ -616,7 +616,7 @@ extension ASTGenVisitor {
       declContext: self.declContext,
       deinitKeywordLoc: self.generateSourceLoc(node.deinitKeyword)
     )
-    decl.asDecl.setAttrs(attrs.attributes)
+    decl.asDecl.attrs = attrs.attributes
 
     if let body = node.body {
       self.withDeclContext(decl.asDeclContext) {
@@ -783,7 +783,7 @@ extension ASTGenVisitor {
       lowerThanNames: self.generate(precedenceGroupNameList: body.lowerThanRelation?.precedenceGroups),
       rightBraceLoc: self.generateSourceLoc(node.rightBrace)
     )
-    decl.asDecl.setAttrs(attrs.attributes)
+    decl.asDecl.attrs = attrs.attributes
     return decl
   }
 }
@@ -830,7 +830,7 @@ extension ASTGenVisitor {
         self.generateLocatedIdentifier($0.name)
       }.bridgedArray(in: self)
     )
-    decl.asDecl.setAttrs(attrs.attributes)
+    decl.asDecl.attrs = attrs.attributes
     return decl
   }
 }