Gardening: Migrate test suite to GH issues: Constraints (1/5)

Author: AnthonyLatsis

test/Constraints/ErrorBridging.swift

@@ -43,7 +43,9 @@ let e1fix = ns1 as FooError // expected-error {{'NSError' is not convertible to
 let esub = ns1 as Error
 let esub2 = ns1 as? Error // expected-warning{{conditional cast from 'NSError' to 'any Error' always succeeds}}
 
-// SR-1562 / rdar://problem/26370984
+// rdar://problem/26370984
+// https://github.com/apple/swift/issues/44171
+
 enum MyError : Error {
   case failed
 }

test/Constraints/array_literal_local_array.swift

@@ -1,6 +1,8 @@
 // RUN: %target-typecheck-verify-swift
 
-// SR-9611: Array type locally interferes with array literals.
+/// https://github.com/apple/swift/issues/52057
+/// `Array` type locally interferes with array literals
+
 struct Array { }
 
 func foo() {

test/Constraints/assignment.swift

@@ -71,18 +71,20 @@ func f23798944() {
   }
 }
 
-.sr_3506 = 0 // expected-error {{type 'Int' has no member 'sr_3506'}}
-
-// SR-1553
+// https://github.com/apple/swift/issues/46094
+do {
+  .x = 0 // expected-error {{type 'Int' has no member 'x'}}
+}
 
+// https://github.com/apple/swift/issues/44162
 func returnsVoid() {}
 _ = returnsVoid() // expected-warning {{using '_' to ignore the result of a Void-returning function is redundant}}{{1-5=}}
 
-// SR-14003
-class SR14003 {
-  var callback: ((SR14003) -> Void)!
+// https://github.com/apple/swift/issues/56396
+class С_56396 {
+  var callback: ((С_56396) -> Void)!
 
   func setCallback(_ callback: @escaping (Self) -> Void) {
-    self.callback = callback // expected-error {{cannot assign value of type '(Self) -> Void' to type '((SR14003) -> Void)?'}}
+    self.callback = callback // expected-error {{cannot assign value of type '(Self) -> Void' to type '((С_56396) -> Void)?'}}
   }
 }

test/Constraints/associated_types.swift

@@ -32,13 +32,13 @@ func owl3() {
   Owl<Spoon>().eat(Mince(), with:Spoon())
 }
 
-// "Can't access associated types through class-constrained generic parameters"
-// (https://bugs.swift.org/browse/SR-726)
+// https://github.com/apple/swift/issues/43341
+// Can't access associated types through class-constrained generic parameters
 func spoon<S: Spoon>(_ s: S) {
   let _: S.Runcee?
 }
 
-// SR-4143
+// https://github.com/apple/swift/issues/46726
 
 protocol SameTypedDefault {
     associatedtype X
@@ -109,15 +109,15 @@ struct UsesSameTypedDefaultDerivedWithoutSatisfyingReqts: SameTypedDefaultDerive
     static var y: YType { return YType() }
 }
 
-// SR-12199
+// https://github.com/apple/swift/issues/54624
 
-protocol SR_12199_P1 {
+protocol P1_54624 {
   associatedtype Assoc // expected-note {{'Assoc' declared here}}
 }
 
-enum SR_12199_E {}
+enum E_54624 {}
 
-protocol SR_12199_P2: SR_12199_P1 where Assoc == SR_12199_E {
-  associatedtype Assoc: SR_12199_E // expected-error {{type 'Self.Assoc' constrained to non-protocol, non-class type 'SR_12199_E'}}
-  // expected-warning@-1 {{redeclaration of associated type 'Assoc' from protocol 'SR_12199_P1' is better expressed as a 'where' clause on the protocol}}
+protocol P2_54624: P1_54624 where Assoc == E_54624 {
+  associatedtype Assoc: E_54624 // expected-error {{type 'Self.Assoc' constrained to non-protocol, non-class type 'E_54624'}}
+  // expected-warning@-1 {{redeclaration of associated type 'Assoc' from protocol 'P1_54624' is better expressed as a 'where' clause on the protocol}}
 }

test/Constraints/availability.swift

@@ -38,8 +38,8 @@ func test_contextual_member_with_availability() {
 @available(*, unavailable)
 func unavailableFunction(_ x: Int) -> Bool { true } // expected-note {{'unavailableFunction' has been explicitly marked unavailable here}}
 
-// SR-13260: Availability checking not working in the where clause of a for
-// loop.
-func sr13260(_ arr: [Int]) {
+/// https://github.com/apple/swift/issues/55700
+/// Availability checking not working in the `where` clause of a `for` loop
+func f_55700(_ arr: [Int]) {
   for x in arr where unavailableFunction(x) {} // expected-error {{'unavailableFunction' is unavailable}}
 }

test/Constraints/bridging.swift

@@ -395,15 +395,17 @@ func rdar60501780() {
   }
 }
 
-// SR-15161
-func SR15161_as(e: Error?) {
-  let _ = e as? NSError // Ok
-}
+// https://github.com/apple/swift/issues/57484
+do {
+  func as1(e: Error?) {
+    let _ = e as? NSError // Ok
+  }
 
-func SR15161_is(e: Error?) {
-  _ = e is NSError // expected-warning{{checking a value with optional type '(any Error)?' against type 'NSError' succeeds whenever the value is non-nil; did you mean to use '!= nil'?}}
-}
+  func as2(e: Error?) {
+    let _ = e as! NSError // expected-warning{{forced cast from '(any Error)?' to 'NSError' only unwraps and bridges; did you mean to use '!' with 'as'?}}
+  }
 
-func SR15161_as_1(e: Error?) {
-  let _ = e as! NSError // expected-warning{{forced cast from '(any Error)?' to 'NSError' only unwraps and bridges; did you mean to use '!' with 'as'?}}
+  func is1(e: Error?) {
+    _ = e is NSError // expected-warning{{checking a value with optional type '(any Error)?' against type 'NSError' succeeds whenever the value is non-nil; did you mean to use '!= nil'?}}
+  }
 }

test/Constraints/casts_objc.swift

@@ -43,8 +43,9 @@ func test(_ a : CFString!, b : CFString) {
 let r22507759: NSObject! = "test" as NSString
 let _: NSString! = unsafeDowncast(r22507759)  // expected-error {{missing argument for parameter 'to' in call}}
 
-// rdar://problem/29496775 / SR-3319
-func sr3319(f: CGFloat, n: NSNumber) {
+// rdar://problem/29496775
+// https://github.com/apple/swift/issues/45907
+func f_45907(f: CGFloat, n: NSNumber) {
   let _ = [f].map { $0 as NSNumber }
   let _ = [n].map { $0 as! CGFloat }
 }

test/Constraints/diag_ambiguities.swift

@@ -42,7 +42,8 @@ func rdar29907555(_ value: Any!) -> String {
   // expected-note@-2 {{provide a default value to avoid this warning}}
 }
 
-struct SR3715 {
+// https://github.com/apple/swift/issues/46300
+struct S_46300 {
   var overloaded: Int! // expected-note {{implicitly unwrapped property 'overloaded' declared here}}
 
   func overloaded(_ x: Int) {}
@@ -73,8 +74,9 @@ class MoviesViewController {
   }
 }
 
-// SR-15053
-func SR15053<T : Numeric>(_ a: T, _ b: T) -> T {
+// https://github.com/apple/swift/issues/57380
+
+func f1_57380<T : Numeric>(_ a: T, _ b: T) -> T {
   (a + b) / 2 // expected-note {{overloads for '/' exist with these partially matching parameter lists: (Int, Int)}}
   // expected-error@-1 {{binary operator '/' cannot be applied to operands of type 'T' and 'Int'}}
 }
@@ -89,7 +91,7 @@ func %% (_ lhs: Float, _ rhs: Float) -> Float {
   lhs / rhs
 }
 
-func SR15053<T : Numeric>(_ a: T, _ b: T) {
+func f2_57380<T : Numeric>(_ a: T, _ b: T) {
   (a + b) %% 2 // expected-error {{cannot convert value of type 'T' to expected argument type 'Int'}}
 }
 

test/Constraints/dictionary_literal.swift

@@ -150,7 +150,9 @@ func testDefaultExistentials() {
   // expected-error@-1{{heterogeneous collection literal could only be inferred to '[AnyHashable : String]'}}
 }
 
-// SR-4952, rdar://problem/32330004 - Assertion failure during swift::ASTVisitor<::FailureDiagnosis,...>::visit
+/// rdar://problem/32330004
+/// https://github.com/apple/swift/issues/47529
+/// Assertion failure during `swift::ASTVisitor<::FailureDiagnosis,...>::visit`
 func rdar32330004_1() -> [String: Any] {
   return ["a""one": 1, "two": 2, "three": 3] // expected-note {{did you mean to use a dictionary literal instead?}}
   // expected-error@-1 {{expected ',' separator}}

test/Constraints/dynamic_lookup.swift

@@ -408,22 +408,25 @@ func testAnyObjectAmbiguity(_ x: AnyObject) {
   _ = x.ambiguousMethodParam // expected-error {{ambiguous use of 'ambiguousMethodParam'}}
   _ = x.unambiguousMethodParam
 
-  // SR-12799: Don't emit a "single-element" tuple error.
+  // https://github.com/apple/swift/issues/55244
+  // Don't emit a single-element tuple error.
   _ = x[singleCandidate: 0]
 
   _ = x[ambiguousSubscript: 0] // expected-error {{ambiguous use of 'subscript(ambiguousSubscript:)'}}
   _ = x[ambiguousSubscript: 0] as Int
   _ = x[ambiguousSubscript: 0] as String
 
-  // SR-8611: Make sure we can coalesce subscripts with the same types and
-  // selectors through AnyObject lookup.
+  // https://github.com/apple/swift/issues/51126
+  // Make sure we can coalesce subscripts with the same types and selectors
+  // through AnyObject lookup.
   _ = x[unambiguousSubscript: ""]
 
   // But not if they have different selectors.
   _ = x[differentSelectors: 0] // expected-error {{ambiguous use of 'subscript(differentSelectors:)}}
 }
 
-// SR-11648
+// https://github.com/apple/swift/issues/54059
+
 class HasMethodWithDefault {
   @objc func hasDefaultParam(_ x: Int = 0) {}
 }
@@ -432,7 +435,9 @@ func testAnyObjectWithDefault(_ x: AnyObject) {
   x.hasDefaultParam()
 }
 
-// SR-11829: Don't perform dynamic lookup for callAsFunction.
+/// https://github.com/apple/swift/issues/54241
+/// Don't perform dynamic lookup for `callAsFunction`.
+
 class ClassWithObjcCallAsFunction {
   @objc func callAsFunction() {}
 }
@@ -462,6 +467,7 @@ func test_dynamic_subscript_accepts_type_name_argument() {
 func testAnyObjectConstruction(_ x: AnyObject) {
   AnyObject() // expected-error {{type 'AnyObject' cannot be instantiated}}
 
-  // FIXME(SR-15210): This should also be rejected.
+  // https://github.com/apple/swift/issues/57532
+  // FIXME: This should also be rejected.
   _ = type(of: x).init()
 }